From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] python.el: Returning inferior Python output without inhibiting it Date: Mon, 02 Oct 2023 21:42:43 +0900 Message-ID: References: <87msx2ib0c.fsf@gmail.com> <83fs2u8ehy.fsf@gnu.org> <87jzs6hz26.fsf@gmail.com> <837co58t8h.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39480"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Jack Kamm , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 02 17:58:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnLJw-0009rV-7E for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Oct 2023 17:58:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnLIn-0003FS-QB; Mon, 02 Oct 2023 11:57:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnIGS-0003I0-84 for emacs-devel@gnu.org; Mon, 02 Oct 2023 08:43:08 -0400 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnIGO-0003Kr-9X; Mon, 02 Oct 2023 08:43:07 -0400 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c328b53aeaso147235755ad.2; Mon, 02 Oct 2023 05:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696250582; x=1696855382; darn=gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=8C4yiLySlUsI7AOHq0INTFPwhF0O3+q47rAZw/i3Wo8=; b=O4bTo2J9SEXFKORIxYurPZECLROzrEdZPoa9pHq52F/vgXjyLVcUGwvdgFaKOyyD8d 1NuNkWmZtTZ8Lp0o+zdgdU5zEH2BTZUbA9gf7uQSdhyAvd80XzNSTILazSe37+tiV5i7 kc8/C7yZJANW4bfPCy+I00Qx/bTzQIiF+R18lmXA01d0AMlfUUtbrC5Dvn9dDUDf2HsP MkMi1Kc4Hxh+dbfZLVR1kVHaeIPzzwhrT2ufhEWfj6BI50sqyYIDReLkG2C+OcqZsubB DZt/B6o1HrdDUDo1N+DTNfRYUos7igfchWD19fuF2LETwVCOTfw/I7Pth3NMCcMr5oaO ILLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696250582; x=1696855382; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8C4yiLySlUsI7AOHq0INTFPwhF0O3+q47rAZw/i3Wo8=; b=OwJ74uLsV7Uyd3fMsTb/A7sh2JIB3dIZNCH1sxnxo5mA1ZfGq+1tMAVKA1oelIHPo7 bHulBglyqOGTxw2P/htckmuxCIXWhkP5SFi7+bo7FvlV4djkF0dQixVqJVfeHSHtw78N Vo+1c3OWXpENDX6lhpklkhIke5pcaV47lbABGmvvSxr33WILw3LsEKEO/ERsyeM0G2Dr FknjEh4lFnwoLIlXFSZK+EntRNlpyewOYWoSWfwMPZeWuA8pItoiGIoChkWQn/jQlMZI FaeCDlMUwfu/lbdENeZRvqJ+KGTPKvdh/fcJTOSEOWYHocjeMdBauqPs+8Ya1SkVMWxG pb5w== X-Gm-Message-State: AOJu0YzJn5TsBiG6vqKnbc8vXoI0Rn/cRXQOowmCAa0N4gwt3Bo6ov/+ X33hKrcjB8EbY3FTaJbOfGKmSrqV8yM= X-Google-Smtp-Source: AGHT+IFDS57rgWhAbHfHOyMDczCDwt8N3ixc5by+jsmwTHQGcuO5zQNV09VNUZWvSotHaoCKgK40fg== X-Received: by 2002:a17:903:2581:b0:1c5:c546:febf with SMTP id jb1-20020a170903258100b001c5c546febfmr9770773plb.35.1696250582030; Mon, 02 Oct 2023 05:43:02 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id i3-20020a170902c94300b001c6092d35b9sm16960517pla.85.2023.10.02.05.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 05:43:01 -0700 (PDT) In-Reply-To: <837co58t8h.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=kobarity@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 02 Oct 2023 11:57:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311237 Archived-At: Eli Zaretskii wrote: > > > From: Jack Kamm > > Cc: emacs-devel@gnu.org > > Date: Sun, 01 Oct 2023 13:23:29 -0700 > > > > Eli Zaretskii writes: > > > > > I think instead of renaming (which then requires us to add an obsolete > > > alias), it would be better to leave python-shell-send-string-no-output > > > available, but just make it a thin wrapper around > > > python-shell-send-string-return-output (which I would suggest to name > > > python-shell-send-string-maybe-output instead). This way, we don't > > > annoy Lisp programs that use python-shell-send-string-no-output with > > > obsolescence warnings. > > > > Thanks for the feedback -- I've updated the patch accordingly (attached). > > Thanks. kobarity, any comments or suggestions? I agree with leaving `python-shell-send-string-no-output' as it is. The updated patch looks good to me.