* Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes
@ 2009-09-30 15:56 Reimar Finken
0 siblings, 0 replies; 3+ messages in thread
From: Reimar Finken @ 2009-09-30 15:56 UTC (permalink / raw
To: emacs-orgmode
Clocking in on any task (C-c C-x C-i), e.g. in the org file
* A task
on
Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4)
of 2009-07-30 on build21
Package: Org-mode version 6.31 (release_6.31)
current state:
==============
(setq
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe)
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-mode-hook '((lambda nil
(org-add-hook (quote change-major-mode-hook)
(quote org-show-block-all) (quote append) (quote local))
)
)
org-confirm-elisp-link-function 'yes-or-no-p
org-occur-hook '(org-first-headline-recenter)
)
--
Dr. Reimar Finken (finken@theo2.physik.uni-stuttgart.de)
II. Institut für Theoretische Physik, Universität Stuttgart
Pfaffenwaldring 57 Tel: 0711-68564924
70550 Stuttgart, Germany Fax: 0711-68564902
^ permalink raw reply [flat|nested] 3+ messages in thread
* Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes
@ 2009-09-30 15:56 Reimar Finken
2009-10-01 18:01 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Reimar Finken @ 2009-09-30 15:56 UTC (permalink / raw
To: emacs-orgmode
[Sorry for the double post, I was too quick with my C-c C-c]
Clocking in on any task (C-c C-x C-i) and cancelling afterwards (C-c C-x
C-x) results in the following backtrace:
,----
| Debugger entered--Lisp error: (wrong-type-argument markerp org-clock-marker)
| move-marker(org-clock-marker nil)
| org-clock-cancel()
| call-interactively(org-clock-cancel nil nil)
`----
Culprit are two erroneous quotes in front of org-clock-marker in org-clock-el. The patch (output
of git diff -u on a clean checkout) fixes the problem:
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index e279898..91a4bcb 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -818,8 +818,8 @@ If there is no running clock, throw an error, unless FAIL-QUIETLY is set."
(set-buffer (marker-buffer org-clock-marker))
(goto-char org-clock-marker)
(delete-region (1- (point-at-bol)) (point-at-eol)))
- (move-marker 'org-clock-marker nil)
- (move-marker 'org-clock-hd-marker nil)
+ (move-marker org-clock-marker nil)
+ (move-marker org-clock-hd-marker nil)
(setq global-mode-string
(delq 'org-mode-line-string global-mode-string))
(force-mode-line-update)
Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4)
of 2009-07-30 on build21
Package: Org-mode version 6.31 (release_6.31)
current state:
==============
(setq
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe)
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-mode-hook '((lambda nil
(org-add-hook (quote change-major-mode-hook)
(quote org-show-block-all) (quote append) (quote local))
)
)
org-confirm-elisp-link-function 'yes-or-no-p
org-occur-hook '(org-first-headline-recenter)
)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes
2009-09-30 15:56 Reimar Finken
@ 2009-10-01 18:01 ` Carsten Dominik
0 siblings, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2009-10-01 18:01 UTC (permalink / raw
To: Reimar Finken; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Sep 30, 2009, at 5:56 PM, Reimar Finken wrote:
> [Sorry for the double post, I was too quick with my C-c C-c]
> Clocking in on any task (C-c C-x C-i) and cancelling afterwards (C-c
> C-x
> C-x) results in the following backtrace:
> ,----
> | Debugger entered--Lisp error: (wrong-type-argument markerp org-
> clock-marker)
> | move-marker(org-clock-marker nil)
> | org-clock-cancel()
> | call-interactively(org-clock-cancel nil nil)
> `----
> Culprit are two erroneous quotes in front of org-clock-marker in org-
> clock-el. The patch (output
> of git diff -u on a clean checkout) fixes the problem:
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index e279898..91a4bcb 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -818,8 +818,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (set-buffer (marker-buffer org-clock-marker))
> (goto-char org-clock-marker)
> (delete-region (1- (point-at-bol)) (point-at-eol)))
> - (move-marker 'org-clock-marker nil)
> - (move-marker 'org-clock-hd-marker nil)
> + (move-marker org-clock-marker nil)
> + (move-marker org-clock-hd-marker nil)
> (setq global-mode-string
> (delq 'org-mode-line-string global-mode-string))
> (force-mode-line-update)
>
>
>
>
> Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4)
> of 2009-07-30 on build21
> Package: Org-mode version 6.31 (release_6.31)
>
> current state:
> ==============
> (setq
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-export-preprocess-hook '(org-export-blocks-preprocess)
> org-tab-first-hook '(org-hide-block-toggle-maybe)
> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
> org-confirm-shell-link-function 'yes-or-no-p
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-
> drawers
> org-cycle-show-empty-lines
> org-optimize-window-after-visibility-change)
> org-mode-hook '((lambda nil
> (org-add-hook (quote change-major-mode-hook)
> (quote org-show-block-all) (quote append) (quote local))
> )
> )
> org-confirm-elisp-link-function 'yes-or-no-p
> org-occur-hook '(org-first-headline-recenter)
> )
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-01 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-30 15:56 Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes Reimar Finken
-- strict thread matches above, loose matches on Subject: below --
2009-09-30 15:56 Reimar Finken
2009-10-01 18:01 ` Carsten Dominik
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.