Re: detecting charset of directories

Re: detecting charset of directories

[Kenichi Handa]

In article <20061020142038.99914.qmail@web51005.mail.yahoo.com>, Kevin Rodgers <ihs_4664@yahoo.com> writes:

> > > Also, how can one ensure that `C-x m c CODING-SYSTEM g' will (1) have
> > > its intended effect and (2) persist its effect, for subsequent `g'
> > > commands?
> > 
> > Sorry, I don't understand what you mean.  Could you please
> > paraphrase it?

> [Sorry, `C-x m c ...' should have been `C-x C-m c ...']

> Let's say you are in a Dired buffer and you realize the coding system is
> wrong, so you try to re-read it with `C-x RET c CODING-SYSTEM g'.  Does
> that work?  If later you decide to simply run `g', does it use
> CODING-SYSTEM to re-read the directory?

> I think to make that work, dired-revert needs the same fix as
> dired-mode, namely:

> (set (make-local-variable 'file-name-coding-system)
>      (or coding-system-for-read file-name-coding-system))

> Or perhaps that should be done later in just one place: dired-readin.

I basically agree with you, but as I don't know the code of
dired, I don't know which part is the right place to fix.
I'd like to ask maintainers of dired.el to work on it.

---
Kenichi Handa
handa@m17n.org

Re: detecting charset of directories

[Richard Stallman]

    > I think to make that work, dired-revert needs the same fix as
    > dired-mode, namely:

    > (set (make-local-variable 'file-name-coding-system)
    >      (or coding-system-for-read file-name-coding-system))

Kevin, I don't understand that suggestion.  I don't see anything
like that code in dired-mode.

Are you proposing a change to dired-mode AND a change to dired-revert?

Could use diff to show the change you are suggesting?

Re: detecting charset of directories

[Kevin Rodgers]

Richard Stallman wrote:
>     > I think to make that work, dired-revert needs the same fix as
>     > dired-mode, namely:
> 
>     > (set (make-local-variable 'file-name-coding-system)
>     >      (or coding-system-for-read file-name-coding-system))
> 
> Kevin, I don't understand that suggestion.  I don't see anything
> like that code in dired-mode.
> 
> Are you proposing a change to dired-mode AND a change to dired-revert?

Yes, that is what I am proposing.  Or alternatively, a single change
to dired-readin.

> Could use diff to show the change you are suggesting?

*** lisp/dired.el~	2006-10-23 11:58:19.628889700 -0600
--- lisp/dired.el	2006-10-23 12:02:15.497851300 -0600
***************
*** 1042,1047 ****
--- 1042,1049 ----
       ;; treat top level dir extra (it may contain wildcards)
       (dired-uncache
        (if (consp dired-directory) (car dired-directory) dired-directory))
+     (set (make-local-variable 'file-name-coding-system)
+ 	 (or coding-system-for-read file-name-coding-system))
       (dired-readin)
       (let ((dired-after-readin-hook nil))
         ;; don't run that hook for each subdir...
***************
*** 1627,1632 ****
--- 1629,1636 ----
          '(dired-font-lock-keywords t nil nil beginning-of-line))
     (set (make-local-variable 'desktop-save-buffer)
          'dired-desktop-buffer-misc-data)
+   (set (make-local-variable 'file-name-coding-system)
+        (or coding-system-for-read file-name-coding-system))
     (setq dired-switches-alist nil)
     (dired-sort-other dired-actual-switches t)
     (when (featurep 'dnd)

-- 
Kevin

Re: detecting charset of directories

[Richard Stallman]

Does this work right?

*** dired.el	01 Oct 2006 23:09:50 -0400	1.352
--- dired.el	24 Oct 2006 07:52:31 -0400	
***************
*** 791,796 ****
--- 791,798 ----
        (run-hooks 'dired-before-readin-hook)
        (if (consp buffer-undo-list)
  	  (setq buffer-undo-list nil))
+       (set (make-local-variable 'file-name-coding-system)
+ 	   (or coding-system-for-read file-name-coding-system))
        (let (buffer-read-only
  	    ;; Don't make undo entries for readin.
  	    (buffer-undo-list t))