From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.pretest.bugs,gmane.emacs.devel Subject: Re: detecting charset of directories Date: Mon, 23 Oct 2006 12:05:01 -0600 Organization: IHS Message-ID: References: <20061020142038.99914.qmail@web51005.mail.yahoo.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1161626901 18565 80.91.229.2 (23 Oct 2006 18:08:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2006 18:08:21 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Mon Oct 23 20:08:11 2006 Return-path: Envelope-to: gebp-emacs-pretest-bug@gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gc4D3-0005Iy-3u for gebp-emacs-pretest-bug@gmane.org; Mon, 23 Oct 2006 20:07:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc4D2-0001wg-Mu for gebp-emacs-pretest-bug@gmane.org; Mon, 23 Oct 2006 14:07:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gc4Cy-0001t1-Gc for emacs-pretest-bug@gnu.org; Mon, 23 Oct 2006 14:07:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gc4Cv-0001nS-0N for emacs-pretest-bug@gnu.org; Mon, 23 Oct 2006 14:07:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc4Cu-0001n6-PW for emacs-pretest-bug@gnu.org; Mon, 23 Oct 2006 14:07:28 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gc4Cu-0003Zz-BV for emacs-pretest-bug@gnu.org; Mon, 23 Oct 2006 14:07:28 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Gc4CB-00058Y-Vn for emacs-pretest-bug@gnu.org; Mon, 23 Oct 2006 20:06:43 +0200 Original-Received: from 207.167.42.206 ([207.167.42.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 Oct 2006 20:06:43 +0200 Original-Received: from ihs_4664 by 207.167.42.206 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 Oct 2006 20:06:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-pretest-bug@gnu.org Original-Lines: 44 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.206 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) In-Reply-To: X-BeenThere: emacs-pretest-bug@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for CVS Emacs." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Errors-To: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.pretest.bugs:14749 gmane.emacs.devel:61053 Archived-At: Richard Stallman wrote: > > I think to make that work, dired-revert needs the same fix as > > dired-mode, namely: > > > (set (make-local-variable 'file-name-coding-system) > > (or coding-system-for-read file-name-coding-system)) > > Kevin, I don't understand that suggestion. I don't see anything > like that code in dired-mode. > > Are you proposing a change to dired-mode AND a change to dired-revert? Yes, that is what I am proposing. Or alternatively, a single change to dired-readin. > Could use diff to show the change you are suggesting? *** lisp/dired.el~ 2006-10-23 11:58:19.628889700 -0600 --- lisp/dired.el 2006-10-23 12:02:15.497851300 -0600 *************** *** 1042,1047 **** --- 1042,1049 ---- ;; treat top level dir extra (it may contain wildcards) (dired-uncache (if (consp dired-directory) (car dired-directory) dired-directory)) + (set (make-local-variable 'file-name-coding-system) + (or coding-system-for-read file-name-coding-system)) (dired-readin) (let ((dired-after-readin-hook nil)) ;; don't run that hook for each subdir... *************** *** 1627,1632 **** --- 1629,1636 ---- '(dired-font-lock-keywords t nil nil beginning-of-line)) (set (make-local-variable 'desktop-save-buffer) 'dired-desktop-buffer-misc-data) + (set (make-local-variable 'file-name-coding-system) + (or coding-system-for-read file-name-coding-system)) (setq dired-switches-alist nil) (dired-sort-other dired-actual-switches t) (when (featurep 'dnd) -- Kevin