GNU Emacs no longer honours top and left parameters to make-frame

GNU Emacs no longer honours top and left parameters to make-frame

[Krishnakumar B]

Hi,

The following code that I had in my .emacs no longer works, i.e., the top
and left values are not honoured by Emacs, and Emacs places my frames at
arbitrary locations on startup.

/----
| ;; Sizes for the various frames
| 
| (if window-system
|     (let (top left height)
|       (if (= (display-pixel-width) 1600)
|           (setq top     12
|                 left    753
|                 height  69)
|         (setq top       14
|               left      637
|               height    56))
|       (setq default-frame-alist `((width . 80)
|                                   (left   . ,left)
|                                   (top    . ,top)
|                                   (height . ,height)
|                                   (tool-bar-lines . 0)))
|       (setq initial-frame-alist default-frame-alist))
|   (menu-bar-mode 0))
| 
| 
| ;; ;; Create the smaller frame on the left side of the screen.
| 
| (if window-system
|     (let (top left height)
|       (if (= (display-pixel-width) 1600)
|           (setq top     27
|                 left    0
|                 height  68)
|         (setq top       48
|               left      0
|               height    54))
|       (make-frame `((width  . 80)
|                     (left   . ,left)
|                     (top    . ,top)
|                     (height . ,height)
|                     (tool-bar-lines . 0))))
|   (menu-bar-mode 0))
\----

I also noticed that once Emacs is initialized, if I try to execute the
second function, i.e., the smaller frame one, it places it over my right
frame.  Are top and left no longer supported?
 
I am using GNU Emacs compiled from CVS with version reported as:

In GNU Emacs 22.0.50.1 (i386-msvc-nt5.2.3790)
 of 2006-09-19 on EQUUS
X server distributor `Microsoft Corp.', version 5.2.3790
configured using `configure --with-msvc (13.10)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  display-time-mode: t
  recentf-mode: t
  icomplete-mode: t
  auto-image-file-mode: t
  delete-selection-mode: t
  partial-completion-mode: t
  shell-dirtrack-mode: t
  encoded-kbd-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Any pointers on how to get back the old behavior which used to place the
frames in a non-overlapping fashion is much appreciated.

-kitty.
      
-- 
Krishnakumar B <kitty at dre dot vanderbilt dot edu>
Institute for Software Integrated Systems, Dept. of EECS, Vanderbilt University

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

* Krishnakumar B. (2006-09-20) writes:

> The following code that I had in my .emacs no longer works, i.e., the top
> and left values are not honoured by Emacs, and Emacs places my frames at
> arbitrary locations on startup.
[...]
> |       (make-frame `((width  . 80)
> |                     (left   . ,left)
> |                     (top    . ,top)
> |                     (height . ,height)
> |                     (tool-bar-lines . 0))))

I'll have a look ...

-- 
Ralf

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

* Ralf Angeli (2006-09-20) writes:

> * Krishnakumar B. (2006-09-20) writes:
>
>> The following code that I had in my .emacs no longer works, i.e., the top
>> and left values are not honoured by Emacs, and Emacs places my frames at
>> arbitrary locations on startup.
> [...]
>> |       (make-frame `((width  . 80)
>> |                     (left   . ,left)
>> |                     (top    . ,top)
>> |                     (height . ,height)
>> |                     (tool-bar-lines . 0))))
>
> I'll have a look ...

Hm, w32_createwindow would have to know these values.  But the only
object explicitely passed to the function is the frame.  The frame
struct contains top_pos and left_pos but we don't know when we can use
them.

Does anybody know if there is another variable where the (top and
left) values given to `make-frame' are stored and which could be used
by w32_createwindow to look them up?

-- 
Ralf

Re: GNU Emacs no longer honours top and left parameters to make-frame

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 21 Sep 2006 22:30:47 +0200, Ralf Angeli <angeli@caeruleus.net> said:

> Does anybody know if there is another variable where the (top and
> left) values given to `make-frame' are stored and which could be
> used by w32_createwindow to look them up?

f->top_pos and f->left_pos, which are set in x_figure_window_size.

As I said in http://lists.gnu.org/archive/html/emacs-devel/2006-07/msg01367.html,
whether we should honor these variables has something to do with size
hints.  Maybe you can simply check f->size_hint_flags, which is also
set in x_figure_window_size, against USPosition and PPosition to
decide that.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Kim F. Storm]

Ralf Angeli <angeli@caeruleus.net> writes:

> * Ralf Angeli (2006-09-20) writes:
>
>> * Krishnakumar B. (2006-09-20) writes:
>>
>>> The following code that I had in my .emacs no longer works, i.e., the top
>>> and left values are not honoured by Emacs, and Emacs places my frames at
>>> arbitrary locations on startup.
>> [...]
>>> |       (make-frame `((width  . 80)
>>> |                     (left   . ,left)
>>> |                     (top    . ,top)
>>> |                     (height . ,height)
>>> |                     (tool-bar-lines . 0))))
>>
>> I'll have a look ...
>
> Hm, w32_createwindow would have to know these values.  But the only
> object explicitely passed to the function is the frame.  The frame
> struct contains top_pos and left_pos but we don't know when we can use
> them.
>
> Does anybody know if there is another variable where the (top and
> left) values given to `make-frame' are stored and which could be used
> by w32_createwindow to look them up?

Maybe the answer to the following questions would give you some clues...

How did it work before?
What change broke it?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Eli Zaretskii]

> From: Ralf Angeli <angeli@caeruleus.net>
> Date: Thu, 21 Sep 2006 22:30:47 +0200
> 
> * Ralf Angeli (2006-09-20) writes:
> 
> > * Krishnakumar B. (2006-09-20) writes:
> >
> >> The following code that I had in my .emacs no longer works, i.e., the top
> >> and left values are not honoured by Emacs, and Emacs places my frames at
> >> arbitrary locations on startup.
> > [...]
> >> |       (make-frame `((width  . 80)
> >> |                     (left   . ,left)
> >> |                     (top    . ,top)
> >> |                     (height . ,height)
> >> |                     (tool-bar-lines . 0))))
> >
> > I'll have a look ...
> 
> Hm, w32_createwindow would have to know these values.

What values did you refer to here?

> But the only object explicitely passed to the function is the frame.
> The frame struct contains top_pos and left_pos but we don't know
> when we can use them.

Can you describe the sequence of function calls that leads from
make-frame to w32_createwindow, and what happens with the params-alist
passed to make-frame along the way?  Maybe then someone will have some
ideas.

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

* Eli Zaretskii (2006-09-22) writes:

>> From: Ralf Angeli <angeli@caeruleus.net>
>> Date: Thu, 21 Sep 2006 22:30:47 +0200
>> 
>> * Ralf Angeli (2006-09-20) writes:
>> 
>> > * Krishnakumar B. (2006-09-20) writes:
>> >
>> >> The following code that I had in my .emacs no longer works, i.e., the top
>> >> and left values are not honoured by Emacs, and Emacs places my frames at
>> >> arbitrary locations on startup.
>> > [...]
>> >> |       (make-frame `((width  . 80)
>> >> |                     (left   . ,left)
>> >> |                     (top    . ,top)
>> >> |                     (height . ,height)
>> >> |                     (tool-bar-lines . 0))))
>> >
>> > I'll have a look ...
>> 
>> Hm, w32_createwindow would have to know these values.
>
> What values did you refer to here?

The values for the top and left positions.

>> But the only object explicitely passed to the function is the frame.
>> The frame struct contains top_pos and left_pos but we don't know
>> when we can use them.
>
> Can you describe the sequence of function calls that leads from
> make-frame to w32_createwindow,

frame.el:make-frame --> faces.el:x-create-frame-with-faces -->
w32fns.c:x-create-frame (last function to get parameters) -->
frame.c:make_frame --> w32fns.c:w32_window -->
w32fns.c:my_create_window (--> w32fns.c:w32_msg_pump) -->
w32fns.c:w32_createwindow

> and what happens with the params-alist
> passed to make-frame along the way?  Maybe then someone will have some
> ideas.

x-create-frame is the last function to get the parameters and they are
processed by the function.  The parameters for top and left positions
are not handled (yet), however.

Perhaps setting f->left_pos and f->top_pos and in addition a flag that
the values can be used would do the trick.  If I understand Mitsuharu
correctly, size_hints->flags could be used for this.

-- 
Ralf

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

* Kim F. Storm (2006-09-22) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> * Ralf Angeli (2006-09-20) writes:
>>
>>> * Krishnakumar B. (2006-09-20) writes:
>>>
>>>> The following code that I had in my .emacs no longer works, i.e., the top
>>>> and left values are not honoured by Emacs, and Emacs places my frames at
>>>> arbitrary locations on startup.
[...]
>> Hm, w32_createwindow would have to know these values.  But the only
>> object explicitely passed to the function is the frame.  The frame
>> struct contains top_pos and left_pos but we don't know when we can use
>> them.
>>
>> Does anybody know if there is another variable where the (top and
>> left) values given to `make-frame' are stored and which could be used
>> by w32_createwindow to look them up?
>
> Maybe the answer to the following questions would give you some clues...
>
> How did it work before?
> What change broke it?

w32_createwindow originally used f->top_pos and f->left_pos for the
top and left positions of the frame.  It now uses advises Windows'
window manager to position the frame itself unless there are values
for top or left positions set in initial-frame-alist or
default-frame-alist.  Because top and left positions passed to
make-frame are not added to these variables they are currently not
used.  Unfortunately I forgot this case when implementing the changes
in w32_createwindow.  Mitsuharu's suggestion could be a way to remedy
the problem IIUC.

-- 
Ralf

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

* YAMAMOTO Mitsuharu (2006-09-22) writes:

>>>>>> On Thu, 21 Sep 2006 22:30:47 +0200, Ralf Angeli <angeli@caeruleus.net> said:
>
>> Does anybody know if there is another variable where the (top and
>> left) values given to `make-frame' are stored and which could be
>> used by w32_createwindow to look them up?
>
> f->top_pos and f->left_pos, which are set in x_figure_window_size.
>
> As I said in http://lists.gnu.org/archive/html/emacs-devel/2006-07/msg01367.html,
> whether we should honor these variables has something to do with size
> hints.  Maybe you can simply check f->size_hint_flags, which is also
> set in x_figure_window_size, against USPosition and PPosition to
> decide that.

Thanks for the hint.  The attached patch checks the value of
f->size_hint_flags in order to decide if the f->left_pos and
f->top_pos values should be used.

With the patch applied stuff like (make-frame '((top . 10))) works
now.  The only drawback is that the value of f->size_hint_flags does
not allow to determine if both top and left positions or only one is
set.  That means in case of the make-frame call above, for example,
the frame is horizontally positioned at the left edge of the desktop,
as the default value for f->left_pos is 0.

Here is a change log entry:

2006-10-07  Ralf Angeli  <angeli@caeruleus.net>

	* w32fns.c (w32_createwindow): Honour left and top positions if
	supplied explicitely.

-- 
Ralf

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: w32fns.patch --]
[-- Type: text/x-patch, Size: 707 bytes --]

Index: w32fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32fns.c,v
retrieving revision 1.277
diff -u -r1.277 w32fns.c
--- w32fns.c	24 Sep 2006 09:04:56 -0000	1.277
+++ w32fns.c	7 Oct 2006 19:15:59 -0000
@@ -2108,7 +2108,12 @@
 	}
     }
 
-  if (EQ (left, Qunbound) && EQ (top, Qunbound))
+  if (f->size_hint_flags & USPosition || f->size_hint_flags & PPosition)
+    {
+      XSETINT (left, f->left_pos);
+      XSETINT (top, f->top_pos);
+    }
+  else if (EQ (left, Qunbound) && EQ (top, Qunbound))
     {
       /* When called with RES_TYPE_NUMBER, w32_get_arg will return zero
 	 for anything that is not a number and is not Qunbound.  */

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: GNU Emacs no longer honours top and left parameters to make-frame

[Jason Rumney]

Ralf Angeli wrote:
> The attached patch checks the value of f->size_hint_flags
Thanks, I've committed it.

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[mituharu]

> Thanks for the hint.  The attached patch checks the value of
> f->size_hint_flags in order to decide if the f->left_pos and
> f->top_pos values should be used.

Still need to anything special about initial-frame-alist in
w32_createwindow?  There're no such codes in other platforms.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[Ralf Angeli]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

* mituharu@math.s.chiba-u.ac.jp (2006-10-08) writes:

>> Thanks for the hint.  The attached patch checks the value of
>> f->size_hint_flags in order to decide if the f->left_pos and
>> f->top_pos values should be used.
>
> Still need to anything special about initial-frame-alist in
> w32_createwindow?  There're no such codes in other platforms.

No, it's unnecessary now.  I attached a patch.  Here is the
accompanying change log entry:

2006-10-08  Ralf Angeli  <angeli@caeruleus.net>

	* w32fns.c (w32_createwindow): Remove code for handling -geometry
	command line option and `initial-frame-alist' which is superfluous
	after the last change to `w32_createwindow'.

-- 
Ralf

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: w32fns.patch --]
[-- Type: text/x-patch, Size: 1001 bytes --]

Index: w32fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32fns.c,v
retrieving revision 1.277
diff -u -r1.277 w32fns.c
--- w32fns.c	24 Sep 2006 09:04:56 -0000	1.277
+++ w32fns.c	8 Oct 2006 07:08:20 -0000
@@ -2080,32 +2080,7 @@
 
   if (!hprevinst)
     {
-      Lisp_Object ifa;
-
       w32_init_class (hinst);
-
-      /* Handle the -geometry command line option and the geometry
-	 settings in the registry.  They are decoded and put into
-	 initial-frame-alist by w32-win.el:x-handle-geometry.  */
-      ifa = Fsymbol_value (intern ("initial-frame-alist"));
-      if (CONSP (ifa))
-	{
-	  Lisp_Object lt = Fassq (Qleft, ifa);
-	  Lisp_Object tp = Fassq (Qtop,  ifa);
-
-	  if (!NILP (lt))
-	    {
-	      lt = XCDR (lt);
-	      if (INTEGERP (lt))
-		left = lt;
-	    }
-	  if (!NILP (tp))
-	    {
-	      tp = XCDR (tp);
-	      if (INTEGERP (tp))
-		top = tp;
-	    }
-	}
     }
 
   if (EQ (left, Qunbound) && EQ (top, Qunbound))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[Ralf Angeli]

* Ralf Angeli (2006-10-08) writes:

> * mituharu@math.s.chiba-u.ac.jp (2006-10-08) writes:
>
>>> Thanks for the hint.  The attached patch checks the value of
>>> f->size_hint_flags in order to decide if the f->left_pos and
>>> f->top_pos values should be used.
>>
>> Still need to anything special about initial-frame-alist in
>> w32_createwindow?  There're no such codes in other platforms.
>
> No, it's unnecessary now.  I attached a patch.  Here is the
> accompanying change log entry:
>
> 2006-10-08  Ralf Angeli  <angeli@caeruleus.net>
>
> 	* w32fns.c (w32_createwindow): Remove code for handling -geometry
> 	command line option and `initial-frame-alist' which is superfluous
> 	after the last change to `w32_createwindow'.

This patch hasn't been applied yet.  Could somebody please have a
look?  It's quite some code which could be spared.

-- 
Ralf

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[Eli Zaretskii]

> From: Ralf Angeli <angeli@caeruleus.net>
> Date: Sun, 29 Oct 2006 00:38:50 +0200
> >
> > 2006-10-08  Ralf Angeli  <angeli@caeruleus.net>
> >
> > 	* w32fns.c (w32_createwindow): Remove code for handling -geometry
> > 	command line option and `initial-frame-alist' which is superfluous
> > 	after the last change to `w32_createwindow'.
> 
> This patch hasn't been applied yet.  Could somebody please have a
> look?  It's quite some code which could be spared.

Please resend the patch.

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[Ralf Angeli]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

* Eli Zaretskii (2006-10-29) writes:

>> From: Ralf Angeli <angeli@caeruleus.net>
>> Date: Sun, 29 Oct 2006 00:38:50 +0200
>> >
>> > 2006-10-08  Ralf Angeli  <angeli@caeruleus.net>
>> >
>> > 	* w32fns.c (w32_createwindow): Remove code for handling -geometry
>> > 	command line option and `initial-frame-alist' which is superfluous
>> > 	after the last change to `w32_createwindow'.
>> 
>> This patch hasn't been applied yet.  Could somebody please have a
>> look?  It's quite some code which could be spared.
>
> Please resend the patch.

Attached.

-- 
Ralf

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: w32fns.c.patch --]
[-- Type: text/x-patch, Size: 1025 bytes --]

Index: w32fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32fns.c,v
retrieving revision 1.278
diff -u -r1.278 w32fns.c
--- w32fns.c	7 Oct 2006 20:09:09 -0000	1.278
+++ w32fns.c	29 Oct 2006 11:08:46 -0000
@@ -2080,32 +2080,7 @@
 
   if (!hprevinst)
     {
-      Lisp_Object ifa;
-
       w32_init_class (hinst);
-
-      /* Handle the -geometry command line option and the geometry
-	 settings in the registry.  They are decoded and put into
-	 initial-frame-alist by w32-win.el:x-handle-geometry.  */
-      ifa = Fsymbol_value (intern ("initial-frame-alist"));
-      if (CONSP (ifa))
-	{
-	  Lisp_Object lt = Fassq (Qleft, ifa);
-	  Lisp_Object tp = Fassq (Qtop,  ifa);
-
-	  if (!NILP (lt))
-	    {
-	      lt = XCDR (lt);
-	      if (INTEGERP (lt))
-		left = lt;
-	    }
-	  if (!NILP (tp))
-	    {
-	      tp = XCDR (tp);
-	      if (INTEGERP (tp))
-		top = tp;
-	    }
-	}
     }
 
   if (f->size_hint_flags & USPosition || f->size_hint_flags & PPosition)

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: GNU Emacs no longer honours top and left parameterstomake-frame

[Eli Zaretskii]

> From: Ralf Angeli <angeli@caeruleus.net>
> Date: Sun, 29 Oct 2006 12:10:31 +0100
> 
> * Eli Zaretskii (2006-10-29) writes:
> 
> >> From: Ralf Angeli <angeli@caeruleus.net>
> >> Date: Sun, 29 Oct 2006 00:38:50 +0200
> >> >
> >> > 2006-10-08  Ralf Angeli  <angeli@caeruleus.net>
> >> >
> >> > 	* w32fns.c (w32_createwindow): Remove code for handling -geometry
> >> > 	command line option and `initial-frame-alist' which is superfluous
> >> > 	after the last change to `w32_createwindow'.
> >> 
> >> This patch hasn't been applied yet.  Could somebody please have a
> >> look?  It's quite some code which could be spared.
> >
> > Please resend the patch.
> 
> Attached.

Thanks, I installed it now.