From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Date: Tue, 9 Jun 2020 03:44:47 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="77951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Simon Lang , 41766@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 09 02:45:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiSOK-000KBV-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 02:45:24 +0200 Original-Received: from localhost ([::1]:51740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiSOJ-0000bB-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jun 2020 20:45:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiSNy-0000ay-Ok for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 20:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiSNy-0000rb-EO for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 20:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiSNy-0002HY-Ae for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 20:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jun 2020 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41766 X-GNU-PR-Package: emacs Original-Received: via spool by 41766-submit@debbugs.gnu.org id=B41766.15916634968744 (code B ref 41766); Tue, 09 Jun 2020 00:45:02 +0000 Original-Received: (at 41766) by debbugs.gnu.org; 9 Jun 2020 00:44:56 +0000 Original-Received: from localhost ([127.0.0.1]:58309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiSNs-0002Gw-Cm for submit@debbugs.gnu.org; Mon, 08 Jun 2020 20:44:56 -0400 Original-Received: from mail-wr1-f65.google.com ([209.85.221.65]:33917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiSNr-0002Gj-CB for 41766@debbugs.gnu.org; Mon, 08 Jun 2020 20:44:55 -0400 Original-Received: by mail-wr1-f65.google.com with SMTP id r7so19408420wro.1 for <41766@debbugs.gnu.org>; Mon, 08 Jun 2020 17:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ofdz4e3FpRM/K9WowU8m4MjVgcPHRxCF/ibgzC/AG+k=; b=HvEJzWWIL+DQGINr+E21ArsLojdLFKsePfE0tucek+Qq04yBmGOwBpNF8XIjZr5fQA 4OIUEJF39ubO+MI1G4xMAcZrqNovYlImc4tB6tJ9M3JKYt/HHASkjFcpyWDpZsllFlRD DwqFuCx8ki9flKQoov9cGchfHo9V9BrmFKOb6HC5O/BVcbhfZ9mrSQ9eXWvYWxpEsJZA 8Luw88WbR5NLEz1ey+pIulwXwcAgvPFOflTPe3nZ+Q94NdUHdxvflziFL8cFjQk3Y9W6 9udKA7OZxu3RUk5D0FIgUyFDlKtWz04Zpapg1ebeN2osmezUCNxGZjIbhlKmNTCahmfY f02A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ofdz4e3FpRM/K9WowU8m4MjVgcPHRxCF/ibgzC/AG+k=; b=LynlBW+bGYe19HYwtdFrp7KtfJSFJdz3eWLFl0aAcmDMEfur1je2ZOyuU2fiwynrbz EkZq+gB2FTtNy7VEhl0Nft64GKCgyKM0p3zvFUu4y7jAg+m3VEhOnJU9rzSi1xNf/opi s6WnnVay/sP9Ex1npJyoHctaJmmfwT+EXJgbF++gIbMwQlmtmd1DJzgaaEbP1d5dbNQt FzwOKHNyZWo52FJBNGo+1DQcUuuGYKFuGbp+6kBqzkK0SeK/rqzOfmMUWX9QB+9zz1IL Y6scJACuxTCE8kiaDMF9K8mJFoCNIFMDOIZqTdOHG8OrGWAGKdixdiyKzCX/4AmqGYAW ziWg== X-Gm-Message-State: AOAM530hUiWVjGGJ41IeS90SyB3itgfmW3HVqVsqhIdE/yHLULdv7SOo WVhNBLpWxEMqFGqCYLx4axGbUOj7 X-Google-Smtp-Source: ABdhPJyLYawHRYcXJp5loPPXFE2yAUPB5HIOkvCY1IywAYzDnulg/q/YYSxhxlFQQMGTw8ZPD6X76Q== X-Received: by 2002:a5d:4c81:: with SMTP id z1mr1525559wrs.371.1591663489001; Mon, 08 Jun 2020 17:44:49 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b19sm1616754wmj.0.2020.06.08.17.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 17:44:48 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181759 Archived-At: On 08.06.2020 23:25, Simon Lang wrote: > For example: > > change grep command to > > "rg -n -H -S --no-heading --color always -e" I wonder if we can use a similar customization more generally. For instance, in my testing Grep searches the full Emacs checkout in ~230ms, whereas RipGrep does that in ~40ms. The difference is perceptible. The obvious idea is to use grep-template, but we're passing -s and -E to it. rg would interpret these options differently. Here's a perftest patch if someone was personally curious about the difference: diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 5b5fb4bc47..2c6ed4da7d 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1262,7 +1262,7 @@ xref-matches-in-files (dir (file-name-directory (car files))) (remote-id (file-remote-p dir)) ;; 'git ls-files' can output broken symlinks. - (command (format "xargs -0 grep %s -snHE -e %s" + (command (format "xargs -0 rg %s -nH -e %s" (if (and case-fold-search (isearch-no-upper-case-p regexp t)) "-i" @@ -1275,6 +1275,7 @@ xref-matches-in-files #'tramp-file-local-name #'file-local-name) files))) + (setq tt (time-to-seconds)) (with-current-buffer output (erase-buffer) (with-temp-buffer @@ -1289,6 +1290,7 @@ xref-matches-in-files shell-command-switch command))) (goto-char (point-min)) + (message "%s" (- (time-to-seconds) tt)) (when (and (/= (point-min) (point-max)) (not (looking-at grep-re)) ;; TODO: Show these matches as well somehow?