From: Dmitry Gutov <dmitry@gutov.dev>
To: Urban Engberg <urban@engbergs.dk>, 59232@debbugs.gnu.org
Subject: bug#59232:
Date: Wed, 20 Dec 2023 17:50:42 +0200 [thread overview]
Message-ID: <efae523f-4bbb-c171-9e8a-0b118bcab8eb@gutov.dev> (raw)
In-Reply-To: <CALqErGRvb=zLz+Uhmj3wyO+Yu8dsR-LYL5i=v24WkY3LPb=rfw@mail.gmail.com>
On 20/12/2023 14:41, Urban Engberg wrote:
> I have the same problem in Emacs 29.1. I believe it is due to the svn
> backend being called asynchronously, with large file annotations thereby
> being cut off before they are done.
>
> The following change solves the problem for me:
>
> --- /home/ue/tmp/vc-svn.el.orig 2023-12-20 13:36:06.427678047 +0100
> +++ /home/ue/tmp/vc-svn.el 2023-12-20 13:33:43.881904459 +0100
> @@ -770,7 +770,7 @@
> ;; Support for `svn annotate'
>
> (defun vc-svn-annotate-command (file buf &optional rev)
> - (apply #'vc-svn-command buf 'async file "annotate"
> + (apply #'vc-svn-command buf nil file "annotate"
> (append (vc-switches 'svn 'annotate)
> (if rev (list (concat "-r" rev))))))
This kind of change is bound to make worse the apparent performance of
vc-annotate with SVN. So it would be great to understand the issue of
the problem first.
Is that a network error? Do you see the same problem with your corporate
repo when calling the respective command in the command line?
Worst case, we could create a user option, to only be used in affected
projects.
next prev parent reply other threads:[~2023-12-20 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 0:14 bug#59232: 27.2; vc-annotate on SVN does not process all lines Pierre Rouleau
2022-11-13 2:29 ` Dmitry Gutov
2022-11-13 14:42 ` Pierre Rouleau
2022-11-13 2:30 ` Dmitry Gutov
2022-11-13 14:59 ` Pierre Rouleau
2022-11-13 6:36 ` Eli Zaretskii
2022-11-13 14:51 ` Pierre Rouleau
2022-11-13 15:11 ` Pierre Rouleau
2022-11-13 16:10 ` Andreas Schwab
2022-11-13 16:40 ` Eli Zaretskii
2022-11-13 18:05 ` Pierre Rouleau
2022-11-13 23:54 ` Stephen Berman
2022-11-14 3:48 ` Pierre Rouleau
2022-11-13 8:12 ` Andreas Schwab
2022-11-13 14:55 ` Pierre Rouleau
2023-12-20 12:41 ` bug#59232: Urban Engberg
2023-12-20 15:50 ` Dmitry Gutov [this message]
2023-12-20 17:38 ` bug#59232: Urban Engberg
2023-12-20 18:35 ` bug#59232: Dmitry Gutov
2023-12-20 21:36 ` bug#59232: Urban Engberg
2023-12-20 22:03 ` bug#59232: Dmitry Gutov
2023-12-20 22:50 ` bug#59232: Urban Engberg
2023-12-21 0:12 ` bug#59232: Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efae523f-4bbb-c171-9e8a-0b118bcab8eb@gutov.dev \
--to=dmitry@gutov.dev \
--cc=59232@debbugs.gnu.org \
--cc=urban@engbergs.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.