From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: open-{gnutls,network}-stream backwards compatibility Date: Wed, 02 Jan 2019 19:18:26 +0000 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: References: <831s5v3s9w.fsf@gnu.org> <83y3823oap.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1546456636 3466 195.159.176.226 (2 Jan 2019 19:17:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2019 19:17:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 02 20:17:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gem0r-0000ls-F1 for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2019 20:17:09 +0100 Original-Received: from localhost ([127.0.0.1]:46967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gem2y-0007ad-AK for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2019 14:19:20 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gem2E-0007aY-ND for emacs-devel@gnu.org; Wed, 02 Jan 2019 14:18:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gem2A-00037T-T8 for emacs-devel@gnu.org; Wed, 02 Jan 2019 14:18:34 -0500 Original-Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:34432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gem28-00035R-VI for emacs-devel@gnu.org; Wed, 02 Jan 2019 14:18:30 -0500 Original-Received: by mail-qt1-x82b.google.com with SMTP id r14so34644091qtp.1 for ; Wed, 02 Jan 2019 11:18:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=cze017tRUciy/w7GeLhRlzznI/MxYQF2E9aCoWDc7WE=; b=quXjksx+CtP0bZ08qT5IsFY4ifk2M5S6CJy89MdxIXtPE7c5tj0fprFtIdI6OmC+fl vzPDcubisx0GJnsIve0g/eoR7xmUgy6vy/ftu2rK/Kwloi55KHdntkDd+LNomHhtikwH VDe3LP5kgHa1GtzKCpZVLqR3yQtDzwOa6t6I4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=cze017tRUciy/w7GeLhRlzznI/MxYQF2E9aCoWDc7WE=; b=J8EJ1pBX2sPJBlSNgoBNiFHQCb/vnPj6mszPaOms2TAyR52K8sOjHlDTGH8TPUu00a AcDF+Kq3upb1aKwfuFv+OBGTeT+vg5sPg2WnH9ENGuypPkf6fldoEAJ+hOQtAK5TeFJ2 2i6nHhC2xdC6rd6YE7YYGyYbrhmBAFh73qVYoyuvkYL+JUbQ8DVd0MX4fgEmJGk1/nxN W9foojFhStkl48qR9rkwHTvjnek8MyBTWPc5Z1EtIDFEFGPOyabfh76KTypqU4endg8V KAbX0Nanwn6tdQVpeYdR5vk5bi3cn3dwtRfiDorXoqZ+WaqHFFIpiObvfxZjoCAQrYFP WSkA== X-Gm-Message-State: AA+aEWaeX85m0T3DoZE0E4tuPoMl2OuQqXsiIVhLmciseaZZVo5O1bIP L4+XWNRYQfiNVM84AIvn40xaapki53k= X-Google-Smtp-Source: AFSGD/Wres9xMBT/1M8H+odT3XR8JCs6YhC7YN360tWRG/xlXEyB8QhbalF2w90WNszj62IhYxeKxg== X-Received: by 2002:ac8:7416:: with SMTP id p22mr42807103qtq.318.1546456707972; Wed, 02 Jan 2019 11:18:27 -0800 (PST) Original-Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id 186sm3046391qke.10.2019.01.02.11.18.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Jan 2019 11:18:27 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never In-Reply-To: <83y3823oap.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Jan 2019 20:30:22 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232100 Archived-At: On Wed, 02 Jan 2019 20:30:22 +0200 Eli Zaretskii wrote: >> From: Ted Zlatanov >> I like that approach as well, noting also that the `open-gnutls-stream' docs say >> >> This is a very simple wrapper around `gnutls-negotiate' >> >> which in turn takes a plist. So maybe the callers should just call >> `gnutls-negotiate', and `open-gnutls-stream' should be deprecated >> because it has failed to be a simple wrapper :) EZ> If we can make the change backward-compatible, there's no reason to EZ> deprecate it. As the author, I think there is: the function is used in one place and doesn't fit the use cases well. All the existing usage goes through `open-network-stream'. So it's a layer of indirection with one user, that removes API features in a way that's hard to work around. I think it's better to remove the source of the problem than to patch it. Ted