From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Yikai Zhao" Newsgroups: gmane.emacs.devel Subject: [PATCH] memory-report: support calculating size for structures Date: Sun, 29 Aug 2021 22:40:48 +0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=cf93288d7ba841efa49af747467c62c9 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5999"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.5.0-alpha0-1125-g685cec594c-fm-20210825.001-g685cec59 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 29 16:47:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKM6B-0001F7-Qs for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Aug 2021 16:47:52 +0200 Original-Received: from localhost ([::1]:34076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKM69-0001vv-VO for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Aug 2021 10:47:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKLzo-0008Tz-44 for emacs-devel@gnu.org; Sun, 29 Aug 2021 10:41:16 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKLzm-0002cb-4i for emacs-devel@gnu.org; Sun, 29 Aug 2021 10:41:15 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 21B9B5C00CE for ; Sun, 29 Aug 2021 10:41:10 -0400 (EDT) Original-Received: from imap7 ([10.202.2.57]) by compute3.internal (MEProxy); Sun, 29 Aug 2021 10:41:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; h= mime-version:message-id:date:from:to:subject:content-type; s= fm1; bh=TSfKyjO6qRvAocsEk9wry4xq+K9Slj1LdsY7ywemo+I=; b=SQSo7oJX DIUJN6A+dgdJMgmfxPjDGet66NIyndpr4uuX7v50ltTm4hq4B2lVGdBfzkNMGEfD ENcQELulc+nsGcCaE847hdRyF8g/3d/NS6wmiKVqsUovRUt1pBRDEgo6Ht4MXLKL PwcnQBz3aNas/UKQQutcM90lPDVCcTn3Cn5Iyx7DBMU8w3opVPZvW+e6xcE3sSFf bLCho4OWoWFi93P+Zh2rg22TwgZev3nYLJXh2si7fRJhFbuvzXuLok+fUHzgaklU Zwe9UAACDvB33R/LUP7JQPkbGo5mz65jD0CQsz9FwD/ReW0CCCCY4V6tZKil1N6x RD3Hy2TiNOelSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=TSfKyjO6qRvAocsEk9wry4xq+K9Sl j1LdsY7ywemo+I=; b=OgWOlZwznRGBXZK4/9qqKqLz7F8IvIuFVNu+TU+OfheOj uWvomgq3f2RN/HgAOf4zPrUIJB9a5fAySHAO2yxsbdrpJ716KB4yVxmZ5wfG2WyR TUubfQ5bCFsoOSjx5+sblepxKmIVksR9lD1k9Q0ky+0KnOQTUMf1LHfamdRz6GcI RfWYsizIYTYfsKZah4PXtn64EhLq0BAtUOw+XiuFk62kwR/CDccro4BDMN8FUmNK R4lg3zyRZwxdD5++xSkBVEJ5bGcKk8qX9gqtCnuutsLZSjfo1HATcakerzSqs43P zYMot9YVrPpFbfIH1O6OSTTC5fRGDBsqCG5Tfd84A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddujedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsehmtderre erredtnecuhfhrohhmpedfjghikhgrihcukghhrghofdcuoeihihhkrghiseiiudhkrdgu vghvqeenucggtffrrghtthgvrhhnpeekudevgefgkeelhfdvgefhgfeiueffhfduiefggf egvedttdefueejveeukefhleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpeihihhkrghiseiiudhkrdguvghv X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id BC299360165; Sun, 29 Aug 2021 10:41:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Received-SPF: pass client-ip=66.111.4.28; envelope-from=yikai@z1k.dev; helo=out4-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM14=0.999, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 29 Aug 2021 10:46:35 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273412 Archived-At: --cf93288d7ba841efa49af747467c62c9 Content-Type: text/plain Hi, Here's another patch on memory-report package which fixes the object size calculation for structures (cl-defstruct types). Before this patch, memory-report--object-size will report empty size for structure objects, which results in incorrect report about "Largest Variables" in memory-report result. Regarding the copyright assignment, I'm currently in the progress of signing it. But maybe this patch is small enough to apply without it? Yikai --cf93288d7ba841efa49af747467c62c9 Content-Disposition: attachment;filename="0001-memory-report-support-calculating-size-for-structure.patch" Content-Type: text/x-patch; name="0001-memory-report-support-calculating-size-for-structure.patch" Content-Transfer-Encoding: BASE64 RnJvbSA2YTg1MWUwODlkMGJkOWVmNjFkOTIwOWM1ZDNlYjM5MzJjN2E3YTZjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBZaWthaSBaaGFvIDx5aWthaUB6MWsuZGV2PgpEYXRl OiBTdW4sIDI5IEF1ZyAyMDIxIDIxOjQ3OjEyICswODAwClN1YmplY3Q6IFtQQVRDSF0gbWVt b3J5LXJlcG9ydDogc3VwcG9ydCBjYWxjdWxhdGluZyBzaXplIGZvciBzdHJ1Y3R1cmVzCgot LS0KIGxpc3AvZW1hY3MtbGlzcC9tZW1vcnktcmVwb3J0LmVsICAgICAgICAgICAgfCAxNiAr KysrKysrKysrKysrKystCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9tZW1vcnktcmVwb3J0LXRl c3RzLmVsIHwgIDggKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9tZW1vcnkt cmVwb3J0LmVsIGIvbGlzcC9lbWFjcy1saXNwL21lbW9yeS1yZXBvcnQuZWwKaW5kZXggYWVl MmEwMDc5Yy4uY2ZhNzAxMGFmNCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL21lbW9y eS1yZXBvcnQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL21lbW9yeS1yZXBvcnQuZWwKQEAg LTI5LDcgKzI5LDggQEAKIAogKHJlcXVpcmUgJ3NlcSkKIChyZXF1aXJlICdzdWJyLXgpCi0o ZXZhbC13aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ2NsLWxpYikpCisocmVxdWlyZSAnY2wtbGli KQorKHJlcXVpcmUgJ2NsLW1hY3MpCiAKIChkZWZ2YXIgbWVtb3J5LXJlcG9ydC0tdHlwZS1z aXplIChtYWtlLWhhc2gtdGFibGUpKQogCkBAIC0yNDMsNiArMjQ0LDE5IEBAIG1lbW9yeS1y ZXBvcnQtLW9iamVjdC1zaXplLTEKICAgICAgdmFsdWUpCiAgICAgdG90YWwpKQogCis7OyBm b3IgYWxsIGNsLWRlZnN0cnVjdCB0eXBlcworKGNsLWRlZm1ldGhvZCBtZW1vcnktcmVwb3J0 LS1vYmplY3Qtc2l6ZS0xIChjb3VudGVkICh2YWx1ZSBjbC1zdHJ1Y3R1cmUtb2JqZWN0KSkK KyAgKGxldCAoKHN0cnVjdC10eXBlICh0eXBlLW9mIHZhbHVlKSkpCisgICAgKGFwcGx5ICcr CisgICAgICAgICAgIChtZW1vcnktcmVwb3J0LS1zaXplICd2ZWN0b3IpCisgICAgICAgICAg IChtYXBjYXIgKGxhbWJkYSAoc2xvdCkKKyAgICAgICAgICAgICAgICAgICAgIChpZiAoZXEg KGNhciBzbG90KSAnY2wtdGFnLXNsb3QpCisgICAgICAgICAgICAgICAgICAgICAgICAgMAor ICAgICAgICAgICAgICAgICAgICAgICAobWVtb3J5LXJlcG9ydC0tb2JqZWN0LXNpemUKKyAg ICAgICAgICAgICAgICAgICAgICAgIGNvdW50ZWQKKyAgICAgICAgICAgICAgICAgICAgICAg IChjbC1zdHJ1Y3Qtc2xvdC12YWx1ZSBzdHJ1Y3QtdHlwZSAoY2FyIHNsb3QpIHZhbHVlKSkp KQorICAgICAgICAgICAgICAgICAgIChjbC1zdHJ1Y3Qtc2xvdC1pbmZvIHN0cnVjdC10eXBl KSkpKSkKKwogKGRlZnVuIG1lbW9yeS1yZXBvcnQtLWZvcm1hdCAoYnl0ZXMpCiAgIChzZXRx IGJ5dGVzICgvIGJ5dGVzIDEwMjQuMCkpCiAgIChsZXQgKCh1bml0cyAnKCJLaUIiICJNaUIi ICJHaUIiICJUaUIiKSkpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9tZW1v cnktcmVwb3J0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvbWVtb3J5LXJlcG9y dC10ZXN0cy5lbAppbmRleCAwYzAyOTdiNWZjLi5lMzUyZGQxNjVmIDEwMDY0NAotLS0gYS90 ZXN0L2xpc3AvZW1hY3MtbGlzcC9tZW1vcnktcmVwb3J0LXRlc3RzLmVsCisrKyBiL3Rlc3Qv bGlzcC9lbWFjcy1saXNwL21lbW9yeS1yZXBvcnQtdGVzdHMuZWwKQEAgLTY4LDYgKzY4LDE0 IEBAIG1lbW9yeS1yZXBvcnQtc2l6ZXMtdmVjdG9ycwogICAgICAgICAgICAgICAgICh2ZWN0 b3Igc3RyaW5nIHN0cmluZykpCiAgICAgICAgICAgICAgICAxMjQpKSkpCiAKKyhlcnQtZGVm dGVzdCBtZW1vcnktcmVwb3J0LXNpemVzLXN0cnVjdHMgKCkKKyAgKGNsLWRlZnN0cnVjdCBt ZW1vcnktcmVwb3J0LXRlc3Qtc3RydWN0CisgICAgKGl0ZW0wIG5pbCkKKyAgICAoaXRlbTEg bmlsKSkKKyAgKGxldCAoKHMgKG1ha2UtbWVtb3J5LXJlcG9ydC10ZXN0LXN0cnVjdCA6aXRl bTAgImhlbGxvIiA6aXRlbTEgIndvcmxkIikpKQorICAgIChzaG91bGQgKD0gKG1lbW9yeS1y ZXBvcnQtb2JqZWN0LXNpemUgcykKKyAgICAgICAgICAgICAgIDkwKSkpKQorCiAocHJvdmlk ZSAnbWVtb3J5LXJlcG9ydC10ZXN0cykKIAogOzs7IG1lbW9yeS1yZXBvcnQtdGVzdHMuZWwg ZW5kcyBoZXJlCi0tIAoyLjMzLjAKCg== --cf93288d7ba841efa49af747467c62c9--