From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: isearch region or thing at point. Date: Wed, 1 May 2019 07:33:27 -0700 (PDT) Message-ID: References: <20190427001453.isjx247kc3lu5fe4@Ergus> <87a7gcp51i.fsf@tcd.ie> <20190429004135.rn5tp2gnmbjovrxj@Ergus> <87h8agy4yf.fsf@mail.linkov.net> <20190430162501.xmqh5r5h57sjjlq5@Ergus> <87h8af15kg.fsf@tcd.ie> <20190430231614.l423x6eqta5fbhor@Ergus> <874l6f132f.fsf@tcd.ie> <20190501112025.fnsynkbmkvllapyv@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45756"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, Juri Linkov To: Ergus , "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 16:36:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLqLf-000BkP-0x for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 16:36:39 +0200 Original-Received: from localhost ([127.0.0.1]:59844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLqLd-0007Ub-TB for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 10:36:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLqL1-0007Ty-Di for emacs-devel@gnu.org; Wed, 01 May 2019 10:36:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLqKy-0001vz-CG for emacs-devel@gnu.org; Wed, 01 May 2019 10:35:59 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:45506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLqKy-0001sr-3d for emacs-devel@gnu.org; Wed, 01 May 2019 10:35:56 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x41EO0up150869; Wed, 1 May 2019 14:35:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=FHw8t3G8uipTmTGzsku/CP7PHfMNDYiTFGJK802bkC4=; b=tAIiZtoEWgfrfLt0UBJoiH/2lxvEfHNHgS1BP9LMnoNpnCMvOR9VTYW8JTUxun/zAlmM Gf/cO0WcHbo4qO7F466ZRy9H3Sbsen6vYBrOZYeF7RPYaeM+drB0ubKi9JiLVnIDyWhz Cag13jxbIpRH4hno774u6QZ9Ppxn0qsVb5qbQ1QCp5fiTvmupUlqvTSXm071rroWmtDA 0H3RPCpJmNovHQpLhwOXIEyP3hsdslBXBahb9Dt46MSSG6kNgyGq15ERYihwn81ngis8 HhqQG0OmhJObkffEZe8F5GAtwAa9qAWTVgkaY9rQKHX/6eVQx+nMyeUw09Xz4dISxpzi hw== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2s6xhyjyka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 May 2019 14:35:50 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x41EWmdW140385; Wed, 1 May 2019 14:33:49 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2s6xhg9qnu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 May 2019 14:33:49 +0000 Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x41EXSC7020299; Wed, 1 May 2019 14:33:28 GMT In-Reply-To: <20190501112025.fnsynkbmkvllapyv@Ergus> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9243 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=727 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905010093 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9243 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=751 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905010093 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236090 Archived-At: I'm sorry to say that I'm not in favor of `M-w' being bound in `isearch-mode-map' for this behavior. I'm not opposed to some key being bound for it, though I'd prefer that we just define the command and leave it unbound (letting users bind it if they find it handier than just using `M-w' before `C-s'). In Isearch+ I bind `M-w' to `isearchp-kill-ring-save', which I feel is more useful than your command, which is a short cut for the usual Emacs keys. `isearchp-kill-ring-save' copies the current search string to the kill ring. I've bound it to `M-w' in the search map since 2013, when we moved `isearch-toggle-word' from `M-w' to `M-s w'. How about just adding your command and not binding it by default?