all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Karl Fogel <kfogel@red-bean.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: RE: PATCH: isearch-yank-until-char
Date: Mon, 26 Aug 2019 12:36:23 -0700 (PDT)	[thread overview]
Message-ID: <eee52c32-b3ba-4c19-99d4-515f7210c5a4@default> (raw)
In-Reply-To: <874l23ak8m.fsf@red-bean.com>

> So let's have it subsume my patch by coming after my patch :-).

OK.

(But I can guess the outcome.  It's OK; I can always
just add the enhancement to isearch+.el.  It won't be
the first time.)

> An updated patch is attached.  The only new changes in this patch are:
> 
> * Updated the keybinding in isearch-mode-map to C-M-.

FYI, it doesn't do that in the parts that are doc.
Those patch parts still speak of `C-M-c'.

> * Make the search for the character case-sensitive.  (Seems like a
> pretty obvious improvement, given the use cases: when the goal
> character is a letter at all, one is either looking at that letter on
> the screen *or* the letter is some known syntactic delimiter and its
> case is therefore known as well even if the letter is off the screen
> right now.)

FWIW, I don't think that's really TRT.

Personally, I have `case-fold-search' set to nil by
default, so that behavior isn't a problem for me.
But I don't think it should be part of this command.

Users can toggle case-folding in Isearch easily.

There's no reason to have this command make an
assumption about whether its char-search should be
case-sensitive.  I don't think the either...or
assumption you made above is good for the command
to make.  Better to let users control whether to
search for the char case-sensitively.



  reply	other threads:[~2019-08-26 19:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  3:05 PATCH: isearch-yank-until-char Karl Fogel
2019-08-14 14:20 ` Eli Zaretskii
2019-08-14 16:41   ` Karl Fogel
2019-08-14 16:48     ` Drew Adams
2019-08-14 17:20       ` Eli Zaretskii
2019-08-14 17:22       ` Karl Fogel
2019-08-14 17:51         ` Eli Zaretskii
2019-08-14 17:59 ` Noam Postavsky
2019-08-14 20:39   ` Juri Linkov
2019-08-14 20:34 ` Juri Linkov
2019-08-16  4:53   ` Karl Fogel
2019-08-16 17:52     ` Juri Linkov
2019-08-25  2:14       ` Karl Fogel
2019-08-25  3:22         ` Drew Adams
2019-08-25 20:03           ` Juri Linkov
2019-08-26  1:14             ` Drew Adams
2019-08-26  5:20           ` Karl Fogel
2019-08-26 14:50             ` Drew Adams
2019-08-26 17:51               ` Karl Fogel
2019-08-26 19:36                 ` Drew Adams [this message]
2019-08-26 21:29                   ` Karl Fogel
2019-08-26 21:57                     ` Drew Adams
2019-08-26 22:21                       ` Karl Fogel
2019-08-26 22:43                         ` Drew Adams
2019-09-04 16:47                           ` Karl Fogel
2019-09-04 17:00                             ` Eli Zaretskii
2019-09-12 17:44                               ` Karl Fogel
2019-09-16 21:24                   ` Drew Adams
2019-09-17 16:02                     ` Karl Fogel
2019-08-26 21:46                 ` Juri Linkov
2019-08-26 21:52                   ` Karl Fogel
2019-08-26 22:03                   ` Drew Adams
2019-08-26 22:19                     ` Juri Linkov
2019-08-26 22:33                       ` Karl Fogel
2019-08-26 22:40                       ` Drew Adams
2019-08-27 21:31                         ` Juri Linkov
2019-08-27 22:52                           ` Drew Adams
2019-08-27 23:15                             ` Drew Adams
2019-08-25 19:58         ` Juri Linkov
2019-08-14 22:26 ` Stefan Monnier
2019-08-15 18:24   ` Juri Linkov
2019-08-17 12:31     ` Stefan Monnier
2019-08-17 22:51       ` Juri Linkov
2019-08-16  5:11   ` Karl Fogel
     [not found] <<87tvakfnv4.fsf@red-bean.com>
     [not found] ` <<835zmzsuau.fsf@gnu.org>
2019-08-14 15:24   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee52c32-b3ba-4c19-99d4-515f7210c5a4@default \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.