Don't add tags to ELPA packages -- documentation?

Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

I just realized that you can't realistically add tags to your ELPA
packages, because tag names need to be unique across a repo, and your
"v0.6" is going to conflict with other packages' attempts to tag the
same. EBDB occupied some prime tag real estate with its earlier point
versions, but now I can't tag 0.7 because eglot already has that.

Can I patch the README to tell developers not to use tags at all? (You
can't even tag locally and not push them; git still complains.) Or is
there any other trick to solve the situation?

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

> Can I patch the README to tell developers not to use tags at all?

Sure.
Indeed tags are not used in elpa.git and nongnu.git.

Of course, you can still use tags there if you want, like in any
other repository, but you're better off giving them names that include
the relevant package's name, like `ebdb-0.7`.

        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Can I patch the README to tell developers not to use tags at all?
>
> Sure.
> Indeed tags are not used in elpa.git and nongnu.git.
>
> Of course, you can still use tags there if you want, like in any
> other repository, but you're better off giving them names that include
> the relevant package's name, like `ebdb-0.7`.

Good to know! I don't suppose you know what happens when we add ELPA or
nongnu ELPA as a new remote to a repo already containing tags that will
conflict with ELPA tags? Do you know at what stage git will bark at us?
Anyway, I can probably figure this out myself, but inquiring minds on
Matrix want to know...

Re: Don't add tags to ELPA packages -- documentation?

[Adam Porter]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> Can I patch the README to tell developers not to use tags at all?
>>
>> Sure.
>> Indeed tags are not used in elpa.git and nongnu.git.
>>
>> Of course, you can still use tags there if you want, like in any
>> other repository, but you're better off giving them names that include
>> the relevant package's name, like `ebdb-0.7`.
>
> Good to know! I don't suppose you know what happens when we add ELPA or
> nongnu ELPA as a new remote to a repo already containing tags that will
> conflict with ELPA tags? Do you know at what stage git will bark at us?
> Anyway, I can probably figure this out myself, but inquiring minds on
> Matrix want to know...

Well, that mind would be mine.  :)  Yes, I'd like to submit some of my
packages (including some that are already on MELPA) to ELPA or nongnu
ELPA at some point, but I tag my stable releases with tags like "0.6.1",
which MELPA uses for MELPA Stable packages.  It seems like I'd have to
either delete the tags or rename them with the package name as a prefix,
and AFAIK either one would be incompatible with MELPA Stable.  Of
course, I guess there'd be no need to be on MELPA anymore in that case,
but having to fix all the tags would be a hassle, and then I'd have to
break an old habit.  I guess one can't have everything, but it'd be
great if this could be "solved."  The idea of sharing tags with other
repos that aren't part of my own repos feels a little like a Twilight
Zone episode, if there were an Emacs edition: they're not there, but
they're there...  :)

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Adam Porter <adam@alphapapa.net> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>>> Can I patch the README to tell developers not to use tags at all?
>>>
>>> Sure.
>>> Indeed tags are not used in elpa.git and nongnu.git.
>>>
>>> Of course, you can still use tags there if you want, like in any
>>> other repository, but you're better off giving them names that include
>>> the relevant package's name, like `ebdb-0.7`.
>>
>> Good to know! I don't suppose you know what happens when we add ELPA or
>> nongnu ELPA as a new remote to a repo already containing tags that will
>> conflict with ELPA tags? Do you know at what stage git will bark at us?
>> Anyway, I can probably figure this out myself, but inquiring minds on
>> Matrix want to know...
>
> Well, that mind would be mine.  :)  Yes, I'd like to submit some of my
> packages (including some that are already on MELPA) to ELPA or nongnu
> ELPA at some point, but I tag my stable releases with tags like "0.6.1",
> which MELPA uses for MELPA Stable packages.  It seems like I'd have to
> either delete the tags or rename them with the package name as a prefix,
> and AFAIK either one would be incompatible with MELPA Stable.  Of
> course, I guess there'd be no need to be on MELPA anymore in that case,
> but having to fix all the tags would be a hassle, and then I'd have to
> break an old habit.  I guess one can't have everything, but it'd be
> great if this could be "solved."  The idea of sharing tags with other
> repos that aren't part of my own repos feels a little like a Twilight
> Zone episode, if there were an Emacs edition: they're not there, but
> they're there...  :)

My first inkling of this issue came when I ran "git tag -l" in my EBDB
repo, and it returned hyperbole- and eglot-related tags. Talk about
Twilight Zone... I was planning to order up an exorcism on my repository.

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

> Good to know! I don't suppose you know what happens when we add ELPA or
> nongnu ELPA as a new remote to a repo already containing tags that will
> conflict with ELPA tags?

No, sorry, I never use Git tags.
I'm pretty sure you can control which tags are copied where and when.


        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Phil Sainty]

On 2021-08-18 09:51, Eric Abrahamsen wrote:
> Good to know! I don't suppose you know what happens when we add ELPA or
> nongnu ELPA as a new remote to a repo already containing tags that will
> conflict with ELPA tags? Do you know at what stage git will bark at us?

FWIW if you configure your external repo as the source for ELPA to fetch
your package from, then there are no problems at all.

For example, https://git.savannah.nongnu.org/cgit/delight.git/refs/
has version tags from 1.0 .. 1.7 and is included in GNU ELPA with
https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/elpa-packages?id=06e26055b3377#n119

ELPA does not fetch the tags from the external repo, and those tags are
not needed within the ELPA repository, so it's fine.


-Phil

Re: Don't add tags to ELPA packages -- documentation?

[Phil Sainty]

On 2021-08-18 09:51, Eric Abrahamsen wrote:
> Good to know! I don't suppose you know what happens when we add ELPA or
> nongnu ELPA as a new remote to a repo already containing tags that will
> conflict with ELPA tags? Do you know at what stage git will bark at us?

Checking the docs...

Git doesn't push any tags by default, so really git shouldn't bark at
you unless you've explicitly asked it to do that and there turned out
to be a conflict.

"git push --follow-tags" will include relevant tags.
"git push --tag" will include *all* tags.

Unless you're using those, or have configured push.followTags, I think
you won't have any issues.

The small number of existing tags in the ELPA repository would have been
pushed in one of those ways.


-Phil

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Phil Sainty <psainty@orcon.net.nz> writes:

> On 2021-08-18 09:51, Eric Abrahamsen wrote:
>> Good to know! I don't suppose you know what happens when we add ELPA or
>> nongnu ELPA as a new remote to a repo already containing tags that will
>> conflict with ELPA tags? Do you know at what stage git will bark at us?
>
> Checking the docs...
>
> Git doesn't push any tags by default, so really git shouldn't bark at
> you unless you've explicitly asked it to do that and there turned out
> to be a conflict.
>
> "git push --follow-tags" will include relevant tags.
> "git push --tag" will include *all* tags.
>
> Unless you're using those, or have configured push.followTags, I think
> you won't have any issues.
>
> The small number of existing tags in the ELPA repository would have been
> pushed in one of those ways.

Okay, this is really useful! Thank you. So it's only an issue if package
maintainers have explicitly pushed their tags to the ELPA repo. So all
the README needs to say, really, is "don't push your tags to the ELPA repo".

Re: Don't add tags to ELPA packages -- documentation?

[Phil Sainty]

On 2021-08-18 11:36, Eric Abrahamsen wrote:
> Okay, this is really useful! Thank you. So it's only an issue if 
> package
> maintainers have explicitly pushed their tags to the ELPA repo. So all
> the README needs to say, really, is "don't push your tags to the ELPA 
> repo".

Yes, I think so; although it might be worthwhile elaborating to avoid
any potential confusion.  Something like:

Git tags should not be pushed to the ELPA repository.  This is because:

* Tags are global throughout any git repository.

* Therefore tags sourced from one package might conflict with tags
   sourced from another project (e.g. a version tag "1.0").

* The ELPA repository doesn't need any tags.

Note that git will not push any tags unless you explicitly tell it to
do so.

Re: Don't add tags to ELPA packages -- documentation?

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

I'm a bit confused by the conversation so far. Can someone elaborate on "maintainers have explicitly pushed their tags to the ELPA repo"? I do tag all the releases of my packages, as that's a common (and good) practice, but I don't understand why would something like this be affecting ELPA negatively. Does it sync the tags from the remotes or what? 

In general I don't think that something like "stop tagging your releases upstream" is a good solution. Adding a prefix to the tag name (e.g. the package name) also seems weird in the context of a single project repository. 

On Wed, Aug 18, 2021, at 5:30 AM, Phil Sainty wrote:
> On 2021-08-18 11:36, Eric Abrahamsen wrote:
> > Okay, this is really useful! Thank you. So it's only an issue if 
> > package
> > maintainers have explicitly pushed their tags to the ELPA repo. So all
> > the README needs to say, really, is "don't push your tags to the ELPA 
> > repo".
> 
> Yes, I think so; although it might be worthwhile elaborating to avoid
> any potential confusion.  Something like:
> 
> Git tags should not be pushed to the ELPA repository.  This is because:
> 
> * Tags are global throughout any git repository.
> 
> * Therefore tags sourced from one package might conflict with tags
>    sourced from another project (e.g. a version tag "1.0").
> 
> * The ELPA repository doesn't need any tags.
> 
> Note that git will not push any tags unless you explicitly tell it to
> do so.
> 
> 
> 

[-- Attachment #2: Type: text/html, Size: 2061 bytes --]

Re: Don't add tags to ELPA packages -- documentation?

[Yuan Fu]

> On Aug 17, 2021, at 11:41 PM, Bozhidar Batsov <bozhidar@batsov.dev> wrote:
> 
> I'm a bit confused by the conversation so far. Can someone elaborate on "maintainers have explicitly pushed their tags to the ELPA repo"? I do tag all the releases of my packages, as that's a common (and good) practice, but I don't understand why would something like this be affecting ELPA negatively. Does it sync the tags from the remotes or what? 
> 
> In general I don't think that something like "stop tagging your releases upstream" is a good solution. Adding a prefix to the tag name (e.g. the package name) also seems weird in the context of a single project repository. 

Tags are not automatically pushed, so if you don’t explicitly push tags to ELPA[1], ELPA shouldn’t include tags in your upstream repo. Tags are indeed global in ELPA, but again, if no one explicitly pushes his package’s tags to ELPA, there shouldn’t be any conflict. So you can keep tagging your repo without using any prefix. That’s what I gathered from following the thread.

[1] Reading Phil’s message, one can explicitly push tags with

"git push --follow-tags" to include relevant tags.
"git push --tag" to include *all* tags.

So if you don’t do that, you aren’t pushing tags to ELPA.

Yuan

Re: Don't add tags to ELPA packages -- documentation?

[Phil Sainty]

On 2021-08-18 18:41, Bozhidar Batsov wrote:
> I'm a bit confused by the conversation so far. Can someone elaborate
> on "maintainers have explicitly pushed their tags to the ELPA repo"?
> I do tag all the releases of my packages, as that's a common (and
> good) practice, but I don't understand why would something like this
> be affecting ELPA negatively.

It won't.  Not unless you went out of your way to make it a problem.

Your "single project repository" is not the ELPA repo.  The ELPA repo
contains all of the packages in that archive.

This whole discussion only applies if you are manually pushing code
changes to the ELPA repo.  If your package is defined as an external
repo for ELPA's build processes to fetch automatically, then you aren't
pushing *anything* to the ELPA repo at all.


> Does it sync the tags from the remotes or what?

No, it doesn't, so tags can't be a problem if ELPA is fetching the
updates itself.


> In general I don't think that something like "stop tagging your
> releases upstream" is a good solution.

Keep tagging to your heart's content in your own repository.  Just
don't push those tags to the ELPA repo (which you would need to do
explicitly with options to the "git push" command).


> Adding a prefix to the tag name (e.g. the package name) also seems
> weird in the context of a single project repository.

Again, this was purely in the context of the multi-project ELPA repo.
If someone particularly wanted tags in the ELPA repo for a package,
then the tags would need to be namespaced with a prefix in order to
avoid potential clashes.


-Phil

Re: Don't add tags to ELPA packages -- documentation?

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

Makes perfect sense. Thanks for the response! 

I've only used (NonGNU) ELPA with remote upstreams, that's why I wasn't sure for whom
exactly does this conversation apply. 

On Wed, Aug 18, 2021, at 10:21 AM, Phil Sainty wrote:
> On 2021-08-18 18:41, Bozhidar Batsov wrote:
> > I'm a bit confused by the conversation so far. Can someone elaborate
> > on "maintainers have explicitly pushed their tags to the ELPA repo"?
> > I do tag all the releases of my packages, as that's a common (and
> > good) practice, but I don't understand why would something like this
> > be affecting ELPA negatively.
> 
> It won't.  Not unless you went out of your way to make it a problem.
> 
> Your "single project repository" is not the ELPA repo.  The ELPA repo
> contains all of the packages in that archive.
> 
> This whole discussion only applies if you are manually pushing code
> changes to the ELPA repo.  If your package is defined as an external
> repo for ELPA's build processes to fetch automatically, then you aren't
> pushing *anything* to the ELPA repo at all.
> 
> 
> > Does it sync the tags from the remotes or what?
> 
> No, it doesn't, so tags can't be a problem if ELPA is fetching the
> updates itself.
> 
> 
> > In general I don't think that something like "stop tagging your
> > releases upstream" is a good solution.
> 
> Keep tagging to your heart's content in your own repository.  Just
> don't push those tags to the ELPA repo (which you would need to do
> explicitly with options to the "git push" command).
> 
> 
> > Adding a prefix to the tag name (e.g. the package name) also seems
> > weird in the context of a single project repository.
> 
> Again, this was purely in the context of the multi-project ELPA repo.
> If someone particularly wanted tags in the ELPA repo for a package,
> then the tags would need to be namespaced with a prefix in order to
> avoid potential clashes.
> 
> 
> -Phil
> 
> 
> 

[-- Attachment #2: Type: text/html, Size: 2802 bytes --]

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

Hi Yuan,

> Tags are not automatically pushed, so if you don’t explicitly push tags to
> ELPA[1], ELPA shouldn’t include tags in your upstream repo. Tags are indeed

I'd urge you to use more precise terminology.
ELPA is a set of protocols and conventions for distribution and
installation of Emacs packages.
(and GNU ELPA is an ELPA archive hosted at elpa.gnu.org).

The "ELPA" is wrote above refers to a Git repository, presumably to the
Git repository from which the code of the GNU ELPA packages is taken.
So I'd recommend you write it as `elpa.git`.


        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

> Tags are not automatically pushed, so if you don’t explicitly push tags to
> ELPA[1], ELPA shouldn’t include tags in your upstream repo.

Yet, elpa.git does include the following tags:

    0.10
    0.11
    0.2
    0.4
    0.5
    0.6
    0.7
    0.8
    0.9
    1.0
    1.0.0
    1.1.0
    1.2
    1.2.0
    1.3
    1.3.0
    chess.el/2.0.4
    hyperbole-6.0.2
    hyperbole-7.0.0
    hyperbole-7.0.1
    hyperbole-7.0.2

Not sure where they come from.
FWIW, `nongnu.git` doesn't have any tags currently.


        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Kévin Le Gouguec]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Not sure where they come from.

FWIW, this can be examined with Git, e.g.:

$ git branch --remote --contains 0.10
  origin/externals/eglot
$ git branch --remote --contains 1.3.0
  origin/externals/disk-usage

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

Kévin Le Gouguec [2021-08-18 16:26:33] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Not sure where they come from.
>
> FWIW, this can be examined with Git, e.g.:
>
> $ git branch --remote --contains 0.10
>   origin/externals/eglot
> $ git branch --remote --contains 1.3.0
>   origin/externals/disk-usage

Thanks, but by "where" I meant "which kind of operations".
IOW, how did they end up there?


        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Kévin Le Gouguec [2021-08-18 16:26:33] wrote:
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Not sure where they come from.
>>
>> FWIW, this can be examined with Git, e.g.:
>>
>> $ git branch --remote --contains 0.10
>>   origin/externals/eglot
>> $ git branch --remote --contains 1.3.0
>>   origin/externals/disk-usage
>
> Thanks, but by "where" I meant "which kind of operations".
> IOW, how did they end up there?

Developers of those packages would have had to explicitly push them to
elpa.git.

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> Kévin Le Gouguec [2021-08-18 16:26:33] wrote:
>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> Not sure where they come from.
>>>
>>> FWIW, this can be examined with Git, e.g.:
>>>
>>> $ git branch --remote --contains 0.10
>>>   origin/externals/eglot
>>> $ git branch --remote --contains 1.3.0
>>>   origin/externals/disk-usage
>>
>> Thanks, but by "where" I meant "which kind of operations".
>> IOW, how did they end up there?
>
> Developers of those packages would have had to explicitly push them to
> elpa.git.

How does this look?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: elpa-mention-tags.diff --]
[-- Type: text/x-patch, Size: 862 bytes --]

diff --git a/README b/README
index 8a549a6e71..4377f6a43b 100644
--- a/README
+++ b/README
@@ -212,6 +212,17 @@ if it is not your own code, make sure the author has signed the relevant
 copyright papers (for non-trivial contributions), and indicate the author
 correctly in the commit.
 
+** Tags
+
+Git tags should not be pushed to the =elpa.git= repository.  Git tags
+are global throughout a repository, and it is highly likely that tags
+in one package will clash with those in others.  Furthermore, tags
+play no functional role in ELPA repositories.
+
+Developers are welcome to continue using tags locally: so long as they
+are not pushed to the public repository, no conflicts will occur.  Git
+will not push tags without being explicitly told to do so.
+
 ** External branches
 
 A copy of the code of every package is kept in the =elpa.git= repository

Re: Don't add tags to ELPA packages -- documentation?

[Kévin Le Gouguec]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

>> Thanks, but by "where" I meant "which kind of operations".
>> IOW, how did they end up there?
>
> Developers of those packages would have had to explicitly push them to
> elpa.git.

Mmm, IIUC any of "git clone", "git fetch" and "git pull" can fetch tags
if not used with "--no-tags".  A quick look at elpa-admin.el shows some
occurrences of "pull" without "--no-tags", but I haven't looked hard
enough at the GNU ELPA machinery to figure if those could have fetched
the tags we observe.

Apologies for the noise if not.

Re: Don't add tags to ELPA packages -- documentation?

[Stefan Monnier]

Kévin Le Gouguec [2021-08-18 21:43:32] wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>> Thanks, but by "where" I meant "which kind of operations".
>>> IOW, how did they end up there?
>> Developers of those packages would have had to explicitly push them to
>> elpa.git.
> Mmm, IIUC any of "git clone", "git fetch" and "git pull" can fetch tags
> if not used with "--no-tags".  A quick look at elpa-admin.el shows some
> occurrences of "pull" without "--no-tags", but I haven't looked hard
> enough at the GNU ELPA machinery to figure if those could have fetched
> the tags we observe.

But elpa-admin.el is not run inside `elpa.git`, only inside clones
of it.  So yes, we can get tags within clones of `elpa.git` but for them
to reach `elpa.git` itself (the repository on git.sv.gnu.org) someone
needs to push them there, AFAIK.


        Stefan

Re: Don't add tags to ELPA packages -- documentation?

[Jonas Bernoulli]

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

Let's document that tags should not be pushed; both why and how,
as described elsewhere in this thread.

But I expect that tags will still occasionally be pushed anyway.
When that happens we should figure out what upstream repository
they came from, educate the respective maintainer about how to
avoid pushing them again, and then delete them.

But [because it is going to keep happening] this is more important:

> Mmm, IIUC any of "git clone", "git fetch" and "git pull" can fetch tags
> if not used with "--no-tags".  A quick look at elpa-admin.el shows some
> occurrences of "pull" without "--no-tags", but I haven't looked hard
> enough at the GNU ELPA machinery to figure if those could have fetched
> the tags we observe.

Every occurrence of "git clone ..." and "git remote add ..." in the
documentation should be updated to mention that "--no-tags" has to be
used to prevent tags from being pulled.  We should also document how to
recover if the tags have already been pulled.  And finally we should add
an annotated tag named something like "use--no-tags" and use its
annotation to repeat the documentation about adding "--no-tags" and how
to clean up.

     Jonas

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Jonas Bernoulli <jonas@bernoul.li> writes:

> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
> Let's document that tags should not be pushed; both why and how,
> as described elsewhere in this thread.

I sent an in a README patch a couple of messages up-thread.

> But I expect that tags will still occasionally be pushed anyway.
> When that happens we should figure out what upstream repository
> they came from, educate the respective maintainer about how to
> avoid pushing them again, and then delete them.

This looks fairly simple. Tags can be deleted locally with:

git tag --delete <tagname>

and deleted from the upstream repo with:

git push origin :refs/tags/<tagname>

Apparently pushing an empty :tagname does the trick; thank you git for
more unintuitive syntax. The "refs/tags" is safer since tags and
branches have separate namespaces and we might hit a branch by accident.

> But [because it is going to keep happening] this is more important:
>
>> Mmm, IIUC any of "git clone", "git fetch" and "git pull" can fetch tags
>> if not used with "--no-tags".  A quick look at elpa-admin.el shows some
>> occurrences of "pull" without "--no-tags", but I haven't looked hard
>> enough at the GNU ELPA machinery to figure if those could have fetched
>> the tags we observe.
>
> Every occurrence of "git clone ..." and "git remote add ..." in the
> documentation should be updated to mention that "--no-tags" has to be
> used to prevent tags from being pulled.  We should also document how to
> recover if the tags have already been pulled.  And finally we should add
> an annotated tag named something like "use--no-tags" and use its
> annotation to repeat the documentation about adding "--no-tags" and how
> to clean up.
>
>      Jonas

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Jonas Bernoulli <jonas@bernoul.li> writes:

> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
> Let's document that tags should not be pushed; both why and how,
> as described elsewhere in this thread.
>
> But I expect that tags will still occasionally be pushed anyway.
> When that happens we should figure out what upstream repository
> they came from, educate the respective maintainer about how to
> avoid pushing them again, and then delete them.
>
> But [because it is going to keep happening] this is more important:
>
>> Mmm, IIUC any of "git clone", "git fetch" and "git pull" can fetch tags
>> if not used with "--no-tags".  A quick look at elpa-admin.el shows some
>> occurrences of "pull" without "--no-tags", but I haven't looked hard
>> enough at the GNU ELPA machinery to figure if those could have fetched
>> the tags we observe.
>
> Every occurrence of "git clone ..." and "git remote add ..." in the
> documentation should be updated to mention that "--no-tags" has to be
> used to prevent tags from being pulled.  We should also document how to
> recover if the tags have already been pulled.  And finally we should add
> an annotated tag named something like "use--no-tags" and use its
> annotation to repeat the documentation about adding "--no-tags" and how
> to clean up.

I'll bet we can write a hook to reject tags. The "update.sample" hook
example in .git/hooks looks like it has most of what we'd need.

Re: Don't add tags to ELPA packages -- documentation?

[Andreas Schwab]

On Aug 19 2021, Eric Abrahamsen wrote:

> and deleted from the upstream repo with:

git push --delete origin tag <tagname>

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: Don't add tags to ELPA packages -- documentation?

[Eric Abrahamsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Aug 19 2021, Eric Abrahamsen wrote:
>
>> and deleted from the upstream repo with:
>
> git push --delete origin tag <tagname>

That's much more reasonable.