From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: RE: [PATCH] Add new function to test whether a key is present in a hash table.
Date: Thu, 15 Feb 2018 17:03:37 -0800 (PST) [thread overview]
Message-ID: <eebe25b9-e379-4269-9a9f-78de96e385d7@default> (raw)
In-Reply-To: <jwv8tbtg8tk.fsf-monnier+gmane.emacs.devel@gnu.org>
> > Such a function is useful because in Emacs Lisp, 'gethash'
> > cannot return whether the key is present as in Common Lisp,
> > and using 'gethash' alone to test for presence is nontrivial.
>
> We could also implement it in Elisp:
> (defun hash-table-contains-p (key table)
> (let ((x '(:hash-table-contains-p)))
> (not (eq x (gethash key table x)))))
Yes, as I said:
Everyone was coding their own (in Lisp).
using a unique cons, uninterned symbol, or
some other unique object.
Philipp used an uninterned symbol:
(let ((uniq-symb '#:void))
(not (eq uniq-symb (gethash key table uniq-symb))))
I (like you) used a unique cons:
(let ((uniq-cons (cons 1 1)))
(not (eq uniq-cons (gethash key table uniq-cons))))
But isn't it better to define this in C?
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28753
next prev parent reply other threads:[~2018-02-16 1:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 20:34 [PATCH] Add new function to test whether a key is present in a hash table Philipp Stephani
2018-02-15 22:03 ` Clément Pit-Claudel
2019-04-19 17:33 ` Philipp Stephani
2018-02-15 22:59 ` Stefan Monnier
2018-02-16 1:03 ` Drew Adams [this message]
2018-02-16 1:59 ` Stefan Monnier
2018-02-16 2:50 ` Drew Adams
[not found] <<20180215203406.64372-1-phst@google.com>
2018-02-15 22:08 ` Drew Adams
2018-02-15 23:35 ` Eric Abrahamsen
2018-02-16 6:51 ` John Wiegley
2018-02-18 14:29 ` Richard Copley
2018-02-19 6:02 ` John Wiegley
2018-02-19 17:26 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebe25b9-e379-4269-9a9f-78de96e385d7@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.