From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources Date: Fri, 30 Oct 2020 01:02:14 +0200 Message-ID: References: <87o8n1aw9k.fsf@gmx.net> <87imbamuw9.fsf@gnus.org> <87r1pyz27k.fsf@gmx.net> <871rhy5j9h.fsf@gnus.org> <87mu0mz0op.fsf@gmx.net> <7002ef78-2d34-a812-5d38-5b4423d3068e@yandex.ru> <87ft6dzybm.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18283"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , Lars Ingebrigtsen , 43004@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 00:03:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYGx0-0004cp-V0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 00:03:22 +0100 Original-Received: from localhost ([::1]:43588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYGwz-0006LF-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 19:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYGwh-00068M-AV for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 19:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYGwh-0005TR-1V for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 19:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYGwg-0000BK-Uk for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 19:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Oct 2020 23:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43004 X-GNU-PR-Package: emacs Original-Received: via spool by 43004-submit@debbugs.gnu.org id=B43004.1604012543629 (code B ref 43004); Thu, 29 Oct 2020 23:03:02 +0000 Original-Received: (at 43004) by debbugs.gnu.org; 29 Oct 2020 23:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:55270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYGw3-0000A5-7w for submit@debbugs.gnu.org; Thu, 29 Oct 2020 19:02:23 -0400 Original-Received: from mail-ej1-f41.google.com ([209.85.218.41]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYGw2-00009u-G0 for 43004@debbugs.gnu.org; Thu, 29 Oct 2020 19:02:22 -0400 Original-Received: by mail-ej1-f41.google.com with SMTP id k3so6040528ejj.10 for <43004@debbugs.gnu.org>; Thu, 29 Oct 2020 16:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cemCvFIPrSsNUuM7EdW0NNrv21YqyEo1nu1e8vrpyhs=; b=toLbLaROsXrFBNJFn5RaCoemVk8f4yDCaHG4toTdGM3z5cgglPolEdNSLW/JH6XGne faHFWUWdWrBNNVAqxW8UgWtBH6n7m34No8Pl5yHWjjqxPQjI/93hZmTpscLDnySZ/niE jqObFruUws/eJQNP0u5TDm6DHMo+1Z5yfLaSiXlkFRRiMo0WWHtf5rof6EAtvThHg00H WHQLlcaGiAEwVwYcBfqPeHdDUP2VdfmnhJV+IXh8vTBJ8B1C1RjyxSFdtRPEGYDF6qnU WF2/wDc5Gm0aqTwVpLoaTdu+lEcDxCzIVZJM+JKDrCTVl8CQFuDEYIWlLtj10X4O0cmN ZzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cemCvFIPrSsNUuM7EdW0NNrv21YqyEo1nu1e8vrpyhs=; b=JAshp5pE1ovKASXFYtZ/x4Eo4w8JP0vkv27Ak2QiiRuPrRt/dLO+M+sPQX3Uiut9WV hM+mZMFJxpLmU9ugNvLhvUZLWYh/xrojmDw47tUZ+BOykZoNxPICImbklNvozS2XfoVr Rr+VNY3XkIbY4UNkoAePehLZQ8m/wXm5vFLmPH+dl9WaWQwGMaTvXu/O8uJfUB/IDv+A mLLT61SqKxxCMSeCoP2Gz/Nj97LykPiY03lPmo7HnCc7Bsno2xQ3dxFxnPcspWkXE/S9 S295VFaiZzbRRyqD/uw/ufSuv98fh813TuGQwHrqEDmhi5GH4d7+V7mFl4YnG48wzplm aLJg== X-Gm-Message-State: AOAM531D0GdpVAyFhjU9tvws+1IVu+uSZjz/+DJJMVmKOiKKkXJAHum+ nNCPDA2osUHPbXIWRYn680o= X-Google-Smtp-Source: ABdhPJywthgA0Y7gPGltcpLUURtOi5XGtSrFx0csfVIYJCgAyStg44V913wAWVigLzfKXeNUYxL22A== X-Received: by 2002:a17:906:d41:: with SMTP id r1mr6114493ejh.383.1604012536699; Thu, 29 Oct 2020 16:02:16 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id ef13sm2169764ejb.44.2020.10.29.16.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 16:02:15 -0700 (PDT) In-Reply-To: <87ft6dzybm.fsf@gmx.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192017 Archived-At: On 16.10.2020 23:54, Stephen Berman wrote: > I've attached the output of two batch runs using the patched > elisp-mode-tests.el. The first run was executed from my home directory, > the second run was executed from the partition the file is really > located on, which is symlinked from my home directory: > > (expand-file-name > "~/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") > => > "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" > > (file-truename > "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") > => > "/datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" > > On the first run there are no unexpected failures, on the second, there > are five unexpected failures. So, what happens if you just remove the 'file-truename' call from the declaration of emacs-test-dir? It was added by Glenn in c4ecc01a45, and there must be a reason for it, but it seems like it causes the current failures. Ultimately, if we don't manage to fix it in an easy way, we could replace the (should (equal xref expected-xref)) comparison inside xref-elisp-test-run with multiple deeper comparisons (and use file-equal-p instead of equal for file names). Or call xref-location-marker and compare markers.