From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Wed, 1 Feb 2023 10:08:52 +0100 Message-ID: References: <834jsccepb.fsf@gnu.org> <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> <115a6020-2b86-2653-844e-d19eb03cf62c@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org To: Tom Gillespie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 01 10:16:31 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pN9EF-0005I9-2S for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Feb 2023 10:16:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pN9CO-0007D1-0O; Wed, 01 Feb 2023 04:14:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pN9CL-0007CM-Hh for emacs-devel@gnu.org; Wed, 01 Feb 2023 04:14:34 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pN9C9-0001I6-E8; Wed, 01 Feb 2023 04:14:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675242852; bh=5VMdYtMiDsTDYA6Ww4hzim1f5N+YkJ+46JFDlo9R/qQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ubjUJjnQzn6ZUMeNGfui/iT3fe4BGVqr0HAwc8aPgzC0s3Rv3NU0O24rN2QFa5LFq ASkbMVS6HyUizozO5Vtx8B/1LP4sPnUVw4qxJ+UxjtbIpLkxf65WN5I7g+BBiZRnpm V5U+t+oNAi+n8zrXcx9qeuL8kOByzE89YqB6CPWirjxuXFLFrb0maLax1L6YlfkZE7 Pd67IGQUHa5Klw5n1QnY2gTTIoPAaJKHt7vGDJa1LKIrUJ5rkYZ5XgouzIWmQzm30/ NP5Ni3npv2m3U25JEhmqcpKr46/B0EVJtg+gyPpmvvmu1m5m6NCi34TqaHJ1iKEBSV 9TmtWCNK+2icg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([213.142.97.245]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCsQ4-1pVuXG0UAy-008sE7; Wed, 01 Feb 2023 10:08:54 +0100 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:tl7H4NMbVbvgwDla3f+I4qXlqsOQDDcK83NOFkaWKdCt+GaFBQD /omOp0Bcpbl7Q5GzxqLNtVdZm4Dq4H7eoALiAICpWNVcs1dsNHN53sxBYH/KNdwCD0WfBxR 6GrpuufVrj13Xl5q4Uwck38ofnClU9SfLZTP89sl7SHmYsoI6ZTUOFE8qrgGRA3yhzZwNaq 6AWj3t8zWByHGX6HZPvTw== UI-OutboundReport: notjunk:1;M01:P0:EPLbXSTbgEY=;som5XtxsqcVwi035b4aj/uVUmR4 1Yui0ejRIiUJmJcbXq5P+sJuTu8F5JLY12G9z4VJ2Dk82DVvILcrArk87U+ngwAVhnoyuAZqf Gpo0lCwEqN9AUyw97W4HuFQmR/dmY2VR+jx/UHFnAiUVtqe+i/YZhdQhdgc9ww2p7aI55ixbI 9OvZEloTjZVD/TKyFpHqFudeRT3qfL/9rPuhdq/LYIfkx7Hq/P8C6jRuCabzifZ/rkS05T+Hx B3c9cRmaQKVkSQjVrDqptNs1OSNQLokYmHeOxuzwWC8R0i/n4r8KsRVaiNzZw5DVyKrKrZwc1 DvjdP43eSEcJWkm2if3kmaDp9C5AtagP+Nqsa20DQctz38Bd8x6vbBdq389eK+zqXkyL/mQMM Luya5BRCk0qXrPgKpcxZYe2N2uYTOqA1y/i+S2XEtShyNIk/2r35J987sIE1bLcR+/D+71xSZ Xfbp4j8llx5VXFeK+SAdlLNjx9iEW7y5m1O4WsuXm4Kys1rj+q3jWJtGgr7oItdCrm3VAfm3p d+K/KzKFzI8SvF678Oh3xTalqV6pAfnOmGGAZD/uU+mGITCM2cJvTg/gP+bM5QMhs+JRm0n3E gjkjJ4arAwrwd/blvPsVwZgd8SB43I5NvoA8/VDE15H3yoqaPBc7kQTWb0rDn+BqftvvZ45M9 DBTsUxl/MLDOxvlvfmtmNOfq34RGEYqnV6wUb1NMIFCxmeyeyVdVveKfbVhKqo2su34VbYHXR p+0wWHS6FDL+Qi+HqWWVpdj4ObPFFd2w+zf+k+I0C1uPNULsDVrpvi/i6KiLSoWvQ3L+jnmO Received-SPF: pass client-ip=212.227.17.21; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302850 Archived-At: >> BTW in the version you attached I see >> + (get-lru-window (or reusable-frames frame) nil t)))) >> >> What's the purpose of 'reusable-frames' here? > >>From a previous message here is the scenario that I envisioned > and have tested: > >> they have 3 visible frames, one for each monitor, and they want >> the lru window to be selected from any of those visible frames > > They achieve this by including '(reusable-frames . visible) in the > alist. That way they can get the same behavior for all visible windows > as they would if they had a single monitor and a single frame. Suppose a user provided a 'reusable-frames' entry and an application now asks for 'display-buffer-use-least-recent-window'. The customization which earlier affected 'display-buffer-reuse-window' only would now affect the search of a window that does not show BUFFER too. This would constitute an incompatible change we simply cannot explain. We could add a new action alist entry like 'lru-frames'. Then we could use that in 'display-buffer-use-some-window' too. Not really suitable for Emacs 29 though. Can't those 3 monitors people use 'display-buffer-use-some-frame' with a suitable 'frame-predicate' instead? > In light of this discussion which patch do we want to go with? The one > that calls get-buffer-window internally or the one that does not? Once > we have the answer I will summarize what we have discussed here > in the comments and send a final patch. Let's not rush things again. We deal here with half-baked changes and should try to put them straight to eliminate collateral effects instead of adding new ones. martin