From: Daniel Colascione <dancol@dancol.org>
To: "Mattias Engdegård" <mattiase@acm.org>, "Eli Zaretskii" <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 34910@debbugs.gnu.org
Subject: bug#34910: 27.0.50; Too much matching reentrancy
Date: Sat, 30 Mar 2019 07:52:12 -0700 [thread overview]
Message-ID: <ed75d591-1ca6-4656-4422-a14b405e0019@dancol.org> (raw)
In-Reply-To: <62AAF86C-0A25-4FD3-9F35-D2D100F78D6E@acm.org>
On 3/30/19 4:18 AM, Mattias Engdegård wrote:
> 30 mars 2019 kl. 10.30 skrev Eli Zaretskii <eliz@gnu.org>:
>>
>>> Here is another improvement: there should be no reason to keep the
>>> regexp busy during the overflow error processing, so release it first.
>>
>> Looks OK to me.
>
> Thank you, both pushed.
Thanks!
>
>>> By the way, is there any reason why only calls to re_search_2 are made
>>> with a busy-marked regexp buffer, not calls to re_search? Are the
>>> latter guaranteed not to be reentrant?
>>
>> Not sure. Stefan, any thoughts?
>
> Maybe Daniel only had reentrancy concerns about regexp matching on buffers, not on strings?
We do automatic syntax discovery on buffers, not strings.
next prev parent reply other threads:[~2019-03-30 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 21:34 bug#34910: 27.0.50; Too much matching reentrancy Mattias Engdegård
2019-03-19 8:05 ` Eli Zaretskii
2019-03-19 9:27 ` Mattias Engdegård
2019-03-19 10:01 ` Eli Zaretskii
2019-03-19 12:25 ` Mattias Engdegård
2019-03-19 12:31 ` Eli Zaretskii
2019-03-30 9:29 ` Eli Zaretskii
2019-03-19 12:50 ` Mattias Engdegård
2019-03-30 9:30 ` Eli Zaretskii
2019-03-30 11:18 ` Mattias Engdegård
2019-03-30 14:52 ` Daniel Colascione [this message]
2019-03-30 12:55 ` Stefan Monnier
2019-03-30 13:05 ` Mattias Engdegård
2019-03-30 13:37 ` Eli Zaretskii
2019-03-30 16:22 ` Stefan Monnier
2019-03-30 17:10 ` Daniel Colascione
2019-03-30 19:06 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed75d591-1ca6-4656-4422-a14b405e0019@dancol.org \
--to=dancol@dancol.org \
--cc=34910@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.