From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35702: xref revert-buffer Date: Fri, 24 May 2019 13:09:50 +0300 Message-ID: References: <87tvdzv4m2.fsf@mail.linkov.net> <838suw5jvh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="20389"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35702@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 24 12:10:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hU79Q-00058N-3c for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 12:10:12 +0200 Original-Received: from localhost ([127.0.0.1]:51963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hU79O-0001hF-JK for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 06:10:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hU79I-0001fB-Ai for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 06:10:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hU79H-0004Sj-FJ for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 06:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hU79H-0004SZ-B9 for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 06:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hU79H-0000FO-3j for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 06:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2019 10:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35702 X-GNU-PR-Package: emacs Original-Received: via spool by 35702-submit@debbugs.gnu.org id=B35702.1558692602945 (code B ref 35702); Fri, 24 May 2019 10:10:03 +0000 Original-Received: (at 35702) by debbugs.gnu.org; 24 May 2019 10:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:46129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hU79F-0000F4-Kt for submit@debbugs.gnu.org; Fri, 24 May 2019 06:10:01 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:50970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hU79D-0000Em-MD for 35702@debbugs.gnu.org; Fri, 24 May 2019 06:10:00 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id f204so8765531wme.0 for <35702@debbugs.gnu.org>; Fri, 24 May 2019 03:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=veg+N2RsCpqYtPd68SVa4FOkjfIUjMbwwNyUo8vdZf8=; b=X1qqdkraspLfsSS8W/Ws0sGYFQ+ohDRXZ5fhfgP8DV64fisowHW7BqTAD6HlFpMQwU 9MNMg95FE+MGB0kSQybDzcKgzuKmsyhBzpG/fFK5dd41dyQF8N2JRnAG98XXC1E5puNC EQqLOR83xfeWl34kLluR6VxpvhyyULCMV0EpwxvxtsZ8vqzV2zchr9TIeSRi6WZAxgAq SAvIsz/xLySBh7XweYA5MzyFGwfpYkX9bAyj5Z/KxuqYDV2azSbXzgwuTQExj2+grjnY FeoQZE6PCJd2gcCFJTkCJw1gA6nUP0eLOxM9owrHaL1dOP+R+CORxxZb4+s4ujk57H3t k0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=veg+N2RsCpqYtPd68SVa4FOkjfIUjMbwwNyUo8vdZf8=; b=lg3Rg0M66rRkO1ErJHRtVm5f61M2jG84C4jEk3LIh+q7u7ryfsxE6/3rhbUbhJbH/o y5Zc1ogG5VvxKwY8FcK6+7dRKVV1OlQXX9wP8n2cav2DWDnTXmHMs0DW0ku/auy7XYY3 DXBNkhXZYsyS3rAxJPtz2rH/3d79/kjDgo1KB8XQ2v30nXhzzbwOzPFmh2ZpHuIOq0/U TD8HVs/uusq1ltIZalPe68eAlgGA9LoI43Ribg0IlH60DSLq4HC1Bw2P20mLOeFYt7X3 jycRKXeowIxRfF01SLs+K8oYpc/AQ5kWLDGf4I60b6sCMRk9t1zqIAAwP1fD9I2f8N1p vJjg== X-Gm-Message-State: APjAAAVuuJIX7WFOTK088H/Lds/raDRCAHZM9vM2uoKlxJp4quuHV1h5 JICnOkMO11xXMKXL8zaTJG8= X-Google-Smtp-Source: APXvYqwSNvSr5EyneAoI8+jaJAdCTvDySe/2OmexM3sLm2HQYSf/B5OoZZysdSgPNUAY3M9POXfauw== X-Received: by 2002:a05:600c:2116:: with SMTP id u22mr15088106wml.58.1558692593638; Fri, 24 May 2019 03:09:53 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id j123sm3248990wmb.32.2019.05.24.03.09.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 03:09:52 -0700 (PDT) In-Reply-To: <838suw5jvh.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159706 Archived-At: On 24.05.2019 11:36, Eli Zaretskii wrote: > Thanks, but that changeset has a few problems: > > . the new command xref--revert-xref-buffer uses an internal name, Is that a problem by itself? We have other bindings that use internal command names as well. > and has no doc string How about something like: Refresh the search results by repeating the search. > . neither NEWS nor the user manual document the 'g' key in XREF > buffers I can add the NEWS entry. > . it looks like this new command is not useful after M-., because I > get an error message when I try using it (perhaps this is because > I didn't understand its use case due to lack of docs) It has been a deliberate choice to simplify the implementation. IME, you don't ever want to refresh the list of definitions. But for other search results (references, apropos, project-find-regexp, dired-do-find-regexp) it's a lot more common. Commit 49a363c875 also brings in another difference between the behaviors of xref-find-definitions and xref-find-references: the latter now shows the xref buffer even when there is just one hit. > Let me know if I can help in fixing any of the above. (I tried to > figure out what this command does and how, but quickly got lost in a > chain of indirections via undocumented internal functions and > variables, sorry.) Do you have a better idea now? Please let me know if you have any further questions.