From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71554: 29.3; eshell-command async buffer behavior Date: Fri, 5 Jul 2024 10:41:20 -0700 Message-ID: References: <87frtfpqyn.fsf@librehacker.com> <87ikyb8igc.fsf@posteo.net> <86tthvwdxp.fsf@gnu.org> <87ed8z8duo.fsf@posteo.net> <87a5jm94b6.fsf@posteo.net> <874j9ogjfo.fsf@posteo.net> <3ed3832f-e874-ab89-52c3-c0c32650cb33@gmail.com> <86o77qbjv9.fsf@gnu.org> <87r0c87a48.fsf@posteo.net> <86plrs75my.fsf@gnu.org> <87r0c8nyp4.fsf@posteo.net> <865xtk6qkl.fsf@gnu.org> <87le2gyqq8.fsf@posteo.net> <87h6d3zz52.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12624"; mail-complaints-to="usenet@ciao.gmane.io" Cc: christopher@librehacker.com, Eli Zaretskii , 71554@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 19:43:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPmy5-0003BM-KH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 19:43:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPmxZ-0001bq-HW; Fri, 05 Jul 2024 13:43:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPmxX-0001bT-FR for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 13:42:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPmxX-0008Js-6f for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 13:42:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPmxa-0005kD-8o for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71554 X-GNU-PR-Package: emacs Original-Received: via spool by 71554-submit@debbugs.gnu.org id=B71554.172020135122039 (code B ref 71554); Fri, 05 Jul 2024 17:43:02 +0000 Original-Received: (at 71554) by debbugs.gnu.org; 5 Jul 2024 17:42:31 +0000 Original-Received: from localhost ([127.0.0.1]:44917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPmx5-0005jO-Be for submit@debbugs.gnu.org; Fri, 05 Jul 2024 13:42:31 -0400 Original-Received: from mail-il1-f178.google.com ([209.85.166.178]:58659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPmx2-0005j7-SN for 71554@debbugs.gnu.org; Fri, 05 Jul 2024 13:42:29 -0400 Original-Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-383dfcd8cdfso8037585ab.1 for <71554@debbugs.gnu.org>; Fri, 05 Jul 2024 10:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720201280; x=1720806080; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CHe9F1vTgsdrCvBuvIh6GIBStyvrd350B3auHDSYkkU=; b=LZQFW8i7pN7w5gtonIsBCcrlJ44KVYnJ5+cvmlVfPD36Ezqe40QnLt6xmEG43mTkR+ UYQVDbjOTGvhUKYf4VOhWe9daQZPoSyjL2PZTF91wxhjurAU/MdGC4aWnfwtA3SA1qqG HGkWZJPQjkYfAG1Z3AZQNBy5DsaJxppJM+0Fcatns8VfG7r7C9d0BzuyN8TnSjD5wftl +bIKE2V45CDLzpi6yDmRd7pXxduPSNkEhFdgOp+hijHefnX/qUQW+/8MxuPjAN4bBXId 4UCTsbet5EZvgRDKl4ryBd6MkN9Pw/yljYGCxuDmxIsSs5yXzSogTDM1mYyC9RmeeyLe yDLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720201280; x=1720806080; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CHe9F1vTgsdrCvBuvIh6GIBStyvrd350B3auHDSYkkU=; b=lD5smr1ueVhqaCOYOl4FPX/b7tYSkZ4K+YwFcQ3S7Ba7xU1x7DTKzBbz2Dnc0T0NBe qAq6Ur1MugAVEPHuj+DmfhHMjegv5xTQRkQlrU564yRL4AaT6z9eecOHVvDuJgg/u2BQ Y0bbrWPZqn/ea/S0Jib1lBQw/hldTSsvxUU1A5iFLx0tDOt2C6JwS/1SLeP5qZZKA2ho xdcZ5FQB8f+EXD4UkorwAQZeOT+SHPUXho6twOF/CBbTOP1W2Cg4AW1QGGWNg7eY6SUF 99xWM+YQezyF3wZFXaKhcGG9618S/Gt24hkqubQY17vDZPklliSZ06gAXJFQl+/BSCz3 fMBg== X-Forwarded-Encrypted: i=1; AJvYcCVciYzHFUaA34/7imq528QVOCSTRhIICKTJuZO1HbZypwNln35/hGiJxbXsHQfLwcjh/dIrNbohAcX25rpqoh7d8kgwy2E= X-Gm-Message-State: AOJu0YxOWsHbUtifK3GKdfGN9iC7MnLZKfKd0YSnbVRMsVXcI6yMV6QT WF/RnGSBOzes3nobR3kpRRmafuwHS4aP5uN12GHUSZ7i9rmAVguK X-Google-Smtp-Source: AGHT+IEtasRWoPNLP1dhhNXlclfFkIxr1/G/8VHCESCtNXMIyyRJT9aammFQzO9+Tu4+e+ZF5DlTwg== X-Received: by 2002:a05:6e02:1647:b0:381:aa0b:3cd8 with SMTP id e9e14a558f8ab-3839861adaamr70960565ab.4.1720201279813; Fri, 05 Jul 2024 10:41:19 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-72c6b2a15acsm11409088a12.43.2024.07.05.10.41.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 10:41:19 -0700 (PDT) Content-Language: en-US In-Reply-To: <87h6d3zz52.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288429 Archived-At: On 7/5/2024 7:34 AM, Thierry Volpiatto wrote: > Here the patch modified (only changed default value, a typo and the > commit message). Thanks. One question about this before I merge: is the 'cl-loop' part necessary? I glossed over that part when reviewing the patch previously, but thinking about it more (and consulting 'shell-command' and 'shell-command--same-buffer-confirm'), I'm not sure we need it. My understanding is that this would prompt the user if there were a buffer named "*Eshell Async Command Output*" (good), but also if there were a buffer named "*Eshell Async Command Output*<2>" (possibly unnecessary). I can see the reasoning for doing this for the 'confirm-kill-process' setting (it tries to keep the number of async Eshell commands to 1), but less so for the other settings. I don't think it's useful for 'confirm-new-buffer' or 'confirm-rename-buffer'. Given the above, and that 'shell-command' doesn't do this, maybe Eshell shouldn't either?