From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#31855: 27.0.50; Async shell command finished message not visible any more Date: Sat, 16 Jun 2018 14:17:22 -0700 Message-ID: References: <87bmcb5n71.fsf@web.de> <831sd715hj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1529183767 3986 195.159.176.226 (16 Jun 2018 21:16:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 21:16:07 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: Michael Heerdegen , 31855@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 16 23:16:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUIYE-0000v5-Vr for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 23:16:03 +0200 Original-Received: from localhost ([::1]:52899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUIaJ-0007OB-Kc for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 17:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUIaD-0007O4-0m for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 17:18:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUIa9-0002pW-Se for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 17:18:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUIa9-0002pS-OX for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 17:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUIa9-0002IH-IN for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 17:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 21:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31855-submit@debbugs.gnu.org id=B31855.15291838528778 (code B ref 31855); Sat, 16 Jun 2018 21:18:01 +0000 Original-Received: (at 31855) by debbugs.gnu.org; 16 Jun 2018 21:17:32 +0000 Original-Received: from localhost ([127.0.0.1]:52155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUIZf-0002HV-IG for submit@debbugs.gnu.org; Sat, 16 Jun 2018 17:17:31 -0400 Original-Received: from dancol.org ([96.126.100.184]:36006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUIZd-0002HM-J6 for 31855@debbugs.gnu.org; Sat, 16 Jun 2018 17:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=DhCTXRln4lm5jnx6ZvcN/Bg93osg3ze5RntqlKHCfQ0=; b=KyVX807s5wcJP2ZjfaxSUQLSS340Ogw/5Q/Bo7J2Vzlq6BTxFRpbGFvaGEeGmbkoV6mu7m434NkLaILvCVxVjTq76muLYX4paKtsvfeLNqTbHqlrm6gt41auMWwmIBYQM/mUa5oQOiumiOm4i1nAf4YM12ezutAxsE3FKyMsO+MOUl9vJa2FP46ttpJJC5akYLcFUeaWCf6l5SvYJkuSyxn2x/awNUc5o2Ia0pLefiCSFxfF4nLLATP9P78N2RElGXG6VVFMD0MRxYQA4trYbLnNLtTQNJ7RNeStKlqxAziOWlB7NRE6JS8OsCrhpLFnVQithYDL5THZBWIkafTiQw==; Original-Received: from [172.92.145.124] (helo=[192.168.86.27]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fUIZb-0003ca-Uz; Sat, 16 Jun 2018 14:17:27 -0700 In-Reply-To: <831sd715hj.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147539 Archived-At: On 06/16/2018 01:48 AM, Eli Zaretskii wrote: >> From: Michael Heerdegen >> Date: Sat, 16 Jun 2018 07:12:50 +0200 >> >> In emacs25 -Q, I type, for example, M-! t r u e SPC & , and the >> echo area displays "true: finished". >> >> In master emacs -Q, doing the same gives you no visible feedback any >> more. A message is logged in *Messages*, but it seems to be dismissed >> immediately. > > Daniel, this seems to be due to your recent changes in keyboard.c. If > I make the change below, which reverts a small part of your changes, > the problem is gone: > > diff --git a/src/keyboard.c b/src/keyboard.c > index 5409918..76097e8 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt, > /* These are no-ops the first time through, but if we restart, they > revert the echo area and this_command_keys to their original state. */ > this_command_key_count = keys_start; > - if (INTERACTIVE && is_replay) > + if (INTERACTIVE && t < mock_input) > echo_truncate (echo_start); > is_replay = true; Yep. You're right. I'll bring us back to the old logic here. I just worry that the "t < mock_input" condition is wrong in the case where we use a function key map to rewrite an input to nothing, but maybe the improved last_nonmenu_event tracking will fix that class of problem by itself.