From: Daniel Colascione <dancol@dancol.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 31855@debbugs.gnu.org
Subject: bug#31855: 27.0.50; Async shell command finished message not visible any more
Date: Sat, 16 Jun 2018 14:17:22 -0700 [thread overview]
Message-ID: <ed45c812-91a1-f46d-3a5d-cfe0803db793@dancol.org> (raw)
In-Reply-To: <831sd715hj.fsf@gnu.org>
On 06/16/2018 01:48 AM, Eli Zaretskii wrote:
>> From: Michael Heerdegen <michael_heerdegen@web.de>
>> Date: Sat, 16 Jun 2018 07:12:50 +0200
>>
>> In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
>> echo area displays "true: finished".
>>
>> In master emacs -Q, doing the same gives you no visible feedback any
>> more. A message is logged in *Messages*, but it seems to be dismissed
>> immediately.
>
> Daniel, this seems to be due to your recent changes in keyboard.c. If
> I make the change below, which reverts a small part of your changes,
> the problem is gone:
>
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 5409918..76097e8 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt,
> /* These are no-ops the first time through, but if we restart, they
> revert the echo area and this_command_keys to their original state. */
> this_command_key_count = keys_start;
> - if (INTERACTIVE && is_replay)
> + if (INTERACTIVE && t < mock_input)
> echo_truncate (echo_start);
> is_replay = true;
Yep. You're right. I'll bring us back to the old logic here.
I just worry that the "t < mock_input" condition is wrong in the case
where we use a function key map to rewrite an input to nothing, but
maybe the improved last_nonmenu_event tracking will fix that class of
problem by itself.
next prev parent reply other threads:[~2018-06-16 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 5:12 bug#31855: 27.0.50; Async shell command finished message not visible any more Michael Heerdegen
2018-06-16 8:48 ` Eli Zaretskii
2018-06-16 21:17 ` Daniel Colascione [this message]
2018-06-17 4:48 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed45c812-91a1-f46d-3a5d-cfe0803db793@dancol.org \
--to=dancol@dancol.org \
--cc=31855@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.