From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Fri, 15 Apr 2016 04:01:02 +0300 Message-ID: References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1460682144 4497 80.91.229.3 (15 Apr 2016 01:02:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2016 01:02:24 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 15 03:02:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqs9C-0004ch-Um for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Apr 2016 03:02:11 +0200 Original-Received: from localhost ([::1]:50407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqs9B-0005Wi-Vt for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2016 21:02:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqs97-0005TM-KN for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqs94-0004hC-Do for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:02:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqs94-0004h8-As for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aqs94-0007B1-4z for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Apr 2016 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.146068207227528 (code B ref 20637); Fri, 15 Apr 2016 01:02:02 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 01:01:12 +0000 Original-Received: from localhost ([127.0.0.1]:35854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqs8G-00079w-8l for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:01:12 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:35307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqs8E-00079j-GR for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 21:01:10 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id a140so2094738wma.2 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 18:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=05WwOc61BDv9/abL/1cDaZ3cFjxI38pUJS6o6/7BMik=; b=FSFgIrZ0av8Irt9xYIcjilvFGQUA94QgYyp5sfymtDLtcbSZAEvERBryTnQxoggzpo kWgrvxHNRKM6CmgYyVoOzpod8czW+nXph+IvvMdKILqTMXTMey20P37AVr0uoi19pSR8 8NUNJuZ3YENWBzMgAxm+ASjBj6+BTX65tH4t0lFmubRXMktslWETcl+u5hAUAsikGeJR pmPW8vxUD1DkrfoGf+USQDo2STM5nNciBzx8K6yO1jqQJgPWLS1SMpyWUvQPQ0qs6DPh RkPET/A8lGhC07eTdd8evqSqMjYzriLmdaUFctxFH4fr7BgAMFPsRpW2u/8NoWHQ5fA4 3QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=05WwOc61BDv9/abL/1cDaZ3cFjxI38pUJS6o6/7BMik=; b=MeWYd3RXjk6dE/VKcGvu08HxZufRsDx1k1yHVM8axQBeDHHjI18/zAmvEHnqtX2lRW WGVly8BRpEYjN0X3kmxIgXVNQ3ihGaQvG8XKNgCkmxuE+xHpllg+iKr758gAZh5UFPfF fZROgg+7bJptcIoZpsQjh3C9A3RpAVMPouJ/uePxWhupTJWtBeJz3edPQFz8naewYEu0 49knJcrcP0BWgUHX71SZ6fsUeqZFGkkInRBUSaZCLKFsh9rpSFnhebt/DfsxBl70BM2K fd7giuB267N4V8IU3mkB9wFkeW5J9zS+E2w9aswAchs8KyxS3JSjo8z2khxbbMm1EMFR y1vg== X-Gm-Message-State: AOPr4FVHjuNSmCodtjaLOhRkemXREXX2qxct4RaNJHi/nNqTw58O/d/O7M6z5uRn7ch6Ag== X-Received: by 10.194.94.231 with SMTP id df7mr15460701wjb.10.1460682064808; Thu, 14 Apr 2016 18:01:04 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id lh1sm46425881wjb.20.2016.04.14.18.01.03 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 18:01:04 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87h9f4ghzg.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116481 Archived-At: On 04/14/2016 09:31 PM, Michael Albinus wrote: > Yes. I hope we could use more file properties caches. To be investigated. OK, that could be a fine solution to the problem of vc-registered's slowness, but it adds complexity. So I'm still in favor of equating `unregistered' with nil, . > And as said already several times, if > we would document vc-* functions in the manual, it would allow us to > have a more global view on proposed changes. I disagree. The manual is the documentation for the users, to explain in depth, give examples, et cetera. The docstrings and VC's internal documentation have to stand on their own. It would be silly if the difference between `vc-backend' and `vc-responsible-backend' were to only be explained in the manual, but not in the docstrings. That would also be unfair to people such as myself who prefer to consult the latter. So, do you need anything from me in this area? E.g., feel free to give a list of docstrings that seem insufficient to you, together with what you feel they are missing. > I trust you that you have > all involved interfaces in your mind. I haven't, and I would like to see > how an interface change compares to the other interfaces. I don't really know everything about VC, I just have some recollections about dealing with it, as well as experience writing a third-party package depending on VC's API. To get an opinion about the current bug report, I still had to dig into the code and investigate, look at the commit history, search for call occurrences, etc. > But you have spoken about > design decisions in the past (for example whether unregistered files > could be an argument), which I believe is not documented. BTW, we've mentioned it before when fixing my old bug report about VC using too many process calls (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11757#77). It may not have even been a deliberate design decision, but it's the way `vc-state' is used. Which, in turn, allows backend implementations to be sloppy in the cases that are (almost?) never exercised. > And at least for me the "global view" about vc-* functions is missing, > and how they are related. I usually tease that kind of information out by reading the source code. Is there anything in particular I could help add to your understanding of the "global view"? > Yep. Pls test my patch, and confirm whether it is sufficient. Same for > Glenn, if possible. I would like to close this bug then, removing a > release blocker for Emacs 25.1. It must fix this bug, since it reverts to the old code, and testing Glenn's example from the description confirms as much. So I think it can be closed, and the discussion should move to emacs-devel.