From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Mon, 12 Dec 2022 23:27:31 +0000 Message-ID: References: <83iliiv0yv.fsf@gnu.org> <87h6y0nt97.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , Stefan Monnier , 59956@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 00:28:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4sDf-0004sO-98 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 00:28:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4sDL-0003Ux-R7; Mon, 12 Dec 2022 18:28:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4sDK-0003Uf-BA for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4sDK-000427-3N for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4sDJ-0005uo-RZ for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 23:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167088765522727 (code B ref 59956); Mon, 12 Dec 2022 23:28:01 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 12 Dec 2022 23:27:35 +0000 Original-Received: from localhost ([127.0.0.1]:56188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4sCs-0005uV-VC for submit@debbugs.gnu.org; Mon, 12 Dec 2022 18:27:35 -0500 Original-Received: from heytings.org ([95.142.160.155]:55608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4sCr-0005uP-9e for 59956@debbugs.gnu.org; Mon, 12 Dec 2022 18:27:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670887651; bh=22k0vk5BlimCwZCq8Fo2ka6dMrqdUcJQp9k5gRvCOpc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=oOVKbobYSfkuN4HfrpV30OMeFz845pszfNbTSH8zWpfII/u7AWub6AGFWWaHssXZt n+87+UHUQ2wGYsFiJN+73RhMPVAgfOWVK/L7nusTILJkMUVcx3XLLRYohPtN+0AsXh sqYNwEy4VKX9/ntNKUFF4KHxJLt9m5bkjqENEvd8H256/ksuhXX7TDhLf7M1Fx5JYm SnejOuLW3mHJlJcgI0GVCg08xTstJ4yZBPE/cpdnpT0q/6FJ0r2GmYxLdItm6ELdxp nuddjQeRgVeGa7Dww/bXr0nhlwE3/QgPDkz2WGwLRPURxzDczop0c6tzq0faxnvp6n wGnozCFwgLbEA== In-Reply-To: <87h6y0nt97.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250775 Archived-At: >>>> Starting from "emacs -Q -f -eshell", type "echo $exec-path " (note >>>> the trailing space), and then hit TAB. The result is this error: >>>> >>>> pcomplete-match: Wrong type argument: stringp, ("/usr/bin" ...) >>>> >>>> This is a regression from Emacs 28, and it looks like it's due to >>>> 'pcomplete-here-using-help' assuming that all the pcomplete args are >>>> strings. However, 'exec-path' is a list (and Eshell reports it this >>>> way to pcomplete), so the completion fails. I think all that's >>>> necessary is checking that the pcomplete args are strings in >>>> 'pcomplete-here-using-help', but I know next to nothing about >>>> pcomplete... >>> >>> Adding Stefan, who should know more about pcomplete. >>> >>> Stefan, any suggestions? >> >> I'm still not Stefan, but this bug is fixed by the attached patch. > > This is not a fix to the problem, in my opinion. Just take any other > command with a pcomplete rule, say "cvs $exec-path SPC TAB" and you will > see the same problem. > Agreed, it's not a proper fix for that bug.