From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33487: [PATCH] bug of ruby-forward-sexp and ruby-backward-sexp Date: Tue, 11 Dec 2018 03:18:37 +0200 Message-ID: References: <7c08da24-8c8d-4021-8456-acbe60ec3767@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544491599 16825 195.159.176.226 (11 Dec 2018 01:26:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Dec 2018 01:26:39 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 To: Nobuyoshi Nakada , 33487-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 11 02:26:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWWok-0004II-DU for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Dec 2018 02:26:34 +0100 Original-Received: from localhost ([::1]:35403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWWqr-0006k7-1N for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2018 20:28:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWWqh-0006iS-BZ for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 20:28:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWWhS-0002xQ-GG for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 20:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gWWhS-0002wo-BA for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 20:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gWWhS-0001ZX-77 for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 20:19:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Dec 2018 01:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33487 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 33487@debbugs.gnu.org, dgutov@yandex.ru, nobu@ruby-lang.org Original-Received: via spool by 33487-done@debbugs.gnu.org id=D33487.15444911306019 (code D ref 33487); Tue, 11 Dec 2018 01:19:01 +0000 Original-Received: (at 33487-done) by debbugs.gnu.org; 11 Dec 2018 01:18:50 +0000 Original-Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWWhF-0001Z0-TY for submit@debbugs.gnu.org; Mon, 10 Dec 2018 20:18:50 -0500 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:46693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWWhC-0001Yk-LK for 33487-done@debbugs.gnu.org; Mon, 10 Dec 2018 20:18:48 -0500 Original-Received: by mail-wr1-f68.google.com with SMTP id l9so12339849wrt.13 for <33487-done@debbugs.gnu.org>; Mon, 10 Dec 2018 17:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pG+gKZwibowlKtH+wN4sL+p028sjAJ0yxoK2apREs3U=; b=sK6QK/xvfAAvpx+dkx7PQe9GgK3LNu2vJONgvx/5qFZs+8p6XspiVROuGPD9TUi9Zx ukJr5ZFA0eW2XnMwn/MJ9j2SQVe7dVjI/RpS26Yq9KaNDg9cWBAbzPjP6QsKd8TyEK6c S2WvpaEB3dS/cKH5yPI5gyQsKgK/4YIPypKWTOFfgdtg7Z/VVP0dEU1+APdg4Eeww6Y8 OHN5ronHMpNtN2hvJdVyo1+o5v0T3/I4F4+sw3sF+DcCAu69VJ7LJ1M0vP15aBmXmS4s jpmFTSlUG+6J5JTWEGhUVwgeA8ug1AzAH6ogD7t8UnErol5nxk0Vb7MtGbt+QUdNyDoo CRWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pG+gKZwibowlKtH+wN4sL+p028sjAJ0yxoK2apREs3U=; b=fkdDHRRA6sshiX8bWABV1Lf2a2LhoHzAsP8AsIY8wuVCNb2oEwdQkgQKFWuRlUl3G/ UXzY7HW2bgvn5rtsxBgPYnWo6lPi8dhIcKASL/9eVnk1p8Vt2pKUM4x7buWizvZmlta8 iJbcsN0urv2Dp63Nq/axjqrCsuM/FGqKjIEdJpyZaxLtLq4cDWPoEWKjUuluTz4LC+Yh V+y8x/qlOiKKrevBDhTvqC84RX6+Z/lDPQrKTJrP3HCrNmd0yPZk+4ta2R3HVT8iq0lB idgClL3Hi5cwMIuWA31wA8pLAzLHH2lb6I5TMYjixD1CmsBJDE1qMYyvCOyVLxujTxIQ u5JQ== X-Gm-Message-State: AA+aEWZHWgZos4h8cDqbedi+ZkCaj+ST2JpZQzB9PtdpUeBnTb31Tnl6 N2odrv38PR7dXFQJCnidPlSFEB/R X-Google-Smtp-Source: AFSGD/XWbeTOE8XIFuA1d58UssuWhBHKtJk8wq6MdYHSZF7QY7QV+dRcrYWnksg57NAib15N60J6sQ== X-Received: by 2002:adf:9bda:: with SMTP id e26mr11150562wrc.295.1544491120405; Mon, 10 Dec 2018 17:18:40 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p14sm9037195wrt.37.2018.12.10.17.18.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 17:18:39 -0800 (PST) In-Reply-To: <7c08da24-8c8d-4021-8456-acbe60ec3767@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153329 Archived-At: Version: 27.0 Hi Nobuyoshi, On 24.11.2018 18:20, Nobuyoshi Nakada wrote: > With lisp/progmodes/ruby-mode.el in Emacs 26.1, `ruby-forward-sexp' and > `ruby-backward-sexp' cannot work with block arguments which end without > argument name. > > i.e., > >     proc do |a,| > >     end > > > or > > >     proc do |a,*| > >     end > > > The reason is that `smie-default-forward-token' and > `smie-default-backward-token' just scan punctuation and the closing bar > together, and return ",|" or ",*|" in the above examples, then the > "opening-|" cannot find "matching closing-|". > > The following patch trims the token and adjust the cursor position in > those cases. Thank you for the patch. I've simplified it a little: regexps smaller, tests shorter, and removed a few of the latter (seemed redundant), and pushed. Please let me know if there is anything amiss in the resulting patch: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3729a3f88fd7ce1d8a1a7f2ea61e8c4d05e954ab