From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level Date: Fri, 6 Sep 2013 11:56:45 -0700 (PDT) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1378493907 12417 80.91.229.3 (6 Sep 2013 18:58:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Sep 2013 18:58:27 +0000 (UTC) To: 15292@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 06 20:58:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VI1Eg-0005ik-6x for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Sep 2013 20:58:26 +0200 Original-Received: from localhost ([::1]:39439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1Ef-00063B-Ok for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Sep 2013 14:58:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1ET-0005x1-AA for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:58:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI1EJ-0000Fj-5i for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:58:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1EJ-0000Fe-1t for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VI1EI-0005QK-HD for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Sep 2013 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15292 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137849384720798 (code B ref -1); Fri, 06 Sep 2013 18:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Sep 2013 18:57:27 +0000 Original-Received: from localhost ([127.0.0.1]:44804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI1Dj-0005PN-3N for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34218) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI1Dg-0005P8-15 for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI1DQ-00087z-IN for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:18 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:36105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1DQ-00087n-Fb for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1DH-0005g9-TI for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI1D7-000860-A7 for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:56:59 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:19014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1D7-00085o-3c for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:56:49 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r86Iulgd011779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Sep 2013 18:56:47 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86Iujgf006946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 6 Sep 2013 18:56:46 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86Iuj0L008151 for ; Fri, 6 Sep 2013 18:56:45 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78069 Archived-At: Isearch now has quite a few commands that can be invoked during Isearch, using keys. None of these commands currently take care of the fact that they might get called at top level, e.g., with `isearch-mode' =3D nil. Some such commands, such as `isearch-help-for-help' should be callable outside of Isearch. Others, such as `isearch-repeat-forward', should not. For those that should not, an error should be raised, saying that the command is for use only in Isearch. For those that should be allowable outside of Isearch, the code should take care to DTRT when not in `isearch-mode': * wrt messages (mostly inhibit messages, esp. if they use `isearch-message-prefix' etc.) * wrt Isearch highlighting (they should not do any highlighting) * wrt calling `isearch-update' etc. (they should not do it) * wrt calling `exit-minibuffer' (they should not do it: no catch for throw) Some commands, such as `isearch-describe-bindings' and `isearch-highlight-regexp' can be used outside of Isearch with no change - they work well already. This includes even `isearch-edit-string', which can be called outside Isearch but which then continues in Isearch with no problem. Among the comands that might be useful, or at least allowable, outside of Isearch (dunno), but that might need some minor fixup are the following. They should not call `isearch-update' etc. * isearch-help-for-help * isearch-describe-key (should explicitly use `isearch-mode-map') * isearch-describe-mode * isearch-toggle-* Dunno whether there is any use for these commands outside Isearch: * isearch-cancel (moves point to last Isearch start) * isearch-abort In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-08-23 on ODIEONE Bzr revision: 113986 rgm@gnu.org-20130823185841-zoy6h1qk433ibrlf Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include'