From: Peter Oliver <p.d.oliver@mavit.org.uk>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 72120@debbugs.gnu.org
Subject: bug#72120: [PATCH] Fix intermittent failure of dired-test-bug27243-02
Date: Fri, 26 Jul 2024 13:40:53 +0100 (BST) [thread overview]
Message-ID: <eb963574-7f79-0c03-20d9-edbecb02aa6e@mavit.org.uk> (raw)
In-Reply-To: <CADwFkm=AFcU55RrQb5ejhHKfcD=xA-5xT4vp2c6aTiJLHYFLaA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Mon, 15 Jul 2024, Stefan Kangas wrote:
> Peter Oliver <p.d.oliver@mavit.org.uk> writes:
>
>> A patch is attached which I believe may fix an intermittent failure of
>> test dired-test-bug27243-02.
>
> Thanks, installed on emacs-30 as commit a7b68c25640.
I’m afraid the intermittent failure came back. Attached is a second attempt to fix it.
--
Peter Oliver
[-- Attachment #2: Type: text/plain, Size: 1627 bytes --]
From e0f0549ac6766ab565dbd581098b96792a807727 Mon Sep 17 00:00:00 2001
From: Peter Oliver <git@mavit.org.uk>
Date: Wed, 17 Jul 2024 00:06:02 +0100
Subject: [PATCH 4/4] Try harder to stabalise dired-test-bug27243-02
* test/lisp/dired-tests.el (dired-test-bug27243-02): Don't rely on the
expected point, since columns will move if the size of the parent directory
changes order of magnitude.
---
test/lisp/dired-tests.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el
index ea47043dfc5..6078e99e13c 100644
--- a/test/lisp/dired-tests.el
+++ b/test/lisp/dired-tests.el
@@ -190,7 +190,6 @@ dired-test-bug27243-02
"Test for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27243#28 ."
(ert-with-temp-directory test-dir
(let ((dired-auto-revert-buffer t)
- (dired-free-space nil)
buffers)
;; On MS-Windows, get rid of 8+3 short names in test-dir, if the
;; corresponding long file names exist, otherwise such names trip
@@ -216,7 +215,9 @@ dired-test-bug27243-02
;; Sanity check: point should now be back on the subdirectory.
(should (eq (point) pt1))
(push (dired test-dir) buffers)
- (should (eq (point) pt1)))
+ (should (equal (dired-file-name-at-point)
+ (concat (file-name-as-directory test-dir)
+ (file-name-as-directory "test-subdir")))))
(dolist (buf buffers)
(when (buffer-live-p buf) (kill-buffer buf)))))))
--
2.45.2
prev parent reply other threads:[~2024-07-26 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:12 bug#72120: [PATCH] Fix intermittent failure of dired-test-bug27243-02 Peter Oliver
2024-07-15 21:25 ` Stefan Kangas
2024-07-26 12:40 ` Peter Oliver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb963574-7f79-0c03-20d9-edbecb02aa6e@mavit.org.uk \
--to=p.d.oliver@mavit.org.uk \
--cc=72120@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.