From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [RFE] Migration to gitlab Date: Tue, 19 Mar 2019 02:52:17 +0200 Message-ID: References: <1552789070.5272.1@yandex.ru> <1552791707.5272.2@yandex.ru> <1552793646.5272.3@yandex.ru> <1552821396.21432.0@yandex.ru> <83imwhwf4x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206506"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: theophilusx@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii , Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 01:52:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h62zl-000rbs-CR for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2019 01:52:45 +0100 Original-Received: from localhost ([127.0.0.1]:49605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h62zk-0006YD-CR for ged-emacs-devel@m.gmane.org; Mon, 18 Mar 2019 20:52:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h62ze-0006Y5-B0 for emacs-devel@gnu.org; Mon, 18 Mar 2019 20:52:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h62zc-000334-Ei for emacs-devel@gnu.org; Mon, 18 Mar 2019 20:52:37 -0400 Original-Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]:42363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h62zT-0002pu-BL; Mon, 18 Mar 2019 20:52:33 -0400 Original-Received: by mail-lj1-x243.google.com with SMTP id v22so9996099lje.9; Mon, 18 Mar 2019 17:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HzLkW5MMeQl9hsRzmgsjj2LklJNz+tJznbGXFEwAbtc=; b=LDw9DzFIYuzY1oCG8m11QrM/aF3YJSXc2iC/0gSHUouJuP/dVWMYBWXPlTS8I8HXuZ tYpZglM9UCkyg9vQ9lsDl9Qx15Z3l9x+FVnqSry+bGFGYN9PKsfajsbbNyFvAZFWqcgM fYKu3xRcuG/XJtzqwRIS7pYNXJZezibFVU08s3qIrX7Rf9uml2lvfHQqH7DSP3zeKg69 9Rx7USpZZ5EMcFEPReOFm8xWwuKF6YMho14YAYQd8Nsiel3RVheIE7ao2ioupfDnq5Rx 9CKYPBKtXQROdYKm4B+OZo7lmrQtI11j1gLflOmiqsNNb6LEZmxgK1Z2HEI2CzX0QlWf 3NWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HzLkW5MMeQl9hsRzmgsjj2LklJNz+tJznbGXFEwAbtc=; b=QF2Iqn6k8pMXn7eMwifQLNefVtg2mKAcTCqQBQlM/ExE/rs5K1AAB2dQdkjLBvTAoV cNGday4dhvcZrSGBjMokaJ7Z5PyDY5WWDPP8b3HKhTOU4jO5gC9GUqwA7VBs9Xys5gCb 0zpJ5OxCTKZG1scgjm3u9PEM8Hu0UfqEz3PAB5U5JocRgauD4RN3Ely19pF1tqKC9nO0 iN1+/qtVTKY8BZ0XXMNgT5bCVHEQRKWu3vSF84l2LkfzILTpZhqxwrVAsjelqrcJNKGh dwlSwcfVlxoNL92gvoaDAxUHShdhloWMaKSjQYNsmT7kmhGyyzho4OOBop/OWEAlD6fO 8AMg== X-Gm-Message-State: APjAAAUGj0pxCwbRSGgArA6JSd1gWGFo41YnjIUuze1WcgVKnsOkiqFo lkgSLxIyt+gmkJxWKsKz/Y5rb4pN X-Google-Smtp-Source: APXvYqx4dNXYrKxmSTnUvQ5Fn9xaxaRHQLuRJeXDL6lOj4tcZ6Li8zN408UHDdEL/F3V6/FiEq1euQ== X-Received: by 2002:a2e:9655:: with SMTP id z21mr10179574ljh.60.1552956740507; Mon, 18 Mar 2019 17:52:20 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id f19sm2303049lfk.69.2019.03.18.17.52.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 17:52:19 -0700 (PDT) In-Reply-To: <83imwhwf4x.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234347 Archived-At: On 17.03.2019 20:05, Eli Zaretskii wrote: >> savannah.gnu.org looks like a news site > > Are you sure you are looking at the right page? You should be looking > here: > > https://savannah.gnu.org/projects/emacs I can't help but feel that the mentions of Savannah in this thread are disingenuous. After registering there, adding an ssh key and sending the membership request for the emacs project, I never went back there, or used it for anything else. This is, I suspect, the case for many other contributors as well. So since Savannah's role is very minor, I wouldn't say we need to do anything with it. Maybe Emacs' gitlab installation will be the place to add the ssh keys, though. >> I've just read a bit about that. I might be missing some nuances of the >> process, but right now I don't see how using merge requests vs emails >> could interfere. > > It doesn't interfere, but it slows down the process for new > contributors, so doing this stuff quickly is no longer an attainable > goal. Wouldn't the said contributors still be able to submit patches over email anyway? On the other hand, the CI could check all the included commits in a PR for their authors and the copyright assignments of each. And GitLab would show that this particular check failed, which could be more accessible for a contributor than reading up on patch submission conditions in the documentation. > Sending patches via email is only one requirement. There are other > requirements peculiar to Emacs, which will not go away if we switch to > another patch submitting system. Some of these requirements, each and > every one of them flagged at some point as an obstacle for newcomers: > > . code submissions should include documentation > . commit log messages should be formatted in a certain way > . bug numbers should be referenced in log messages > . US English conventions in writing comments and documentation > (spelling, two spaces between sentences, etc.) > . we require copyright assignments for accepting changesets larger > than about 15 original source lines > . we have peculiar rules regarding the branch were certain changes > should be pushed (affects the branch against which contributors > should prepare patches) > . very elaborate coding and documenting conventions (their > description takes around 900 lines in the ELisp manual) At least some of these checks could be automated on a CI. And the author of a random PR would get an overview of its compliance automatically. So the closer the CI is to Emacs's home page, and to patch submission process, the easier it might be for a new contributor to receive automatic feedback on their work. All of this should be prepended with the work "potentially", but still. Gitlab has the ability to improve the experience of both contributors and the maintainers, if we make use of the tools it offers.