From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Fri, 11 Sep 2020 09:53:29 +0200 Message-ID: References: <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <17a425a3-7b6e-56bc-40a3-35ac78fdaa6a@gmx.at> <56ee5ed9-fd85-b5c3-6aba-d51332398f03@cornell.edu> <818f2053-a996-7ade-c1cf-6592b6d2cde5@gmx.at> <4869c79f-2f3b-cafb-0459-c6f39f9a6bd5@cornell.edu> <3cea3f08-d87c-03a0-4b0b-b54f3ea63149@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, Noam Postavsky To: Ken Brown , Dani Moncayo , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 11 14:32:40 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGiEJ-0002J7-GQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Sep 2020 14:32:39 +0200 Original-Received: from localhost ([::1]:43404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGiEI-0003DD-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Sep 2020 08:32:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGiDi-0003D0-VL for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 08:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGiDi-0000xg-Lu for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 08:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGiDi-0006PZ-JN for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2020 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159982749824614 (code B ref 25542); Fri, 11 Sep 2020 12:32:02 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 11 Sep 2020 12:31:38 +0000 Original-Received: from localhost ([127.0.0.1]:42827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGiDJ-0006Ov-Mn for submit@debbugs.gnu.org; Fri, 11 Sep 2020 08:31:37 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:38611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGiDH-0006Oi-2b for 25542@debbugs.gnu.org; Fri, 11 Sep 2020 08:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599827463; bh=BRhckQ2NOm2al0YZHX+bmJook7U16HvcmQdO73PtwHU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=gO4plX9A+cfiXEQP7FekPPre48LmiNc1gsyrA/R0Xr86kizmkZmsjwbjfA8cZ0rW0 +MgSAVX5m4HDAdFnYoFfKEV51po0yU3ghSLkdl/rDITXCvIdvpr6i24sDDsK+OEddZ kzQl6Bg68Og/iVMAypCN+Ljf8Ez5/qVSAeYAAbHs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.223]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWRVh-1k0OQH3bfH-00Xtuz; Fri, 11 Sep 2020 14:31:02 +0200 In-Reply-To: <3cea3f08-d87c-03a0-4b0b-b54f3ea63149@cornell.edu> Content-Language: en-US X-Provags-ID: V03:K1:0dEx3fURMeyR1UUJ8lEn6I4fMO/SrPuNL196PJ1a1ApHmmrfORx hdlA6NmvejHJnWcEOsZCrBZrzne3FqOguN35eFjTOUiJIxUsw18FljP0wLEZ2phcRQLc1w3 b4wpVI7Pvsk77o4VQD5+HayMtQL8VlYJ2lLWFNVft46QWWhJYjR2TcdMTT8vrCPr2nZFfF+ gByBvu4SAlPvMh7UBjYTQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:JpDiHbBQrJ4=:D0pLmk9eBOGbSOKjaI6cxl oWKBgs9UouqrCQsCkSFT4poCnrLzjvacZfyWElmesoVp3oTuiG3uE5Mai5tO3m1cGgelE4/Yi LVm/e46QbBw4kc1cvbgyIDGWRju9ktRmmwSSdH+Q5AxhblBcTSTLynaVEpBeHTFbpsi35wJAC M9TV911NZUzaPdW5urZ3oYjel202hQdFks8JL3GMuvw++UglDF4kyHvJl8UTf00lX4Y6VEKDl E/Bhyx/Mk8ZiDXEnqtZHYmH1zFuC7fwmClcmvhOwos/iKPk11UvoBebzx6FKyUoB4g6W9txgb r1zjDlMnuOe1FnulvqhT9gTqw2XpNh/ERUFPnze63L8B8tsGqDmLWRRqIH4VZbpcwc4qFhgfk OxC3VEpotonaAmYRSDzM+TR/fofFEPVge6ToIzehMr7fSVCdrFHt/I2cRx6SZ9MOdnvn5bEKz qQLfiAhwGRU5QN4JbHAyf7HNpLduYL0YtmXSxWgb4pUKGRq9jPLM56aGRXsQBYaAzIzYqlA3m DLLMtbUBjrsGtkZPmZ6uL/IJGS4KdkcGEaoKktqbL9T/TnNXfRIsEeARxLMSKWV6ppoLKnsoE JzyPC69lIW5VqpSvRI5CHYZvkw986RuuDHnlrliGQxY4vrsusdplQXgiWQvS0+GA8Yo7SQoQb INVwjcCe+wZX4SqN0e4y+z0aH0SRBAIxsyoFUdcoYHD2XXjSJtckx3toyQVaXDirkkIeHvhoe p3sJH6TffJuSKx+tu4JaxJavqPIjWx67NvsNuuU7fCcPGieBLw0YWFaini4YHPfgtaeBZvCt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187824 Archived-At: >> ... after >> maximizing the frame with the mouse, the value of >> >> (frame-parameter nil 'fullscreen) >> >> is nil. Correct? > > Yes. > >> And what is its value if, instead, you maximize the >> frame via 'toggle-frame-maximized'? > > maximized. Mixing frame resizing triggered by Emacs commands and external tools is tricky to handle. >> Apparently some check _is_ needed (why?) so probably >> using >> >> if (x < 0 || y < 0) >> store_frame_param (f, Qfullscreen, Qmaximized); >> >> instead will fix it. Can you try that (as I said elsewhere it will then >> fail for borderless, maximized frames)? > > Yes, that does fix it. So we'll probably have to use that. Can you install it? > I haven't tried to test anything involving borderless frames. If you (set-frame-parameter nil 'undecorated t) and maximize the frame via some Windows (Aero, IIRC) command, what does (frame-parameter nil 'fullscreen) report? With and without the && ~> || change. And it would still be interesting to understand your earlier finding, namely that If I make this change and follow Dani's recipe from the original bug report, the second F11 press doesn't restore the previous state. Instead, the frame appears to get slightly smaller for an instant and then immediately reverts to fullscreen mode. That second F11 should set the 'fullscreen parameter to 'maximized so I fail to see how a subsequent action can restore it to 'fullboth. In retrospect, that /* Windows can send us a SIZE_MAXIMIZED message even when fullscreen is fullboth .... comment apparently matches your experience now but I cannot even recall based on what experience I added it back then. Thanks, martin