From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt Newsgroups: gmane.emacs.devel Subject: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Date: Sun, 24 Sep 2023 20:39:21 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21712"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Cc: Jim Porter To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 24 20:40:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkU1y-0005Sh-K2 for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Sep 2023 20:40:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkU1F-0007Ud-LV; Sun, 24 Sep 2023 14:39:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkU1D-0007UU-Kj for emacs-devel@gnu.org; Sun, 24 Sep 2023 14:39:47 -0400 Original-Received: from mr4.vodafonemail.de ([145.253.228.164]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkU1B-0002fE-B4 for emacs-devel@gnu.org; Sun, 24 Sep 2023 14:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1695580772; bh=AsPjMMVHKPO0V3YreqlS2FiyNivlV58nDbL6FUsdExc=; h=Message-ID:Date:User-Agent:Content-Language:From:To:Subject: Content-Type:From; b=qVE+8ew8vJSxL9QKDLRnnA2j2TljlNfnxAshfusF7qtl6396Jt7MBKstipR+q3310 6tajsniFRr/oZP+0Y/zernVKLVDlYhx9dtw2BJhZEg5TFD3qzL6gcDd6FJLi/rAovP ywjdoQdH7kx95wJBIYD7ampa/klXu5wuVzxmphQ0= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4RtvtX5KDtz1xyx; Sun, 24 Sep 2023 18:39:32 +0000 (UTC) Original-Received: from [192.168.0.74] (p54a6df5e.dip0.t-ipconnect.de [84.166.223.94]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4RtvtP2d0kz9ryT; Sun, 24 Sep 2023 18:39:22 +0000 (UTC) Content-Language: de-DE-frami, en-US X-purgate-type: clean X-purgate: clean X-purgate-size: 3492 X-purgate-ID: 155817::1695580768-67FEEE22-FAEB5452/0/0 Received-SPF: pass client-ip=145.253.228.164; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr4.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311026 Archived-At: Not sure whether anybody has seen or reported already: Approx. 1 of 5 executions of "make lisp/eshell/esh-proc-tests" fail for me like this: ------------------------- snip ------------------------- make[1]: Entering directory '/home/jschmidt/work/emacs-master/test' GEN lisp/eshell/esh-proc-tests.log Running 23 tests (2023-09-24 20:32:11+0200, selector `(not (tag :unstable))') Loading em-alias... Loading em-banner... Loading em-basic... Loading em-cmpl... Loading em-extpipe... Loading em-glob... Loading em-hist... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... Loading em-unix... passed 1/23 esh-proc-test/exit-status/failure (0.117111 sec) passed 2/23 esh-proc-test/exit-status/success (0.105469 sec) passed 3/23 esh-proc-test/exit-status/with-stderr-pipe (0.105925 sec) passed 4/23 esh-proc-test/kill-pipeline (0.108324 sec) passed 5/23 esh-proc-test/kill-pipeline-head (0.108148 sec) passed 6/23 esh-proc-test/kill-process/background-prompt (0.005315 sec) [sleep]+ Done (/usr/bin/sleep 100) passed 7/23 esh-proc-test/kill-process/foreground-only (0.207743 sec) passed 8/23 esh-proc-test/kill-process/redirect-message (0.004864 sec) Tramp: Sending command `exec sh -i' Tramp: Found remote shell prompt on `sappc2' Tramp: Sending command `exec sh -i' Tramp: Found remote shell prompt on `sappc2' passed 9/23 esh-proc-test/output/remote-redirect (0.157058 sec) passed 10/23 esh-proc-test/output/stderr-to-buffer (0.106075 sec) passed 11/23 esh-proc-test/output/stdout-and-stderr-to-buffer (0.105911 sec) passed 12/23 esh-proc-test/output/stdout-to-buffer (0.105907 sec) passed 13/23 esh-proc-test/output/to-screen (0.105792 sec) passed 14/23 esh-proc-test/pipeline-connection-type/first (0.055700 sec) passed 15/23 esh-proc-test/pipeline-connection-type/last (0.056159 sec) make[1]: *** [Makefile:181: lisp/eshell/esh-proc-tests.log] Broken pipe make[1]: Leaving directory '/home/jschmidt/work/emacs-master/test' make: *** [Makefile:247: lisp/eshell/esh-proc-tests] Error 2 ------------------------- snip ------------------------- I bisected with ------------------------- snip ------------------------- #!/bin/bash make FAST=true -j8 bootstrap || exit 1 for (( i = 0; i < 30; i++ )); do ( cd test && make lisp/eshell/esh-proc-tests ) || exit 1 done exit 0 ------------------------- snip ------------------------- to ------------------------- snip ------------------------- 7e50861ca7ed3f620fe62ac6572f6e88b3600ece is the first bad commit commit 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Author: Jim Porter Date: Thu Sep 14 17:51:16 2023 -0700 ; Simplify how to use 'eshell-debug-command' Now, 'eshell-debug-command' works more like 'format-message', which is how we usually use it. * lisp/eshell/esh-util.el (eshell-always-debug-command): New function. (eshell-debug-command): Simplify. Update callers. lisp/eshell/esh-arg.el | 6 +++--- lisp/eshell/esh-cmd.el | 10 ++++++---- lisp/eshell/esh-proc.el | 41 +++++++++++++++++------------------------ lisp/eshell/esh-util.el | 26 +++++++++++++++++--------- 4 files changed, 43 insertions(+), 40 deletions(-) bisect run success ------------------------- snip ------------------------- Pls let me know whether I should open a separate bug for this.