From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51420: 29.0.50; [PATCH] Be more efficient when checking for a matching client or frame in server.el Date: Tue, 26 Oct 2021 13:18:05 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------87CF8A892F6B4C83F3090067" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34973"; mail-complaints-to="usenet@ciao.gmane.io" To: 51420@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 26 22:19:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfSud-0008vk-LE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 22:19:11 +0200 Original-Received: from localhost ([::1]:41752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfSub-0007dl-Hs for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 16:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfSuU-0007ac-SP for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfSuU-0003C0-KA for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfSuU-00053Q-EC for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163527949219356 (code B ref -1); Tue, 26 Oct 2021 20:19:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Oct 2021 20:18:12 +0000 Original-Received: from localhost ([127.0.0.1]:47630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfStf-000528-OF for submit@debbugs.gnu.org; Tue, 26 Oct 2021 16:18:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfStf-000521-4H for submit@debbugs.gnu.org; Tue, 26 Oct 2021 16:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfSte-0006o4-Js for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:18:10 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:37793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfStc-00035P-Gm for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:18:10 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id s136so643971pgs.4 for ; Tue, 26 Oct 2021 13:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:from:subject:message-id:date:mime-version:content-language; bh=ZbjtA/gZR9sbD+4G6zss16E+aYqFBwAnaH6pkU0mCbY=; b=pSoNQK79ZzdhHReJNnXYz9/BCsgFQCYHuMfFwYKq326X1eW7o2Oe++ujFS/sHJxmo7 5oWpXPFNiSvR3kwpGQcQg7Jwb8D92Cww58tW8Wk02ILsSzeMIGxiu/MFO525tjpqbptc DR6EzlTHyciLDYFJUFoH16bY8yTYKvvROJwaQB6FDHrsqjtb9mLWC5XMZCUJYk5oWpY1 OEmUm2T+Z5Rf6LctzLoGMoa1nu+QtRl8oF+XpLIp5I1gxx0G3WrLuWjwJSpqOg4qRaaD 29lPRqJSNGgFopJVYYgPQ/QWAB2pmwOs5tSXK72N/evejfz5efpb1zbkGdBcR6ixuQGD oxfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:from:subject:message-id:date:mime-version :content-language; bh=ZbjtA/gZR9sbD+4G6zss16E+aYqFBwAnaH6pkU0mCbY=; b=vd0cK9q6xOe5h7ReTiVzEFKhGR0PagrMt/VbFq0CSJ33teTC5sdQGEdWmFCYLNii1R JUGcNxYH8jcVPqD9Jy0JmKOMIwymGyOWlufo82ZTdcOFLuQRloJzaNN1qpqJtAdoi2I0 url4fdCUqlHd6R8ewEWfQs6yZlIozqSkvCqh+Ltbx9n5UZqz/uWdoNXQ8VfPJduMDjXE ezgg5UQHEcXC2Uin9tGDAzF7j2k62seXp2y29ompRn+Cb5Etm0MZE9gSkri8XvT/Qbh6 b1Au+X2z0YeBPzPhrp1h8dY/yQxBvO83HO60Yh77nQdXxI/AEskvZmehD5GdciYuSp2c YjFw== X-Gm-Message-State: AOAM532G661qw4Scb2UxVnsVJwn5jr2God3nOQ8YmjXUdKUDLTdqM7P+ GTjKDUUvw/iza7m/BiLlDXSlGNrTn/A= X-Google-Smtp-Source: ABdhPJyOmq+LUGJSrcj1pyihYOnTZZVm1gtbDRbR0EEvq442AA5aslKtBgJeXOVGs/O3EE36Ue7nzA== X-Received: by 2002:a65:6aa8:: with SMTP id x8mr20497247pgu.136.1635279486883; Tue, 26 Oct 2021 13:18:06 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u19sm9814131pfk.201.2021.10.26.13.18.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 13:18:06 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218404 Archived-At: This is a multi-part message in MIME format. --------------87CF8A892F6B4C83F3090067 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Attached is a patch to eliminate unnecessary checks for matching clients/frames in `server-handle-delete-frame' and `server-kill-emacs-query-function'. Previously, `server-handle-delete-frame' would iterate over all frames to check if there were any other frames associated with the current client. Now, it uses `seq-some' to stop iterating once it finds the first such frame. Similarly, `server-kill-emacs-query-function' used to iterate over all clients, and then all buffers for *each* client to check if there were any live buffers associated with any clients. Now, it uses a pair of calls to `seq-some' to stop iterating once it finds a live buffer from any client. I haven't benchmarked these changes since I hope the strategy of stopping iteration as soon as we can is uncontroversial. However, if you think it's important, I can try to generate some benchmarks. --------------87CF8A892F6B4C83F3090067 Content-Type: text/plain; charset=UTF-8; name="0001-Be-more-efficient-when-checking-for-a-matching-clien.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Be-more-efficient-when-checking-for-a-matching-clien.pa"; filename*1="tch" RnJvbSBmZGJhODhhZjkxNmQ4ZTQ3NzI1ZGE1YWVhNTJiYjJlZjQ1ZGEwOWVmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjYgT2N0IDIwMjEgMTM6MDQ6MDggLTA3MDAKU3ViamVjdDogW1BB VENIXSBCZSBtb3JlIGVmZmljaWVudCB3aGVuIGNoZWNraW5nIGZvciBhIG1hdGNoaW5nIGNs aWVudCBvcgogZnJhbWUgaW4gc2VydmVyLmVsCgpsaXNwL3NlcnZlci5lbCAoc2VydmVyLWhh bmRsZS1kZWxldGUtZnJhbWUpOiBVc2UgJ3NlcS1zb21lJyB0bwpkZXRlcm1pbmUgaWYgYW5v dGhlciBmcmFtZSBmb3IgdGhlIGN1cnJlbnQgY2xpZW50IGV4aXN0cy4KKHNlcnZlci1raWxs LWVtYWNzLXF1ZXJ5LWZ1bmN0aW9uKTogVXNlICdzZXEtc29tZScgdG8gZGV0ZXJtaW5lIGlm CmFub3RoZXIgbGl2ZSBjbGllbnQgZXhpc3RzLgotLS0KIGxpc3Avc2VydmVyLmVsIHwgMjQg KysrKysrKysrKysrLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9s aXNwL3NlcnZlci5lbAppbmRleCA1MzA2YTU0Nzc2Li40NzhlNTk1NzdlIDEwMDY0NAotLS0g YS9saXNwL3NlcnZlci5lbAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNDg1LDExICs0ODUs MTEgQEAgc2VydmVyLWhhbmRsZS1kZWxldGUtZnJhbWUKICAgICAod2hlbiAoYW5kIChmcmFt ZS1saXZlLXAgZnJhbWUpCiAJICAgICAgIHByb2MKIAkgICAgICAgOzsgU2VlIGlmIHRoaXMg aXMgdGhlIGxhc3QgZnJhbWUgZm9yIHRoaXMgY2xpZW50LgotCSAgICAgICAoPj0gMSAobGV0 ICgoZnJhbWUtbnVtIDApKQotCQkgICAgICAgKGRvbGlzdCAoZiAoZnJhbWUtbGlzdCkpCi0J CQkgKHdoZW4gKGVxIHByb2MgKGZyYW1lLXBhcmFtZXRlciBmICdjbGllbnQpKQotCQkJICAg KHNldHEgZnJhbWUtbnVtICgxKyBmcmFtZS1udW0pKSkpCi0JCSAgICAgICBmcmFtZS1udW0p KSkKKyAgICAgICAgICAgICAgIChub3QgKHNlcS1zb21lCisgICAgICAgICAgICAgICAgICAg ICAobGFtYmRhIChmKQorICAgICAgICAgICAgICAgICAgICAgICAoYW5kIChub3QgKGVxIGZy YW1lIGYpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcSBwcm9jIChmcmFtZS1w YXJhbWV0ZXIgZiAnY2xpZW50KSkpKQorICAgICAgICAgICAgICAgICAgICAgKGZyYW1lLWxp c3QpKSkKICAgICAgIChzZXJ2ZXItbG9nIChmb3JtYXQgInNlcnZlci1oYW5kbGUtZGVsZXRl LWZyYW1lLCBmcmFtZSAlcyIgZnJhbWUpIHByb2MpCiAgICAgICAoc2VydmVyLWRlbGV0ZS1j bGllbnQgcHJvYyAnbm9mcmFtZSkpKSkgOyBMZXQgZGVsZXRlLWZyYW1lIGRlbGV0ZSB0aGUg ZnJhbWUgbGF0ZXIuCiAKQEAgLTE1ODAsMTMgKzE1ODAsMTMgQEAgc2VydmVyLWRvbmUKICAg ICAoc2VydmVyLWJ1ZmZlci1kb25lIChjdXJyZW50LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNl cnZlci1raWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9uICgpCi0gICJBc2sgYmVmb3JlIGV4aXRp bmcgRW1hY3MgaWYgaXQgaGFzIGxpdmUgY2xpZW50cy4iCi0gIChvciAobm90IChsZXQgKGxp dmUtY2xpZW50KQotICAgICAgICAgICAgIChkb2xpc3QgKHByb2Mgc2VydmVyLWNsaWVudHMp Ci0gICAgICAgICAgICAgICAod2hlbiAobWVtcSB0IChtYXBjYXIgIydidWZmZXItbGl2ZS1w Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHByb2Nlc3MtZ2V0IHBy b2MgJ2J1ZmZlcnMpKSkKLSAgICAgICAgICAgICAgICAgKHNldHEgbGl2ZS1jbGllbnQgdCkp KQotICAgICAgICAgICAgIGxpdmUtY2xpZW50KSkKKyAgIkFzayBiZWZvcmUgZXhpdGluZyBF bWFjcyBpZiBpdCBoYXMgbGl2ZSBjbGllbnRzLgorQSBcImxpdmUgY2xpZW50XCIgaXMgYSBj bGllbnQgd2l0aCBhdCBsZWFzdCBvbmUgbGl2ZSBidWZmZXIKK2Fzc29jaWF0ZWQgd2l0aCBp dC4iCisgIChvciAobm90IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQorICAgICAgICAgICAg ICAgICAgICAgICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQorICAgICAg ICAgICAgICAgICAgICAgc2VydmVyLWNsaWVudHMpKQogICAgICAgKHllcy1vci1uby1wICJU aGlzIEVtYWNzIHNlc3Npb24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAiKSkpCiAKIChk ZWZ1biBzZXJ2ZXIta2lsbC1idWZmZXIgKCkKLS0gCjIuMjUuMQoK --------------87CF8A892F6B4C83F3090067--