From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sun, 10 Dec 2023 02:16:57 -0800 Message-ID: References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> <8334wbzv9g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: dmitry@gutov.dev, 67061@debbugs.gnu.org To: Eli Zaretskii , Denis Zubarev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 10 11:18:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCGst-0003bF-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Dec 2023 11:18:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCGsj-0002t6-1j; Sun, 10 Dec 2023 05:17:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCGsg-0002sp-0F for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 05:17:50 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCGse-00012J-BQ for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 05:17:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCGss-0006J0-CW for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 05:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Dec 2023 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.170220344124186 (code B ref 67061); Sun, 10 Dec 2023 10:18:02 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 10 Dec 2023 10:17:21 +0000 Original-Received: from localhost ([127.0.0.1]:49541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCGsC-0006I2-H1 for submit@debbugs.gnu.org; Sun, 10 Dec 2023 05:17:20 -0500 Original-Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:48631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCGsB-0006Ho-3s for 67061@debbugs.gnu.org; Sun, 10 Dec 2023 05:17:19 -0500 Original-Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6cda22140f2so2897726b3a.1 for <67061@debbugs.gnu.org>; Sun, 10 Dec 2023 02:17:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702203419; x=1702808219; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TXKJzzXBU3smevc98dlBS+HW3PpoSanvwYRrxdete6s=; b=UPe1avNsrp3BLzL5n6C9BATw49DKzoBhxY10nZ5IQ7IsnHuzofBP8aqRJEH2iEUa6V rFfC347prA0TR3wpHpFdsFXjt3ZWWLesH23IoHR9MKv1FRrjhAtZs6q/dIWfneXdj6mq 9ASw/vV7GbNRfDD3sJ21cjq29IcccGF85OV+nfx3DwsAC0oyoyaOVmzFC3OQCUjoUQfv 285VmgBiYF91QCb/KSq6UVPMQvJsMAWnBThIIF5ymYjjGc3fzMT9oJEwMSscGMG8XaRR ye9vPDSjsSlQZ2dE5tR+b/srJ+IXqe9rhiusOF69E6Hto3iP7KrNX0/g72TBMWEVvrmE NN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702203419; x=1702808219; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TXKJzzXBU3smevc98dlBS+HW3PpoSanvwYRrxdete6s=; b=UoMuDQzPYvg4fo6WEZLK43p4Q3BQS29kRX2kUPsf8qepL8C7fNIp7zpdz7BAuPRTi2 wxI5BaOL9lVxxCiwCpr1kZ2Y4+InV+pc/K4JR8CU7+Gw8mCxfpubxBXk729mqIPoiInp zjenB99ktO/Az9wyEXw+o9126reWEy96BUGzBFS0PR4ZqcBF2NZVpenhtrSqNiVdGY02 hx5q5A4OkeTPEPjyTzchl33DaUm5UxTN/bHo3xLAzKGno6EjdpAodzzdfGMb3xNY/G5o 8zBa25GQ+DSDqoJ6imy1a9gg1RazhxRHCtj519cMckSnsiijJiShrVKx2VvKv5n+mow8 Pymg== X-Gm-Message-State: AOJu0Yw+twOVgCZ+6cWKP5hhA6lg0GRYqLsgV+n01c4xSMgWcDNitAgi EmRkovs3kcTKqGftsvobu9g= X-Google-Smtp-Source: AGHT+IHbV8RtsF/f6mwa6Pbs9p5pk+rbY3HXrqqBX7dq1mAuou7tn7SmdMkDDaTBvW2P+K39kc9fnQ== X-Received: by 2002:a05:6a00:c85:b0:6ce:2731:a093 with SMTP id a5-20020a056a000c8500b006ce2731a093mr3502804pfv.66.1702203419175; Sun, 10 Dec 2023 02:16:59 -0800 (PST) Original-Received: from [192.168.1.7] (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k21-20020aa788d5000000b006ce75e0ef88sm4366551pff.78.2023.12.10.02.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 02:16:58 -0800 (PST) Content-Language: en-US In-Reply-To: <8334wbzv9g.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275910 Archived-At: On 12/8/23 11:32 PM, Eli Zaretskii wrote: >> From: Denis Zubarev >> Cc: "casouri@gmail.com" , >> "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> >> Date: Sat, 09 Dec 2023 03:39:39 +0300 >> >> I've moved tests to python-tests.el and added another fixes: >> >> assignment feature: >> `for var in range(3)` highlight var as font-lock-variable-name-face >> `var1[ii] = 1; t.var2[jj] = 2` highlight var1, var2 as font-lock-variable-name-face >> >> type feature: >> support nested optional types up to 3 level deep, for example `tuple[tuple, list[Lvl1 | Lvl2[Lvl3[Lvl3], >> Lvl2]]]` >> >> >> Summary of all changes in the patch: >> >> keyword feature: >> Add "is not" to the `python--treesit-keywords` list. >> >> assignment feature: >> For all examples, >> `for var in range(3)` >> `var1[ii] = 1; t.var2[jj] = 2` >> `var := 3` >> `var *= 3` >> highlight var as font-lock-variable-name-face >> >> string feature: >> Fix fontification of strings inside of f-strings interpolation, >> e.g. for f"beg {'nested'}" - 'nested' was not fontified as string. >> >> function feature: >> Do not override the face of builtin functions (all, bytes etc.) with >> the function call face >> >> type feature: >> Fontify built-ins (dict,list,etc.) as types when they are used in type hints. >> E.g. def func(v:dict[ list[ tuple[str] ], int | None] | None): > Thanks. > > Yuan, would you please chime in and provide your comments, if any? This should be the last bug report that I missed. I'll look at this tomorrow, promise promise. Yuan