From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lisa-asket@perso.be Newsgroups: gmane.emacs.help Subject: Run terminal command with output in current buffer Date: Fri, 16 Jul 2021 20:04:47 +0200 (CEST) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15562"; mail-complaints-to="usenet@ciao.gmane.io" To: monnier@iro.umontreal.ca, help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 16 20:05:36 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4SDQ-0003oW-GY for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 20:05:36 +0200 Original-Received: from localhost ([::1]:40890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4SDP-0003Vb-Fk for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 14:05:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4SCm-0003V8-2E for help-gnu-emacs@gnu.org; Fri, 16 Jul 2021 14:04:56 -0400 Original-Received: from msg-1.mailo.com ([213.182.54.11]:53026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4SCi-00029n-Sc for help-gnu-emacs@gnu.org; Fri, 16 Jul 2021 14:04:55 -0400 Original-Received: by www-7.mailo.com with http webmail; Fri, 16 Jul 2021 20:04:47 +0200 (CEST) X-EA-Auth: 5hDBTaoHlIv953stVIMslWRBPpQ33vhyEtsb29mIkBLuFu415sF2hMGbwOG1qRpbdZXIlKJURHV2V+F6iyQMFpotNY8Y+ml3 X-Priority: 3 X-Mailer: COMS/EA21.01/r20210601 In-Reply-To: Received-SPF: pass client-ip=213.182.54.11; envelope-from=lisa-asket@perso.be; helo=msg-1.mailo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:131766 Archived-At: Have attempted to call=C2=A0 `read-number` for `cmd-cnum` which gets emacs = to complain when I enter the value `8` for cmd-cnum. (cmd-cnum (read-number "-C ")) From: Stefan Monnier via Users list for the GNU Emacs text editor To: help-gnu-emacs@gnu.org Subject: Re: Run terminal command with output in current buffer Date: 16/07/2021 18:36:49 Europe/Paris > (let ( (cmd-excl (read-from-minibuffer "exclude: ")) > (cmd-incl (read-from-minibuffer "include: ")) > (cmd-cnum (read-from-minibuffer "cnum: ")) > (cmd-ptrn (read-from-minibuffer "pattern: ")) > (cmd-dpth (read-from-minibuffer "dpth: ")) > cmd ) > > (setq cmd-excl (concat " --exclude=3D\\*." cmd-excl)) > (setq cmd-incl (concat " --include=3D\\*." cmd-incl)) > (setq cmd-cnum (concat " -C " cmd-cnum)) > > (setq cmd (concat "grep -hir" cmd-excl cmd-incl > cmd-cnum " " cmd-ptrn " " cmd-dpth)) > (message "%s" cmd) > (shell-command cmd (current-buffer))) ) I'd probably write this as something like: (let* ((cmd-excl (concat "--exclude=3D*." (read-string "exclude: "))) (cmd-incl (concat "--include=3D*." (read-string "include: "))) (cmd-cnum (read-string "cnum: ")) (cmd-ptrn (read-string "pattern: ")) (cmd-dpth (read-string "dpth: ")) (cmd1 `("grep" "-hir" ,cmd-excl ,cmd-incl "-C" ,cmd-cnum ,cmd-ptrn)) (cmd (concat (mapconcat #'shell-quote-argument cmd1 " ") " " cmd-depth))) (message "%s %s" cmd) (shell-command cmd (current-buffer))) ) Note the use of `read-string` (`read-from-minibuffer` is a low-level function used to implement `read-string`, `read-number`, `read-buffer`, `completing-read`, ...) and the use of `shell-quote-argument` to deal with quoting those parts that need it. I presumed that "dpth" is supposed to be a glob pattern, which is the only place where you actually need the shell. You could also use `file-expand-wildcards` instead so you don't need a shell at all (and hence don't need `shell-quote-argument` either) and can use `call-process` instead of `shell-command` which stops you from worrying about what happens if the users put a `|`, `;`, `$(cmd)`, or other fun stuff in dpth. Stefan