bug#49075: (icomplete-vertical-mode 1) not taking effect

bug#49075: (icomplete-vertical-mode 1) not taking effect

[arvid-harnack]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

icomplete provides a convenient way to quickly select an element
among the possible completions in a minibuffer.

It is enabled by calling (icomplete-mode 1)

Recently, icomplete-vertical-mode was added.  But calling
(icomplete-vertical-mode 1) does not enable vertical completion,
unless one has called (icomplete-mode 1) first.

It is more natural to simply enable the mode by calling
(icomplete-vertical-mode 1), the same way as one enables
icomplete.  Either call (icomplete-mode 1) or
(icomplete-vertical-mode 1) to activate icamplete with the
appropriate style.


[-- Attachment #2: Type: text/html, Size: 614 bytes --]

bug#49075: (icomplete-vertical-mode 1) not taking effect

[Lars Ingebrigtsen]

arvid-harnack@lavache.com writes:

> Recently, icomplete-vertical-mode was added.  But calling
> (icomplete-vertical-mode 1) does not enable vertical completion,
> unless one has called (icomplete-mode 1) first.

I think that works as designed -- as the doc string says:

"Toggle vertical candidate display in `icomplete-mode' or `fido-mode'."

So the mode can't just switch on icomplete-mode by itself, because it
works two different modes.

Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49075: (icomplete-vertical-mode 1) not taking effect

[arvid-harnack]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

The argument is that the design is wrong.

Either icomplete-vertical-mode is a regular user option or icomplete-vertical-mode
should enable icomplete-mode too.

Many people would second this

Sincerely




From: Lars Ingebrigtsen <larsi@gnus.org>
To: arvid-harnack@lavache.com
Subject: bug#49075: (icomplete-vertical-mode 1) not taking effect
Date: 19/06/2021 15:34:58 Europe/Paris
Cc: 49075@debbugs.gnu.org

arvid-harnack@lavache.com writes:

> Recently, icomplete-vertical-mode was added. But calling
> (icomplete-vertical-mode 1) does not enable vertical completion,
> unless one has called (icomplete-mode 1) first.

I think that works as designed -- as the doc string says:

"Toggle vertical candidate display in `icomplete-mode' or `fido-mode'."

So the mode can't just switch on icomplete-mode by itself, because it
works two different modes.

Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no





[-- Attachment #2: Type: text/html, Size: 1362 bytes --]

bug#49075: (icomplete-vertical-mode 1) not taking effect

[Juri Linkov]

>>     > Recently, icomplete-vertical-mode was added. But calling
>>     > (icomplete-vertical-mode 1) does not enable vertical completion,
>>     > unless one has called (icomplete-mode 1) first.
>>
>>     I think that works as designed -- as the doc string says:
>>
>>     "Toggle vertical candidate display in `icomplete-mode' or `fido-mode'."
>>
>>     So the mode can't just switch on icomplete-mode by itself, because it
>>     works two different modes.
>
> Either icomplete-vertical-mode is a regular user option or icomplete-vertical-mode
> should enable icomplete-mode too.

This will require adding separate `fido-vertical-mode'.

bug#49075: (icomplete-vertical-mode 1) not taking effect

[arvid-harnack]

[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]

From: Juri Linkov <juri@linkov.net>
To: arvid-harnack@lavache.com
Subject: bug#49075: (icomplete-vertical-mode 1) not taking effect
Date: 20/06/2021 01:02:17 Europe/Paris
Cc: Lars Ingebrigtsen <larsi@gnus.org>;
   49075@debbugs.gnu.org

>>> > Recently, icomplete-vertical-mode was added. But calling
>>> > (icomplete-vertical-mode 1) does not enable vertical completion,
>>> > unless one has called (icomplete-mode 1) first.
>>>
>>> I think that works as designed -- as the doc string says:
>>>
>>> "Toggle vertical candidate display in `icomplete-mode' or `fido-mode'."
>>>
>>> So the mode can't just switch on icomplete-mode by itself, because it
>>> works two different modes.
>>
>> Either icomplete-vertical-mode is a regular user option or icomplete-vertical-mode
>> should enable icomplete-mode too.

>This will require adding separate `fido-vertical-mode'.





I have put forward an alternative plan



--------



Currently (icomplete-mode 1) is necessary.   And (icomplete-vertical-mode 1) is relatively new.
Emacs could ditch (icomplete-vertical-mode 1).

Instead, have a variable one can set (such functionality is already being done for completion-style).

Users can just put 

(icomplete-mode 1)
(setq icomplete-vertical 1)



--------



To disable, one could use 
(setq icomplete-vertical 0)    

Moreover one can use negative numbers
(setq icomplete-vertical -1) 



--------

To disable icomplete totally, use
(icomplete-mode 0)



--------

In summary there shall be no 



(icomplete-vertical-mode 1) 



or 



(icomplete-vertical-mode 0) 

--------


From: Juri Linkov <juri@linkov.net>
To: arvid-harnack@lavache.com
Subject: bug#49075: (icomplete-vertical-mode 1) not taking effect
Date: 20/06/2021 01:02:17 Europe/Paris
Cc: Lars Ingebrigtsen <larsi@gnus.org>;
   49075@debbugs.gnu.org

>> > Recently, icomplete-vertical-mode was added. But calling
>> > (icomplete-vertical-mode 1) does not enable vertical completion,
>> > unless one has called (icomplete-mode 1) first.
>>
>> I think that works as designed -- as the doc string says:
>>
>> "Toggle vertical candidate display in `icomplete-mode' or `fido-mode'."
>>
>> So the mode can't just switch on icomplete-mode by itself, because it
>> works two different modes.
>
> Either icomplete-vertical-mode is a regular user option or icomplete-vertical-mode
> should enable icomplete-mode too.

This will require adding separate `fido-vertical-mode'.





[-- Attachment #2: Type: text/html, Size: 3451 bytes --]