bug#63231: 28.1; image-converter should remove warning messages while conversion

bug#63231: 28.1; image-converter should remove warning messages while conversion

[awrhygty]

I have a WEBP image with a GRAY ICC profile which can be converted into
PNG format successfully by ImageMagick command,
but with a warning message such like:

  magick convert test.webp test.png
  convert: profile 'icc': 'GRAY': Gray color space not permitted on RGB PNG `test.png' @ warning/png.c/MagickPNGWarningHandler/1748.

When trying to display the image within a emacs buffer,
image-converter takes both standard output and standard error while
converting it into a PNG data, and emacs fails to display the image.

A simple avoiding way is adding -quiet option to converting command.
Ideally, image-converter should split standard error into another buffer.



In GNU Emacs 28.1 (build 2, x86_64-w64-mingw32)
 of 2022-04-22 built on AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.2846)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation
 --without-compress-install CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
XPM ZLIB

(NATIVE_COMP present but libgccjit not available)

Important settings:
  value of $LANG: JPN
  locale-coding-system: cp932

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
term/bobcat japan-util iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp
disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads w32notify
w32 lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 60143 9906)
 (symbols 48 6718 1)
 (strings 32 20499 1294)
 (string-bytes 1 668035)
 (vectors 16 14770)
 (vector-slots 8 327522 14544)
 (floats 8 23 219)
 (intervals 56 423 5)
 (buffers 992 12))

bug#63231: 28.1; image-converter should remove warning messages while conversion

[Eli Zaretskii]

> From: awrhygty@outlook.com
> Date: Tue, 02 May 2023 17:02:21 +0900
> 
> 
> I have a WEBP image with a GRAY ICC profile which can be converted into
> PNG format successfully by ImageMagick command,
> but with a warning message such like:
> 
>   magick convert test.webp test.png
>   convert: profile 'icc': 'GRAY': Gray color space not permitted on RGB PNG `test.png' @ warning/png.c/MagickPNGWarningHandler/1748.
> 
> When trying to display the image within a emacs buffer,
> image-converter takes both standard output and standard error while
> converting it into a PNG data, and emacs fails to display the image.
> 
> A simple avoiding way is adding -quiet option to converting command.
> Ideally, image-converter should split standard error into another buffer.

What if the errors are fatal? don't we want to present the user with
the error messages?

bug#63231: 28.1; image-converter should remove warning messages while conversion

[awrhygty]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: awrhygty@outlook.com
>> Date: Tue, 02 May 2023 17:02:21 +0900
>> 
>> 
>> I have a WEBP image with a GRAY ICC profile which can be converted into
>> PNG format successfully by ImageMagick command,
>> but with a warning message such like:
>> 
>>   magick convert test.webp test.png
>>   convert: profile 'icc': 'GRAY': Gray color space not permitted on
>> RGB PNG `test.png' @ warning/png.c/MagickPNGWarningHandler/1748.
>> 
>> When trying to display the image within a emacs buffer,
>> image-converter takes both standard output and standard error while
>> converting it into a PNG data, and emacs fails to display the image.
>> 
>> A simple avoiding way is adding -quiet option to converting command.
>> Ideally, image-converter should split standard error into another buffer.
>
> What if the errors are fatal? don't we want to present the user with
> the error messages?

If error number is zero, warning message is not so important.
Messaging the warning in echo area will be enough.

bug#63231: 28.1; image-converter should remove warning messages while conversion

[Phil Dyer via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

I have hit this bug while opening heic images on Linux.

Imagemagick v7 is deprecating the "convert" CLI. It issues a warning:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
'''

It still produces the PNG, however, the resulting PNG has the following header:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"

\3fff89PNG
\^Z
\^@\^@\^@
IHDR\^@\^@\3fff8c\^@\^@\^R\^P\^H\^B\^@\^@\^@p\3fffd3\3fffc0\3fffb1\^@\^@\^@ cHRM\^@\^@z&\^@\^@\3fff80\3fff84\^@\^@\3ffffa\^@\^@\^@\3fff80\3fffe8\^@\^@u0\^@\^@\3fffea`\^@\^@:\3fff98\^@\^@\^Wp\3fff9c\3fffbaQ<\^@\^@\^@\^FbKGD\^@\3fffff\^@\3fffff\^@\3fffff\3fffa0\3fffbd\3fffa7\3fff93\^@\^@\^@ pHYs\^@\^@\^K\^R\^@\^@\^K\^R\^A\3fffd2\3fffdd~\3ffffc\^@\^@\^@\^AorNT\^A\3fffcf\3fffa2w\3fff9a\^@\^@\3fff80\^@IDATx\3fffda\3fffc4\3ffffd\3fffe9\3fff97d\3fffd9q'\3fff88\3fff99\3fffdd\3ffff5-\3fffbe{\3fffec\3fff91\3fff99\3fff91k\3fffad@\^U
....more png content below
'''

A valid PNG should not have a CLI warning embedded in it. Both warnings and errors should be placed into the messages/warnings/error buffers or similar, not placed inside the string representation of the image file, which I can't read anyway without calling (image-convert) directly. What currently happens when opening a .hiec file with `image-use-external-converter` set to t​ is that the entire PNG string is dumped into the messages buffer and the original image buffer displays a blank square. Since `*message*​​` truncates older lines, the warning message and reason for failure is not visible anyway.

Properly handling the imagemagick v7 cli is important, but is a separate issue. The warning should not be returned inside the string representation of the converted image.

Regards,
Phil

[-- Attachment #2: Type: text/html, Size: 4747 bytes --]

bug#63231: 28.1; image-converter should remove warning messages while conversion

[Phil Dyer via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]

I have hit this bug while opening heic images on Linux.

Imagemagick v7 is deprecating the "convert" CLI. It issues a warning:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
'''

It still produces the PNG, however, the resulting PNG has the following header:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"

\3fff89PNG
\^Z
\^@\^@\^@
IHDR\^@\^@\3fff8c\^@\^@\^R\^P\^H\^B\^@\^@\^@p\3fffd3\3fffc0\3fffb1\^@\^@\^@ cHRM\^@\^@z&\^@\^@\3fff80\3fff84\^@\^@\3ffffa\^@\^@\^@\3fff80\3fffe8\^@\^@u0\^@\^@\3fffea`\^@\^@:\3fff98\^@\^@\^Wp\3fff9c\3fffbaQ<\^@\^@\^@\^FbKGD\^@\3fffff\^@\3fffff\^@\3fffff\3fffa0\3fffbd\3fffa7\3fff93\^@\^@\^@ pHYs\^@\^@\^K\^R\^@\^@\^K\^R\^A\3fffd2\3fffdd~\3ffffc\^@\^@\^@\^AorNT\^A\3fffcf\3fffa2w\3fff9a\^@\^@\3fff80\^@IDATx\3fffda\3fffc4\3ffffd\3fffe9\3fff97d\3fffd9q'\3fff88\3fff99\3fffdd\3ffff5-\3fffbe{\3fffec\3fff91\3fff99\3fff91k\3fffad@\^U
....more png content below
'''

A valid PNG should not have a CLI warning embedded in it. Both warnings and errors should be placed into the messages/warnings/error buffers or similar, not placed inside the string representation of the image file, which I can't read anyway without calling (image-convert) directly. What currently happens when opening a .hiec file with `image-use-external-converter` set tot​ is that the entire PNG string is dumped into the messages buffer and the original image buffer displays a blank square. Since `*message*​​` truncates older lines, the warning message and reason for failure is not visible anyway.

Properly handling the imagemagick v7 cli is important, but is a separate issue. The warning should not be returned inside the string representation of the converted image.

Regards,Phil

On Thursday, 7 November 2024 at 1:15 PM, Phil Dyer <phildyer@protonmail.com> wrote:

> I have hit this bug while opening heic images on Linux.
>
> Imagemagick v7 is deprecating the "convert" CLI. It issues a warning:
>
> '''
> WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
> '''
>
> It still produces the PNG, however, the resulting PNG has the following header:
>
> '''
> WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
>
> \3fff89PNG
> \^Z
> \^@\^@\^@
> IHDR\^@\^@\3fff8c\^@\^@\^R\^P\^H\^B\^@\^@\^@p\3fffd3\3fffc0\3fffb1\^@\^@\^@ cHRM\^@\^@z&\^@\^@\3fff80\3fff84\^@\^@\3ffffa\^@\^@\^@\3fff80\3fffe8\^@\^@u0\^@\^@\3fffea`\^@\^@:\3fff98\^@\^@\^Wp\3fff9c\3fffbaQ<\^@\^@\^@\^FbKGD\^@\3fffff\^@\3fffff\^@\3fffff\3fffa0\3fffbd\3fffa7\3fff93\^@\^@\^@ pHYs\^@\^@\^K\^R\^@\^@\^K\^R\^A\3fffd2\3fffdd~\3ffffc\^@\^@\^@\^AorNT\^A\3fffcf\3fffa2w\3fff9a\^@\^@\3fff80\^@IDATx\3fffda\3fffc4\3ffffd\3fffe9\3fff97d\3fffd9q'\3fff88\3fff99\3fffdd\3ffff5-\3fffbe{\3fffec\3fff91\3fff99\3fff91k\3fffad@\^U
> ....more png content below
> '''
>
> A valid PNG should not have a CLI warning embedded in it. Both warnings and errors should be placed into the messages/warnings/error buffers or similar, not placed inside the string representation of the image file, which I can't read anyway without calling (image-convert) directly. What currently happens when opening a .hiec file with `image-use-external-converter` set to t​ is that the entire PNG string is dumped into the messages buffer and the original image buffer displays a blank square. Since `*message*​​` truncates older lines, the warning message and reason for failure is not visible anyway.
>
> Properly handling the imagemagick v7 cli is important, but is a separate issue. The warning should not be returned inside the string representation of the converted image.
>
> Regards,
> Phil

[-- Attachment #2: Type: text/html, Size: 9822 bytes --]

bug#63231: 28.1; image-converter should remove warning messages while conversion

[Phil Dyer via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

I have hit this bug while opening heic images on Linux.

Imagemagick v7 is deprecating the "convert" CLI. It issues a warning:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
'''

It still produces the PNG, however, the resulting PNG has the following header:

'''
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"

\3fff89PNG
\^Z
\^@\^@\^@
IHDR\^@\^@\3fff8c\^@\^@\^R\^P\^H\^B\^@\^@\^@p\3fffd3\3fffc0\3fffb1\^@\^@\^@ cHRM\^@\^@z&\^@\^@\3fff80\3fff84\^@\^@\3ffffa\^@\^@\^@\3fff80\3fffe8\^@\^@u0\^@\^@\3fffea`\^@\^@:\3fff98\^@\^@\^Wp\3fff9c\3fffbaQ<\^@\^@\^@\^FbKGD\^@\3fffff\^@\3fffff\^@\3fffff\3fffa0\3fffbd\3fffa7\3fff93\^@\^@\^@ pHYs\^@\^@\^K\^R\^@\^@\^K\^R\^A\3fffd2\3fffdd~\3ffffc\^@\^@\^@\^AorNT\^A\3fffcf\3fffa2w\3fff9a\^@\^@\3fff80\^@IDATx\3fffda\3fffc4\3ffffd\3fffe9\3fff97d\3fffd9q'\3fff88\3fff99\3fffdd\3ffff5-\3fffbe{\3fffec\3fff91\3fff99\3fff91k\3fffad@\^U
....more png content below
'''

A valid PNG should not have a CLI warning embedded in it. Both warnings and errors should be placed into the messages/warnings/error buffers or similar, not placed inside the string representation of the image file, which I can't read anyway without calling (image-convert) directly. What currently happens when opening a .hiec file with `image-use-external-converter` set tot​ is that the entire PNG string is dumped into the messages buffer and the original image buffer displays a blank square. Since `*message*​​` truncates older lines, the warning message and reason for failure is not visible anyway.

Properly handling the imagemagick v7 cli is important, but is a separate issue. The warning should not be returned inside the string representation of the converted image.

Regards,Phil

[-- Attachment #2: Type: text/html, Size: 5174 bytes --]