From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#63778: [PATCH] Use comint-pager in eshell Date: Sun, 28 May 2023 19:41:40 -0700 Message-ID: References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="760"; mail-complaints-to="usenet@ciao.gmane.io" To: Morgan Smith , 63778@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 04:42:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3Sq8-000058-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 04:42:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3Sph-00031Z-N4; Sun, 28 May 2023 22:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Spe-00031N-VX for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3Spe-000127-Nl for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3Spe-0003DU-7D for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 02:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63778 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63778-submit@debbugs.gnu.org id=B63778.168532810912335 (code B ref 63778); Mon, 29 May 2023 02:42:02 +0000 Original-Received: (at 63778) by debbugs.gnu.org; 29 May 2023 02:41:49 +0000 Original-Received: from localhost ([127.0.0.1]:56727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SpQ-0003Ct-Rn for submit@debbugs.gnu.org; Sun, 28 May 2023 22:41:49 -0400 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:42281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SpP-0003CV-0s for 63778@debbugs.gnu.org; Sun, 28 May 2023 22:41:47 -0400 Original-Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-53f70f5ef60so606995a12.1 for <63778@debbugs.gnu.org>; Sun, 28 May 2023 19:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685328101; x=1687920101; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=lbj0qt9z/dFSfJBerLhFPUb0rpWPgQmDVtaRtCAC2q8=; b=HRWjxGroUj9nUVqhyWDkU1UL4jvfmbvkxLTvROjDXIoS6ZyXYd4k7fXbSJ5mKskoro Z5PaLD9p2ZQtfSgCsn8+a5/stA5taxsrBq8RNdCyCBT6ZIrdCjGzmXOBqtMth+U96cqp WpLeLrsAUuRfvVxRhc3mRFQZiNhHuKex/K2mhjctENmyO2lAtNO5fCsmWjdKVccHm6ta tPtk+Xlq1312eJ8pb85wEZSLzIKSmes1Jv/h4XAMNZQffTYtUmmPnDUmWgL/dgeJYUvi GFx/+2hcrDyLiv1D46elvqsxdFcR+xw8Bmw5A+LAXlj91xI31kakAmuQTEd/CsFAJmP0 ZGwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685328101; x=1687920101; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lbj0qt9z/dFSfJBerLhFPUb0rpWPgQmDVtaRtCAC2q8=; b=DLVvmOSU7dgi214NFe1r/xqDoM9sOiV2MKJr4E3qwSOu6Y8n2EXDKjhgKEDXurkkgH Jb1wKWSTChOcf3yyrZDtct2HouLbFTV4QFpDblEiMnDqKKh7//2qV7HFwm/b03uys3St HPlShyWgKe906b5dJWTfvge3VkTkEdBwahyGqsRy8OHHofm6aMOI0HbjgvH90iJtTnZw HvZ0spgPd4v8tlJ6QwYT1Mt8cRlOLU9baGc5AyIbD21r4dcy8MO20QeR9MCY9bw70hsS YmnnW+q3H3yqr9GutGrl63UYSb6NQfNGC7TNyr4p5nPyUaIiH2iXLG6Qy6xrJinxVya7 kRjg== X-Gm-Message-State: AC+VfDzKglj0lR9RJDqxCFDsrRtRk3jBkjjB2avRARjlq5/v0JsINWiq UNYRFSWQi1l4Be3C0snJZ7c= X-Google-Smtp-Source: ACHHUZ5wO6MlnszqeJbR0bUrZWvN67bWHlM+lC5Jt9KvsNYXQjWbcsGsWH9l78IGQaNSHcNcMzZsyw== X-Received: by 2002:a17:902:ecc2:b0:1ac:750e:33d6 with SMTP id a2-20020a170902ecc200b001ac750e33d6mr7522210plh.23.1685328100809; Sun, 28 May 2023 19:41:40 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p4-20020a1709028a8400b001acae9734c0sm1635997plo.266.2023.05.28.19.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 May 2023 19:41:40 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262557 Archived-At: On 5/28/2023 7:26 PM, Morgan Smith wrote: >> I haven't the time left in the day to investigate the conflict between >> visual commands and this patch (which I will do) but I would like to >> comment that I believe most users will use one or the other, not both. >> Unless pagers offer features I'm unaware of, I believe it is a better >> user experience to simply dump everything into the current buffer and >> use Emacs as a pager. For very visual command like pulsemixer that use >> ncurses stuff I don't believe having $PAGER set would really affect >> anything. So I would like to ask, does anyone actually want to use the >> visual command stuff just for paging stuff? I'm not personally a fan of visual commands in Eshell, but the docstring for 'eshell-visual-subcommands' suggests adding the various Git subcommands that invoke a pager into that list, so it seems that Eshell *assumes* people would want this, at least... >> I would also like to point out that the default value for comint-pager >> is nil so people would have to turn this on manually. If the usecase >> for comint-pager is significantly different between eshell and other >> comint stuff we could consider a new variable specifically for eshell. >> Personally I don't see a big difference between say ielm and eshell so I >> would like to avoid this but I'll bring it up regardless. Ah, in that case, then I think you'd want to change the logic in esh-var.el so that, when 'comint-pager' is nil, $PAGER returns the real value of PAGER from the environment. Since this behavior is opt-in, I think it would be enough to just make this fix (and ignore the visual command stuff), though special handling for visual commands would still be nice to have.