From: Jim Porter <jporterbugs@gmail.com>
To: Morgan Smith <Morgan.J.Smith@outlook.com>, 63778@debbugs.gnu.org
Subject: bug#63778: [PATCH] Use comint-pager in eshell
Date: Sun, 28 May 2023 19:41:40 -0700 [thread overview]
Message-ID: <e99c9db9-e7f6-68ee-0895-a487e347eaaf@gmail.com> (raw)
In-Reply-To: <DM5PR03MB31637ABFD4B3DBF508BA36F8C54A9@DM5PR03MB3163.namprd03.prod.outlook.com>
On 5/28/2023 7:26 PM, Morgan Smith wrote:
>> I haven't the time left in the day to investigate the conflict between
>> visual commands and this patch (which I will do) but I would like to
>> comment that I believe most users will use one or the other, not both.
>> Unless pagers offer features I'm unaware of, I believe it is a better
>> user experience to simply dump everything into the current buffer and
>> use Emacs as a pager. For very visual command like pulsemixer that use
>> ncurses stuff I don't believe having $PAGER set would really affect
>> anything. So I would like to ask, does anyone actually want to use the
>> visual command stuff just for paging stuff?
I'm not personally a fan of visual commands in Eshell, but the docstring
for 'eshell-visual-subcommands' suggests adding the various Git
subcommands that invoke a pager into that list, so it seems that Eshell
*assumes* people would want this, at least...
>> I would also like to point out that the default value for comint-pager
>> is nil so people would have to turn this on manually. If the usecase
>> for comint-pager is significantly different between eshell and other
>> comint stuff we could consider a new variable specifically for eshell.
>> Personally I don't see a big difference between say ielm and eshell so I
>> would like to avoid this but I'll bring it up regardless.
Ah, in that case, then I think you'd want to change the logic in
esh-var.el so that, when 'comint-pager' is nil, $PAGER returns the real
value of PAGER from the environment. Since this behavior is opt-in, I
think it would be enough to just make this fix (and ignore the visual
command stuff), though special handling for visual commands would still
be nice to have.
next prev parent reply other threads:[~2023-05-29 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 22:45 bug#63778: [PATCH] Use comint-pager in eshell Morgan Smith
2023-05-28 23:06 ` Jim Porter
[not found] ` <DM5PR03MB31631AA2F61C4C656FF6AFCFC54A9@DM5PR03MB3163.namprd03.prod.outlook.com>
2023-05-29 2:26 ` Morgan Smith
2023-05-29 2:41 ` Jim Porter [this message]
2023-05-29 6:23 ` Morgan Smith
2023-05-30 5:14 ` Jim Porter
2023-08-23 23:58 ` Jim Porter
2023-05-29 11:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99c9db9-e7f6-68ee-0895-a487e347eaaf@gmail.com \
--to=jporterbugs@gmail.com \
--cc=63778@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.