From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Wed, 24 May 2023 04:03:40 +0300 Message-ID: References: <834jod1lvc.fsf@gnu.org> <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> <86ttw3blc6.fsf@mail.linkov.net> <86sfbm6hp5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10396"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: sbaugh@janestreet.com, Eli Zaretskii , 63469@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 24 03:04:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1cvL-0002PE-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 May 2023 03:04:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1cv5-0006Ss-Tv; Tue, 23 May 2023 21:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1cv4-0006Sj-Hj for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1cv4-0008IP-9b for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1cv4-0000tb-4I for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2023 01:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16848902313426 (code B ref 63469); Wed, 24 May 2023 01:04:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 24 May 2023 01:03:51 +0000 Original-Received: from localhost ([127.0.0.1]:40682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1cus-0000tC-KP for submit@debbugs.gnu.org; Tue, 23 May 2023 21:03:50 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1cur-0000t0-6d for 63469@debbugs.gnu.org; Tue, 23 May 2023 21:03:49 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 29CB05C00E3; Tue, 23 May 2023 21:03:44 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 23 May 2023 21:03:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1684890224; x=1684976624; bh=k23AtSOElylmKwbUX8S0LD3f2HECVX+ZWpr SfJp2+vk=; b=1Pt4tqTLQf06J/EI96E3AUg1TjhSWbmpCVCf3oD+0biq4/33bfF KCEMkSZ7Ya4JqsdW80ug2UoN8LHkiwFXKXXXuC9jJxqKIDgeYoCmnDsgrz9PmUxK 5n2I7A5efPGK9j2smwM+R3T2BPz37V7zAlq7zKVJkQLaxekkeB5JfKm9HqtFhNRx HxQbOOD+xsGnXMKPVB6vUOcTy/XhzEOo5QWW321Hkzh4zm5+pOCUxnz8Mvww8QD4 dNKNiOujw1ssyzarYYoUgylIn7Itr24tHwopUl8T+YTQWQkgsr8KUpvpHZE3SIia RFRqlYmfKWSU4jlZafeVhXNHpZv7It+QH/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684890224; x=1684976624; bh=k23AtSOElylmKwbUX8S0LD3f2HECVX+ZWpr SfJp2+vk=; b=DHBqKxO0bImrDjd6RvL7pkakXmGUxAHZTQI3nhkyCBvTE9Mm7Gt 1s2aHsbEikhEXuTLg9en5wB1wRCrNrHg7AbtduQMfPrqxz517H+wLmB+l/Rh3ctA J+lir7/XOjpoJ9A3lnUhmA5O45yaC3+ChIn+EBH5Mq5y5LFBuqiHGQX7phoMYXSX bapZnIid4y43bX7SUaFjC6tC1fLgykOvpV7xJidF+Z/a22f2ckagNjdjQCXGHSbh URGHM20U/yT+L0rCk7qe8oNf4VeH/HTq1JHy2UynXiRCt3tqEWJ9RXBPd54Z0k2M mkAjRU/Pheh3pKoNhm9Mv6/8jC2kcd7cEqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejgedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 May 2023 21:03:41 -0400 (EDT) Content-Language: en-US In-Reply-To: <86sfbm6hp5.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262261 Archived-At: On 23/05/2023 21:11, Juri Linkov wrote: >> BTW, there is another problem: by default 'project-name' is defined as >> (file-name-nondirectory (directory-file-name (project-root project))). >> But then project name often is the same for different projects >> because the directory name is the same for the same repository. >> For example, in a subtree: >> >> emacs-master/emacs/... >> emacs-29/emacs/... >> emacs-28/emacs/... >> >> All project names are the same 'emacs'. How would it be possible to >> customize project names? Trying to get a parent dir might be too >> unreliable. So probably the only way is to define the name manually. >> Maybe in .dir-locals.el. Actually this works: >> >> ((nil . ((project-vc-name . "emacs-29")))) >> >> Not sure why non-VC projects can't be named the same way. > > And indeed this is a real problem: in file buffers there is > one project name that comes from project-vc-name, and in > non-file buffers another project name deduced from dirs. Are you saying that non-file buffers don't obey the value of project-vc-name set in parent dir's dir-locals.el? > This distinction became visible while testing project-mode > on the mode-line. > >> Also noticed that project-vc-name is not marked as safe, >> so always asks a confirmation. > > This problem exists only until project.el is loaded. > So maybe the 'safe' cookie should be in ###autoload. Possibly. Would that mean that all :safe attribute assignments should be moved outside of defcustom forms, though? There is a whole bunch of them in project.el alone, most of them are expected to be settable from .dir-locals.el (that's the only point of this attribute).