From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jefferson Carpenter Newsgroups: gmane.emacs.devel Subject: global-whitespace-mode should show whitespace when switching to new buffer Date: Fri, 30 Mar 2018 21:51:43 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B04E0251FEE89536330221A1" X-Trace: blaine.gmane.org 1522446620 496 195.159.176.226 (30 Mar 2018 21:50:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Mar 2018 21:50:20 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 30 23:50:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f21uY-0008Pi-Uo for ged-emacs-devel@m.gmane.org; Fri, 30 Mar 2018 23:50:15 +0200 Original-Received: from localhost ([::1]:45787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f21wa-0006lu-SE for ged-emacs-devel@m.gmane.org; Fri, 30 Mar 2018 17:52:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f21wR-0006lK-SA for emacs-devel@gnu.org; Fri, 30 Mar 2018 17:52:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f21wQ-0006qY-P9 for emacs-devel@gnu.org; Fri, 30 Mar 2018 17:52:11 -0400 Original-Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:40235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f21wQ-0006ph-Hw for emacs-devel@gnu.org; Fri, 30 Mar 2018 17:52:10 -0400 Original-Received: by mail-io0-x236.google.com with SMTP id e79so12268019ioi.7 for ; Fri, 30 Mar 2018 14:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=de52IAcIAJjr/UKXN/x5xpZM48IxE/2QxlakbzOnFDc=; b=XILZ0603RBfocuANpa94ErPlCIclXc/KFcUmyC6le0Q7QqH23kwTI+1lPQzaYj8e7x ttFEPbyyyguMZ0m0kBBWb5b3zuFYoKmGOCWwFAw24NG+2X41C4/yhzHl+98fQWh9vF7o jrgyCiYbexaXJIanLKJkiCCODoS1/2gwIvWnneUgZt83q1FF+q8o6A3vRWcmMsNwfWXD y71VT9pxcZ+Jo3JSZNh74Vn/Nnr0sO17/C1miu+jtglnHtBuOX+yHFPqGz1XThQVa8Nc 3Rqnt8La3QZD9mOsKEiMGxhG2Afa3J+023RJt0QqH7f2Uf/1OBx3Unl1Eh2Slb62Qnzu Tk6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=de52IAcIAJjr/UKXN/x5xpZM48IxE/2QxlakbzOnFDc=; b=p0CbRbhV62OQVQGl14yOxIRBYXv63wXgw1DT78ZN1gREY9l/5lDLsSu1hFJXmFvxsg 4zIkyI/OJoGXQxa8+Iw8VqJxJMNP1vBvx9NKLpZ2edFPnC1meTFJEw6Psnc4STRnE8zq x2PYFeuVntiWefrhOzhvcC1QWgOKZAyfE5v0UNLxPyeUKBmyh/S3GCVQE67Gnu/+icG7 856MbWd48J/F4a812sDR89cFIkeo7jvnQMX8jF2E2w9iusslUcA61ospfSaTd9h0KHa5 NRpNTkan7Mezil9JODP9B4rDU+NwWyIZRzZacpG3YRfN5iNvFoXuMZcnFnptaLr2LbSs 8TZw== X-Gm-Message-State: ALQs6tC1Uiu+VZqtFV1aoJCh4E3XYENSBZ8Wsgby+nHOowonvLQWzRvA xrPH3FYxudYipnQ8b2/SOthKlseM X-Google-Smtp-Source: AIpwx48AjM1VTNvhcWzjO9LB+OslHGGoxGyOHNPcgg893lWuYIwjAo8yFM/PT0o9Zm79o/BRUF71gQ== X-Received: by 10.107.84.8 with SMTP id i8mr681317iob.254.1522446729129; Fri, 30 Mar 2018 14:52:09 -0700 (PDT) Original-Received: from ?IPv6:2601:441:8680:4631:c4de:c18e:5017:bca9? ([2601:441:8680:4631:c4de:c18e:5017:bca9]) by smtp.gmail.com with ESMTPSA id a46-v6sm2772920itj.1.2018.03.30.14.52.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Mar 2018 14:52:08 -0700 (PDT) Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224188 Archived-At: This is a multi-part message in MIME format. --------------B04E0251FEE89536330221A1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit This is probably the worst patch you've ever seen - not sure whether the "advice" I added is the optimal one to add, it just seems to solve the problem for me. Adding unused "&rest args" to a function so that it can be used as advice is probably incorrect as well. Problem was, with global-whitespace-mode enabled, when I switched to a new buffer (say C-x b asdf ), whitespace was not visible. The `whitespacesturn-on-if-enabled' function is already added to after-change-major-mode-hook, but apparently that isn't triggered when a new buffer is created in fundamental-mode. If I turn global-whitespace-mode off and back on again, or if I type "M-x fundamental-mode", then whitespace is visible. The fix I came up with in my init file was to add the code: (defun whitespace-turn-on-if-enabled-2 (&rest args) (whitespace-turn-on-if-enabled)) (advice-add 'switch-to-buffer :after 'whitespace-turn-on-if-enabled-2) But I figured I would create a patch and let you guys look at it and decide what should be done. I have attached it. It works for me, but might not fix a wider root cause, and is almost certainly not the optimal elisp code in any case. Jefferson Carpenter P.S. Even with the above fix (either init file or whitespace.el patch), when I switch to a new buffer, whitespace is shown but in the wrong color. It remains the wrong color if I turn global-whitespace-mode off and on again, but uses the "whitespace-space" face, etc. as it should, when I run "M-x fundamental-mode" (the buffer already being in fundamental-mode). --------------B04E0251FEE89536330221A1 Content-Type: text/plain; charset=UTF-8; name="0001-Turn-on-global-whitespace-mode-when-switching-buffer.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Turn-on-global-whitespace-mode-when-switching-buffer.pa"; filename*1="tch" RnJvbSA4ODg5MGE0NWM1ZDI5ZjU4NGYyMTQ3NWU3YTljZTRmOTVjM2JkYWFhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmZXJzb24gQ2FycGVudGVyIDxqZWZmZXJzb25j YXJwZW50ZXIyQGdtYWlsLmNvbT4KRGF0ZTogRnJpLCAzMCBNYXIgMjAxOCAwMzozNzoyNCAt MDUwMApTdWJqZWN0OiBbUEFUQ0hdIFR1cm4gb24gZ2xvYmFsLXdoaXRlc3BhY2UtbW9kZSB3 aGVuIHN3aXRjaGluZyBidWZmZXJzCgotLS0KIGxpc3Avd2hpdGVzcGFjZS5lbCB8IDQgKysr LQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2xpc3Avd2hpdGVzcGFjZS5lbCBiL2xpc3Avd2hpdGVzcGFjZS5lbAppbmRl eCBjMjgyN2QzZDUxLi5hZjk2YWQ0NmFiIDEwMDY0NAotLS0gYS9saXNwL3doaXRlc3BhY2Uu ZWwKKysrIGIvbGlzcC93aGl0ZXNwYWNlLmVsCkBAIC05OTgsNiArOTk4LDcgQEAgZ2xvYmFs LXdoaXRlc3BhY2UtbW9kZQogICAgIChzYXZlLWN1cnJlbnQtYnVmZmVyCiAgICAgICAoYWRk LWhvb2sgJ2ZpbmQtZmlsZS1ob29rICd3aGl0ZXNwYWNlLXR1cm4tb24taWYtZW5hYmxlZCkK ICAgICAgIChhZGQtaG9vayAnYWZ0ZXItY2hhbmdlLW1ham9yLW1vZGUtaG9vayAnd2hpdGVz cGFjZS10dXJuLW9uLWlmLWVuYWJsZWQpCisgICAgICAoYWR2aWNlLWFkZCAnc3dpdGNoLXRv LWJ1ZmZlciA6YWZ0ZXIgJ3doaXRlc3BhY2UtdHVybi1vbi1pZi1lbmFibGVkKQogICAgICAg KGRvbGlzdCAoYnVmZmVyIChidWZmZXItbGlzdCkpCTsgYWRqdXN0IGFsbCBsb2NhbCBtb2Rl CiAJKHNldC1idWZmZXIgYnVmZmVyKQogCSh1bmxlc3Mgd2hpdGVzcGFjZS1tb2RlCkBAIC0x MDA2LDYgKzEwMDcsNyBAQCBnbG9iYWwtd2hpdGVzcGFjZS1tb2RlCiAgICAgKHNhdmUtY3Vy cmVudC1idWZmZXIKICAgICAgIChyZW1vdmUtaG9vayAnZmluZC1maWxlLWhvb2sgJ3doaXRl c3BhY2UtdHVybi1vbi1pZi1lbmFibGVkKQogICAgICAgKHJlbW92ZS1ob29rICdhZnRlci1j aGFuZ2UtbWFqb3ItbW9kZS1ob29rICd3aGl0ZXNwYWNlLXR1cm4tb24taWYtZW5hYmxlZCkK KyAgICAgIChhZHZpY2UtcmVtb3ZlICdzd2l0Y2gtdG8tYnVmZmVyICd3aGl0ZXNwYWNlLXR1 cm4tb24taWYtZW5hYmxlZCkKICAgICAgIChkb2xpc3QgKGJ1ZmZlciAoYnVmZmVyLWxpc3Qp KQk7IGFkanVzdCBhbGwgbG9jYWwgbW9kZQogCShzZXQtYnVmZmVyIGJ1ZmZlcikKIAkodW5s ZXNzIHdoaXRlc3BhY2UtbW9kZQpAQCAtMTAzMyw3ICsxMDM1LDcgQEAgd2hpdGVzcGFjZS1l bmFibGUtcHJlZGljYXRlCiBpZiB0aGUgY3VycmVudCBidWZmZXIgc2hvdWxkIG9iZXkgYGds b2JhbC13aGl0ZXNwYWNlLW1vZGUnLgogVGhpcyB2YXJpYWJsZSBpcyBub3JtYWxseSBtb2Rp ZmllZCB2aWEgYGFkZC1mdW5jdGlvbicuIikKIAotKGRlZnVuIHdoaXRlc3BhY2UtdHVybi1v bi1pZi1lbmFibGVkICgpCisoZGVmdW4gd2hpdGVzcGFjZS10dXJuLW9uLWlmLWVuYWJsZWQg KCZyZXN0IGFyZ3MpCiAgICh3aGVuIChmdW5jYWxsIHdoaXRlc3BhY2UtZW5hYmxlLXByZWRp Y2F0ZSkKICAgICAod2hpdGVzcGFjZS10dXJuLW9uKSkpCiAKLS0gCjIuMTEuMAoK --------------B04E0251FEE89536330221A1--