From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Christoph Arenz Newsgroups: gmane.emacs.devel Subject: Re: Severe regressions in context of keyboard macros Date: Sun, 29 Sep 2019 19:42:56 +0200 Message-ID: References: <83a7aztoq9.fsf@gnu.org> <6b147564-cfea-1824-701f-33495958d304@web.de> <83d0fusvjd.fsf@gnu.org> <83wodynkuo.fsf@gnu.org> <83wodvl40w.fsf@gnu.org> <65332ac9-0e3f-fbd4-ac84-5ae4e7126d37@web.de> <83v9tfl0lc.fsf@gnu.org> <830f19fe-20dd-b3a3-fc50-26573760dbff@web.de> <490eaf69-c3fe-6ea3-8f89-c0d4d56c5b88@web.de> <835zlciwiv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207769"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 29 19:49:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEdJr-000rtL-7W for ged-emacs-devel@m.gmane.org; Sun, 29 Sep 2019 19:49:15 +0200 Original-Received: from localhost ([::1]:41400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEdJp-0005jk-Sj for ged-emacs-devel@m.gmane.org; Sun, 29 Sep 2019 13:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35891) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEdDx-0005jO-Tp for emacs-devel@gnu.org; Sun, 29 Sep 2019 13:43:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEdDw-0002SF-Ms for emacs-devel@gnu.org; Sun, 29 Sep 2019 13:43:09 -0400 Original-Received: from mout.web.de ([212.227.15.14]:53153) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEdDu-00022C-0Y; Sun, 29 Sep 2019 13:43:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1569778978; bh=uypUqlA2F8PBfr2MQeuPSvP7Uo3odQQ7g0+OQuqSWJg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hT+xmF3w1GYKGq5RpdE47qagRrPxiAoQq0jLZ6qRhL0iqHcZnrjFrkequOrzOzi88 1aI2PvFErD2QbKczXm7Pn2udrjRvwxV0yfJ32z/m+KF8g6NTXv2SrYc5222/Kv0vnA RZxEcy766ZBiAtuZwhqUEcTXicLKF3AuPqhGmfFs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from [192.168.1.106] ([185.44.135.237]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LhhVB-1hjxAJ05An-00mrks; Sun, 29 Sep 2019 19:42:58 +0200 In-Reply-To: <835zlciwiv.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:Zp1S4kSreiyKcWIf6uZ2tgFKBSXDK0TyJDNUnD3xIesF6/+UQ1f lbE6J9WvBdtm1/ngPxgYFb0E1mRPN4DOoLCDX0ikaVc5qhhj6i/p0kvLiAHbIw9F828NPM0 SMMOCMnuqiKSPnVDhmCiDI73kFAhyOuy2VIUhVq8ujR7HLaAjQrY5ctWpn6UpvlHUcs1b3E O7y+qrdLYrO21FtKIKhzg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wo13RJiuT1g=:RRJ1tkbjGX03W4KqW1AIMk tn9VAAyMp5B+Kp+ZGmPmDUS0SuBPrgKuIh1c/xuj+PPpUtPGGkLxKD3x14LpCjLH1LRNC4mYm d1n92P6TOlMcwJV83/fsn1SQO9Z9cCukJBuuYPDJFfp/UKbAoJ+Qbqx3N2jp4GxQ8nKS2hLTy rVuT2J2rahTari60VMtIrhq5EU225EfwFPqFBAoxKLk+vQIK5ILg2GBGLh1hSwOS+4ntW5QMU CcKwSsVK3eDcfB9B1eBvfWuORdlIhEDW1CouYR6nSSXHxArVOaGzHwh8+Gv8itIzttVGJSTN8 N191OJE/Qne1aedXMYSBZOezl8uE3EkoPrwdZiupR3SleqdIvgn/CumP+M5YvWNl0CP86Ph7W z0XNWcW8Yf6VEIkJTGUcuD6pTJCMqF5QDoDQQ1lDE6P6I6mLKSfYUJ3SClzwtXHoJmXC234N5 TqVgSj3IdonRPR3pao/SakFxCUFqM24mdfAmR4OsgRExWL6OEWiibqHqFcHByVZutvGhl3UUv QbSP6AC5T2IroI6xOJBpTTDcX7WNCn2mNVppOGo06EsGvyPMF2BLu717Ki+/sQ3wEBuq5Sc4U W00gBd479nypQbcv4AcHfhFg+m92TxplDBDpKBbbzoiPaP6LdbqrSWHl2hNnatS/9FwEAjFun UZubTpsZbBasacpXqZfqATejSNrjWza7HGmdw/f7OseiWdCrdkB2TmcTEHIxEh3+S4MzLWSZA B01ALKiSPRJun2v4Qg8FBN+kg+/YU6vvVN6TWFa3erMyNh+xk+wgeMOlOmdMMNCaNYRzicAf X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240393 Archived-At: On 28.09.19 11:46, Eli Zaretskii wrote: >> I spent some more time on this. The problem is bigger than stated in th= e >> original bug report: >> Any function key that follows a digit and is not separated by a o= r >> is recorded twice in calc when defining a keyboard macro, e.g. >> `1 2 + ' records "2++". > Is this while using Calc, or is this in some other situation? Just in Calc. I should have been a bit clearer what I meant with `function' key: While calc is reading digits, it recognizes it has rad a complete number when reading or . Calc also recognizes a number when reading a calc function key when reading digits. This is one path when calc reads this key a second time. Here is lossage for such a case: =C2=A01=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0;; = calcDigit-start =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 ;; calcDigit-nondigit =C2=A01=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0;; = calcDigit-start =C2=A02=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0;; = calcDigit-key =C2=A0+=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0;; = calcDigit-key =C2=A0+=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0;; = calc-plus Note the `+' being read twice. With the proposed patch, lossage looks just the same -- just in case of keyboard macro recording, we avoid the `+' being recorded twice. Lossage in this case looks like this: =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ;; kmacro-start-mac= ro-or-insert-counter =C2=A01=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ;; calcDi= git-start =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; calcDigit-nondigit =C2=A01=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ;; calcDi= git-start =C2=A02=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ;; calcDi= git-key =C2=A0+=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ;; calcDi= git-key =C2=A0;; calc-plus =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ;; kmacro-end-or-ca= ll-macro >> I am getting more confident that the patch below fixes this bug.Itfixes >> a severe issue with macros in calc, does not make things worse and does >> not interfere in case no macro is being defined. >> >> Your thoughts? > If it works well for you in Calc, I will install it. > > Thanks. Yes, the patch definitely improves the situation. Thanks! > > P.S. I'll look into the other bug, regarding input methods, when I > have time. Thanks for filing it. Thanks for that as well!