From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Charalampos Mitrodimas Newsgroups: gmane.emacs.bugs Subject: bug#70765: 30.0.50; srecode-all-template-hash in lisp/cedet/srecode/find.el Date: Sat, 4 May 2024 20:11:53 +0000 Message-ID: References: <86ikzugpkv.fsf@pollock-nageoire.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Q2YBv05SqgSfQk9VZ0oEkrkd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70765@debbugs.gnu.org To: "Pierre L. Nageoire" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 04 22:13:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3Lkm-0000X9-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 May 2024 22:13:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3LkR-0004AR-Ry; Sat, 04 May 2024 16:12:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3LkQ-0004A8-5Z for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 16:12:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3LkN-0002vC-7L for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 16:12:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3Lkk-0002jw-66 for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Charalampos Mitrodimas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2024 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70765 X-GNU-PR-Package: emacs Original-Received: via spool by 70765-submit@debbugs.gnu.org id=B70765.171485354710524 (code B ref 70765); Sat, 04 May 2024 20:13:02 +0000 Original-Received: (at 70765) by debbugs.gnu.org; 4 May 2024 20:12:27 +0000 Original-Received: from localhost ([127.0.0.1]:55550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3LkB-0002jg-8n for submit@debbugs.gnu.org; Sat, 04 May 2024 16:12:27 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:53167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Lk9-0002jZ-7o for 70765@debbugs.gnu.org; Sat, 04 May 2024 16:12:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A75C6240101 for <70765@debbugs.gnu.org>; Sat, 4 May 2024 22:11:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714853515; bh=NrQvIevCtI31PMbRIOqJeOfidF9WTbpenMGSCjxc/9U=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=bZUnxeMp8giM23iWGwlmyWUqba0+BM6M401N/g39qnp9UfmTA3PlmEwJgHxLY51F/ jLzvlNCJPOhLhltDCnhIYpNZKoxIci4afi/VFGJbLfVYC+V+1RO8in8W0ypUtVcLTK ewJXNzHImbRCLQGlpiXNCBG00aph2DlrWCWAIF/gs1UfYUCDLkEC9xZ+GtHQSO6jyc 8SnE64EMb5Ag62GWJyED25WSPQ4cxazHxXlLNNFQDjMV8oULt0IZWCkGzrgjiqqauc xYHcmypoVUlnMDTpYOKCIeZ9pwB+9R1sC3E8wqFhIUQ0gIahDLXFWCxGoNikMWzIbm sphyKp52yOYwg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VWzNB2y0Pz9rxB; Sat, 4 May 2024 22:11:54 +0200 (CEST) Content-Language: en-US In-Reply-To: <86ikzugpkv.fsf@pollock-nageoire.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284464 Archived-At: This is a multi-part message in MIME format. --------------Q2YBv05SqgSfQk9VZ0oEkrkd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Pierre, On 4/5/24 7:37 AM, Pierre L. Nageoire wrote: > Hi, > > Last line of this function code is mhash)))) and should most probably be > ))mhas)) otherwise the method always returns nil making the whole > srecode system unusable. You're correct, the function did not return the data it was supposed to due to the misplaced parenthesis, instead, it was always returning "nil". Patch attached. > > Implementation was different in 29.0.50 and has been changed. I suspect > it has been bugged as well ! Sory if I am wrong I didn't go back in history to verify this, but you might be right.         C. Mitrodimas --------------Q2YBv05SqgSfQk9VZ0oEkrkd Content-Type: text/plain; charset=UTF-8; name="0001-Fix-srecode-all-template-hash-always-returning-nil.patch" Content-Disposition: attachment; filename*0="0001-Fix-srecode-all-template-hash-always-returning-nil.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBhNjAyM2M4YTgwNjkxNzg5NjVlODhkOWRjOWMwYTgxZjgxMWNiZTQ2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFyYWxhbXBvcyBNaXRyb2RpbWFzIDxjaGFybWl0 cm9AcG9zdGVvLm5ldD4KRGF0ZTogU2F0LCA0IE1heSAyMDI0IDIyOjQ1OjE1ICswMzAwClN1 YmplY3Q6IFtQQVRDSF0gRml4IHNyZWNvZGUtYWxsLXRlbXBsYXRlLWhhc2ggYWx3YXlzIHJl dHVybmluZyBuaWwKClRoZSBpc3N1ZSB3YXMgdGhhdCB0aGUgZnVuY3Rpb24gYWx3YXlzIHJl dHVybmVkIG5pbCBiZWNhdXNlIHRoZSBjbG9zaW5nCnBhcmVudGhlc2VzIHdlcmUgaW4gdGhl IHdyb25nIHBvc2l0aW9uLiBUaGlzIG1lYW50IHRoYXQgdGhlIGZ1bmN0aW9uCmNvdWxkbid0 IGdpdmUgYmFjayB0aGUgZGF0YSBpdCB3YXMgc3VwcG9zZWQgdG8sIG1ha2luZyB0aGUgd2hv bGUgc3JlY29kZQpzeXN0ZW0gbm90IHdvcmsgcHJvcGVybHkuCgpCeSBtb3ZpbmcgdGhlIHBh cmVudGhlc2VzIHRvIHRoZSBjb3JyZWN0IHBsYWNlLCB0aGUgZnVuY3Rpb24gbm93IHJldHVy bnMKYSBoYXNoIHRhYmxlIHdpdGggYWxsIHRoZSB0ZW1wbGF0ZXMgaXQgZmluZHMuCgoqIGxp c3AvY2VkZXQvc3JlY29kZS9maW5kLmVsIChzcmVjb2RlLWFsbC10ZW1wbGF0ZS1oYXNoKTog QWRqdXN0ZWQgdGhlCnBvc2l0aW9uIG9mIGNsb3NpbmcgcGFyZW50aGVzZXMgc28gdGhhdCB0 aGUgbWhhc2ggdmFyaWFibGUgaXMgcmV0dXJuZWQKY29ycmVjdGx5LiAoQnVnIzcwNzY1KQot LS0KIGxpc3AvY2VkZXQvc3JlY29kZS9maW5kLmVsIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av Y2VkZXQvc3JlY29kZS9maW5kLmVsIGIvbGlzcC9jZWRldC9zcmVjb2RlL2ZpbmQuZWwKaW5k ZXggNDEwMzBhYTY5NDQuLmRiNmIzOTg4NTYyIDEwMDY0NAotLS0gYS9saXNwL2NlZGV0L3Ny ZWNvZGUvZmluZC5lbAorKysgYi9saXNwL2NlZGV0L3NyZWNvZGUvZmluZC5lbApAQCAtMjMz LDggKzIzMyw4IEBAIHNyZWNvZGUtYWxsLXRlbXBsYXRlLWhhc2gKIAkJICAgICAod2hlbiAo b3IgKG5vdCBwcmVkaWNhdGUpCiAJCQkgICAgICAgKGZ1bmNhbGwgcHJlZGljYXRlIHRlbXAp KQogCQkgICAgICAgKHB1dGhhc2gga2V5IHRlbXAgbWhhc2gpKSkKLQkJICAgKG9yZWYgdGFi IG5hbWVoYXNoKSkpKQotICAgICAgbWhhc2gpKSkpCisJCSAgIChvcmVmIHRhYiBuYW1laGFz aCkpKSkpKQorICAgICAgbWhhc2gpKQogCiAoZGVmdW4gc3JlY29kZS1jYWxjdWxhdGUtZGVm YXVsdC10ZW1wbGF0ZS1zdHJpbmcgKGhhc2gpCiAgICJDYWxjdWxhdGUgdGhlIG5hbWUgb2Yg dGhlIHRlbXBsYXRlIHRvIHVzZSBhcyBhIERFRkFVTFQuCi0tIAoyLjM5LjMgKEFwcGxlIEdp dC0xNDYpCgo= --------------Q2YBv05SqgSfQk9VZ0oEkrkd--