From: Ralf Angeli <angeli@caeruleus.net>
Subject: Re: display-mm-width return value off on Windows
Date: Tue, 11 Jul 2006 20:43:11 +0200 [thread overview]
Message-ID: <e90rfu$erk$1@sea.gmane.org> (raw)
In-Reply-To: uodvyoc91.fsf@gnu.org
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
* Eli Zaretskii (2006-07-09) writes:
>> From: Ralf Angeli <angeli@caeruleus.net>
>>
>> If `GetDeviceCaps (hdc, HORSIZE)' always assumes a fixed DPI value
>> that would explain why the values are so inaccurate especially on
>> displays with a high DPI value. In that case I think it makes sense
>> to use the DPI value when calculating the size (as my patch does) and
>> assume that the user set it to a value matching her monitor.
>>
>> As a last resort we could provide user options (in Emacs) for setting
>> the correct size of the screen which will be used as return values for
>> `display-mm-{width,height}'.
>
> Sounds like a good plan to me.
Here are change log entries and patches to achieve that:
2006-07-11 Ralf Angeli <angeli@caeruleus.net>
* frame.el (display-mm-height): New variable.
(display-mm-height): Use it.
(display-mm-width): New variable.
(display-mm-width): Use it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: frame.el.patch --]
[-- Type: text/x-patch, Size: 1839 bytes --]
Index: frame.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/frame.el,v
retrieving revision 1.236
diff -u -r1.236 frame.el
--- frame.el 25 Mar 2006 07:40:18 -0000 1.236
+++ frame.el 11 Jul 2006 18:40:03 -0000
@@ -1081,17 +1081,35 @@
(t
(frame-width (if (framep display) display (selected-frame)))))))
+(defcustom display-mm-height nil
+ "Height of display in millimeters.
+If non-nil, used as return value for function `display-mm-height'."
+ :version "22.1"
+ :type 'integer
+ :group 'frames)
+
(defun display-mm-height (&optional display)
"Return the height of DISPLAY's screen in millimeters.
-If the information is unavailable, value is nil."
- (and (memq (framep-on-display display) '(x w32 mac))
- (x-display-mm-height display)))
+If the information is unavailable, value is nil. Return value of
+variable `display-mm-height' if set."
+ (or display-mm-height
+ (and (memq (framep-on-display display) '(x w32 mac))
+ (x-display-mm-height display))))
+
+(defcustom display-mm-width nil
+ "Width of display in millimeters.
+If non-nil, used as return value for function `display-mm-width'."
+ :version "22.1"
+ :type 'integer
+ :group 'frames)
(defun display-mm-width (&optional display)
"Return the width of DISPLAY's screen in millimeters.
-If the information is unavailable, value is nil."
- (and (memq (framep-on-display display) '(x w32 mac))
- (x-display-mm-width display)))
+If the information is unavailable, value is nil. Return value of
+variable `display-mm-width' if set."
+ (or display-mm-width
+ (and (memq (framep-on-display display) '(x w32 mac))
+ (x-display-mm-width display))))
(defun display-backing-store (&optional display)
"Return the backing store capability of DISPLAY's screen.
[-- Attachment #3: Type: text/plain, Size: 194 bytes --]
2006-07-11 Ralf Angeli <angeli@caeruleus.net>
* w32fns.c (Fx_display_mm_height, Fx_display_mm_width): Calculate
size of display by means of size in pixels and number of pixels
per inch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: w32fns.c.patch --]
[-- Type: text/x-patch, Size: 1258 bytes --]
Index: w32fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32fns.c,v
retrieving revision 1.271
diff -u -r1.271 w32fns.c
--- w32fns.c 30 Jun 2006 13:40:21 -0000 1.271
+++ w32fns.c 11 Jul 2006 18:38:37 -0000
@@ -6502,15 +6502,16 @@
{
struct w32_display_info *dpyinfo = check_x_display_info (display);
HDC hdc;
- int cap;
+ int height;
hdc = GetDC (dpyinfo->root_window);
- cap = GetDeviceCaps (hdc, VERTSIZE);
+ height = round (25.4 * GetDeviceCaps (hdc, VERTRES)
+ / GetDeviceCaps (hdc, LOGPIXELSY));
ReleaseDC (dpyinfo->root_window, hdc);
- return make_number (cap);
+ return make_number (height);
}
DEFUN ("x-display-mm-width", Fx_display_mm_width, Sx_display_mm_width, 0, 1, 0,
@@ -6524,15 +6525,16 @@
struct w32_display_info *dpyinfo = check_x_display_info (display);
HDC hdc;
- int cap;
+ int width;
hdc = GetDC (dpyinfo->root_window);
- cap = GetDeviceCaps (hdc, HORZSIZE);
+ width = round (25.4 * GetDeviceCaps (hdc, HORZRES)
+ / GetDeviceCaps (hdc, LOGPIXELSX));
ReleaseDC (dpyinfo->root_window, hdc);
- return make_number (cap);
+ return make_number (width);
}
DEFUN ("x-display-backing-store", Fx_display_backing_store,
[-- Attachment #5: Type: text/plain, Size: 10 bytes --]
--
Ralf
[-- Attachment #6: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-07-11 18:43 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 17:50 display-mm-width return value off on Windows Ralf Angeli
2006-07-06 21:08 ` Eli Zaretskii
2006-07-06 21:25 ` David Kastrup
2006-07-07 5:56 ` Ralf Angeli
2006-07-07 10:18 ` Eli Zaretskii
2006-07-07 10:22 ` Eli Zaretskii
2006-07-07 12:05 ` Lennart Borgman
2006-07-07 16:54 ` Ralf Angeli
2006-07-08 12:58 ` Eli Zaretskii
2006-07-08 13:23 ` Lennart Borgman
2006-07-08 14:42 ` Eli Zaretskii
2006-07-08 21:27 ` Jason Rumney
2006-07-08 22:23 ` David Kastrup
2006-07-08 23:03 ` Jason Rumney
2006-07-09 7:36 ` Ralf Angeli
2006-07-09 8:03 ` David Kastrup
2006-07-09 7:41 ` Ralf Angeli
2006-07-09 8:05 ` David Kastrup
2006-07-09 18:37 ` Eli Zaretskii
2006-07-10 10:30 ` Kim F. Storm
2006-07-10 10:45 ` David Kastrup
2006-07-10 13:29 ` Jason Rumney
2006-07-10 14:19 ` David Kastrup
2006-07-10 21:28 ` Jason Rumney
2006-07-10 22:05 ` David Kastrup
2006-07-10 20:12 ` Eli Zaretskii
2006-07-10 23:17 ` Kim F. Storm
2006-07-10 23:22 ` David Kastrup
2006-07-11 18:43 ` Ralf Angeli [this message]
2006-07-12 13:07 ` Kim F. Storm
2006-07-12 19:22 ` Richard Stallman
2006-07-13 19:38 ` Ralf Angeli
2006-07-13 19:59 ` David Kastrup
2006-07-14 17:03 ` Richard Stallman
2006-07-14 18:16 ` Stefan Monnier
2006-07-14 18:33 ` David Kastrup
2006-07-14 21:37 ` Stefan Monnier
2006-07-15 22:06 ` Ralf Angeli
2006-07-16 17:04 ` Ralf Angeli
2006-07-14 17:03 ` Richard Stallman
2006-07-09 9:31 ` Jan Djärv
2006-07-08 17:40 ` Robert J. Chassell
2006-07-06 22:09 ` Jason Rumney
2006-07-06 22:37 ` Lennart Borgman
2006-07-07 5:50 ` Ralf Angeli
2006-07-07 9:09 ` Eli Zaretskii
2006-08-05 14:50 ` Ralf Angeli
2006-08-19 15:15 ` Ralf Angeli
2006-08-19 15:37 ` David Kastrup
2006-08-19 16:31 ` Jason Rumney
2006-08-19 17:54 ` Ralf Angeli
2006-08-19 22:34 ` Jason Rumney
2006-08-20 8:19 ` Ralf Angeli
2006-08-21 9:06 ` Eli Zaretskii
2006-08-21 9:17 ` Lennart Borgman
2006-08-21 10:22 ` Eli Zaretskii
2006-08-21 10:36 ` David Kastrup
2006-08-21 11:45 ` Jason Rumney
2006-08-21 11:55 ` David Kastrup
2006-08-21 10:43 ` Lennart Borgman
2006-08-21 14:07 ` Eli Zaretskii
2006-08-21 15:03 ` Lennart Borgman
2006-08-21 19:22 ` Ralf Angeli
2006-08-21 23:10 ` Eli Zaretskii
2006-08-22 5:57 ` Ralf Angeli
2006-08-22 19:16 ` Ralf Angeli
2006-08-22 21:38 ` Kim F. Storm
2006-08-23 18:31 ` Ralf Angeli
2006-08-23 22:44 ` Kim F. Storm
2006-08-24 16:14 ` Ralf Angeli
2006-08-24 20:18 ` Kim F. Storm
2006-08-25 16:38 ` Ralf Angeli
2006-08-25 22:28 ` Kim F. Storm
2006-08-21 23:25 ` Jason Rumney
2006-08-22 5:51 ` Ralf Angeli
2006-08-22 7:46 ` Jason Rumney
2006-08-22 19:24 ` Ralf Angeli
-- strict thread matches above, loose matches on Subject: below --
2006-07-14 23:55 Robert J. Chassell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e90rfu$erk$1@sea.gmane.org' \
--to=angeli@caeruleus.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.