all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>, Damien Cassou <damien@cassou.me>
Cc: 36974@debbugs.gnu.org
Subject: bug#36974: 26.2.90; [PATCH] Add imenu support to xref
Date: Tue, 24 Dec 2019 22:41:17 +0200	[thread overview]
Message-ID: <e8c70777-8440-1aec-3120-4eb5709deb25@yandex.ru> (raw)
In-Reply-To: <87imqoh57t.fsf@gnus.org>

On 23.08.2019 7:32, Lars Ingebrigtsen wrote:
> Damien Cassou<damien@cassou.me>  writes:
> 
>> * lisp/progmodes/xref.el (xref--imenu-prev-index-position)
>> (xref--imenu-extract-index-name): Add functions to get imenu support.
>> (xref--xref-buffer-mode): Set imenu variables to the new functions.
>> * etc/NEWS: Add corresponding entry.
> I'm not a big imenu user, so I'm probably not the best to judge the
> applicability of this patch, but it looked logical to me, and I've
> applied the patch (after folding a couple of too-long lines).

This patch had a typo which made it not work at all (which is easy to 
see by calling 'M-x imenu' in any of the Xref buffers).

Considering it's been applied 4 months ago and nobody noticed the 
problem, maybe it's not that useful after all?





  reply	other threads:[~2019-12-24 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 11:53 bug#36974: 26.2.90; [PATCH] Add imenu support to xref Damien Cassou
2019-08-23  4:32 ` Lars Ingebrigtsen
2019-12-24 20:41   ` Dmitry Gutov [this message]
2019-12-25 16:17     ` Lars Ingebrigtsen
2019-12-25 16:29       ` Dmitry Gutov
2019-12-25 16:43         ` Dmitry Gutov
2019-12-25 17:10           ` Lars Ingebrigtsen
2019-12-27 10:11     ` Damien Cassou
2019-12-27 13:50       ` Dmitry Gutov
2019-12-27 14:24         ` Damien Cassou
2019-12-27 14:32           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8c70777-8440-1aec-3120-4eb5709deb25@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=36974@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.