bug#60585: 30.0.50; global-text-scale-adjust shrinks window (was not before), was: Re: bug#52493: 29.0.50; Setting Inconsolata up in init.el makes default face rendered wrong

[Dmitry Gutov <dgutov@yandex.ru>]

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

On 22/01/2023 11:54, martin rudalics wrote:
>  >> For reference let's try to stick to the last x_scale_font.diff patch I
>  >> sent you.  What was the "impair" size there?
>  >
>  > According to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52493#332, 
> some impair sizes were 80x36 minus 1 in any dimension using the mouse.
> 
> You mean the ones where you resized a frame with the mouse by 16 or 36
> pixels with a character size of 17x37?

I guess so.

>  > So, with x_rest.diff, the attached transcript is of:
>  >
>  > 1. Resizing the frame to 80x36 (according to GNOME).
>  > 2. Evaluating the set-face-attribute form twice.
>  > 3. Resizing the frame to 80x20 (per GNOME), which is 76x20 according 
> to our internal measurements.
> 
> Do you mean that 80x36 according to GNOME is 80x36 according to our
> internal measurements> while 80x20 to GNOME is 76x20 according to our
> internal measurements?

Not at all, I just got a little tired looking up our internal 
measurements every time. GNOME's measurements, OTOH, are listed under 
the mouse while I'm resizing the window.

I wasn't sure you really needed the internal ones here, so at some steps 
I only mentioned GNOME's ones.

>  > 4. Evaluating the set-face-attribute form twice again.
>  > 5. Resizing to 80x32.
>  > 6. Evaluating s-f-a twice again.
>  >
>  > In this scenario, step 4 doesn't change the frame size. But if I skip
>  > step 1, step 4 (evaluating s-f-a after resizing to 80x20) does change
>  > the frame size. And step 6 (s-f-a at size 80x32) does not.
>  >
>  > So it seems the history of size changes now (?) affects which sizes 
> are "impair".
> 
> Didn't we always have that?

Not to my recollection. If the current pixel dimensions of the frame are 
FONT_HEIGHT*LINES-1, wouldn't that be a stable condition?

I could be wrong, though.

> The present code simply tries to reduce
> some noise when setting the font would otherwise cause a resize of a few
> pixels.

Cool.

>  > Also, only height is important now: if height 20 is "impair", then I
>  > can resize the frame to any width with this height, and evaling s-f-a
>  > will shrink the frame in both dimensions by one char. Same for height
>  > 34 in the alternative scenario.
> 
> Please try the next patch so at least the initial size becomes
> reasonable again.

It does, thank you.

Here's a new scenario (very much similar to the old one):

1. Evaluate s-f-a twice.
2. Resize to 80x18 (internally it's 76x18).
3. Evaluate s-f-a twice.

The transcript attached, in case it's useful. But I guess, as per the 
previous discussion, this is the point where we could stop, with no 
further improvement feasible.

[-- Attachment #2: foo.txt --]
[-- Type: text/plain, Size: 9502 bytes --]

adjust_frame_size old native pixels 80x25 new native pixels 80x25 old text pixels 80x25 new text pixels 80x24 old text chars 80x25 new text chars 80x24
adjust_frame_size old native pixels 80x25 new native pixels 1456x900 old text pixels 80x25 new text pixels 1440x900 old text chars 80x25 new text chars 80x25
adjust_frame_size old native pixels 1456x900 new native pixels 1456x1296 old text pixels 1440x900 new text pixels 1440x1296 old text chars 80x25 new text chars 80x36
adjust_frame_size old native pixels 1456x1296 new native pixels 1488x1296 old text pixels 1440x1296 new text pixels 1440x1296 old text chars 80x36 new text chars 80x36
xg_frame_set_char_size old native pixels 1488x1296 new native pixels 1488x1296 outer pixels 744x698
xg_frame_set_char_size old native pixels 1488x1296 new native pixels 1488x1296 outer pixels 744x673
xg_frame_resized old native pixels 1488x1296 new native pixels 1488x1346
xg_frame_resized old native pixels 1488x1296 new native pixels 1488x1296
xg_wm_set_size_hint scale 2 char width 18 toolbar 0 vscroll 32 fringes 16 borders 0 text width 720 base width 33 width inc 9
    char height 36 menubar 50 toolbar 0 hscroll 0 borders 0 text height 648 base height 43 height inc 18
xg_wm_set_size_hint scale 2 char width 18 toolbar 0 vscroll 32 fringes 16 borders 0 text width 720 base width 33 width inc 9
    char height 36 menubar 50 toolbar 82 hscroll 0 borders 0 text height 648 base height 84 height inc 18
xg_frame_set_char_size old native pixels 1488x1296 new native pixels 1488x1296 outer pixels 744x714 outer rest 0x0

x_new_font old char size 18x36 new char size 21x45 text chars 80x36 old text pixels 1440x1296 new text pixels 1680x1620
xg_wm_set_size_hint scale 2 char width 21 toolbar 0 vscroll 32 fringes 16 borders 0 text width 840 base width 34 width inc 10
    char height 45 menubar 50 toolbar 82 hscroll 0 borders 0 text height 810 base height 106 height inc 22
xg_frame_set_char_size old native pixels 1488x1296 new native pixels 1728x1620 outer pixels 864x876 outer rest 0x0
xg_frame_resized old native pixels 1488x1296 new native pixels 1728x1620
adjust_frame_size old native pixels 1488x1296 new native pixels 1728x1620 old text pixels 1440x1296 new text pixels 1680x1620 old text chars 80x36 new text chars 80x36

x_new_font old char size 21x45 new char size 17x37 text chars 80x36 old text pixels 1680x1620 new text pixels 1360x1332
xg_wm_set_size_hint scale 2 char width 17 toolbar 0 vscroll 32 fringes 16 borders 0 text width 680 base width 32 width inc 8
    char height 37 menubar 50 toolbar 82 hscroll 0 borders 0 text height 666 base height 84 height inc 18
xg_frame_set_char_size old native pixels 1728x1620 new native pixels 1408x1332 outer pixels 704x732 outer rest 0x0
xg_frame_resized old native pixels 1728x1620 new native pixels 1408x1332
adjust_frame_size old native pixels 1728x1620 new native pixels 1408x1332 old text pixels 1680x1620 new text pixels 1360x1332 old text chars 80x36 new text chars 80x36

x_new_font old char size 17x37 new char size 17x37 text chars 80x36 old text pixels 1360x1332 new text pixels 1360x1332

x_new_font old char size 17x37 new char size 17x37 text chars 80x36 old text pixels 1360x1332 new text pixels 1360x1332
xg_frame_resized old native pixels 1408x1332 new native pixels 1408x1296
adjust_frame_size old native pixels 1408x1332 new native pixels 1408x1296 old text pixels 1360x1332 new text pixels 1360x1296 old text chars 80x36 new text chars 80x35
xg_frame_resized old native pixels 1408x1296 new native pixels 1392x1296
adjust_frame_size old native pixels 1408x1296 new native pixels 1392x1296 old text pixels 1360x1296 new text pixels 1344x1296 old text chars 80x35 new text chars 79x35
xg_frame_resized old native pixels 1392x1296 new native pixels 1392x1260
adjust_frame_size old native pixels 1392x1296 new native pixels 1392x1260 old text pixels 1344x1296 new text pixels 1344x1260 old text chars 79x35 new text chars 79x34
xg_frame_resized old native pixels 1392x1260 new native pixels 1392x1224
adjust_frame_size old native pixels 1392x1260 new native pixels 1392x1224 old text pixels 1344x1260 new text pixels 1344x1224 old text chars 79x34 new text chars 79x33
xg_frame_resized old native pixels 1392x1224 new native pixels 1392x1188
adjust_frame_size old native pixels 1392x1224 new native pixels 1392x1188 old text pixels 1344x1224 new text pixels 1344x1188 old text chars 79x33 new text chars 79x32
xg_frame_resized old native pixels 1392x1188 new native pixels 1392x1152
adjust_frame_size old native pixels 1392x1188 new native pixels 1392x1152 old text pixels 1344x1188 new text pixels 1344x1152 old text chars 79x32 new text chars 79x31
xg_frame_resized old native pixels 1392x1152 new native pixels 1392x1080
adjust_frame_size old native pixels 1392x1152 new native pixels 1392x1080 old text pixels 1344x1152 new text pixels 1344x1080 old text chars 79x31 new text chars 79x29
xg_frame_resized old native pixels 1392x1080 new native pixels 1392x1008
adjust_frame_size old native pixels 1392x1080 new native pixels 1392x1008 old text pixels 1344x1080 new text pixels 1344x1008 old text chars 79x29 new text chars 79x27
xg_frame_resized old native pixels 1392x1008 new native pixels 1392x972
adjust_frame_size old native pixels 1392x1008 new native pixels 1392x972 old text pixels 1344x1008 new text pixels 1344x972 old text chars 79x27 new text chars 79x26
xg_frame_resized old native pixels 1392x972 new native pixels 1392x936
adjust_frame_size old native pixels 1392x972 new native pixels 1392x936 old text pixels 1344x972 new text pixels 1344x936 old text chars 79x26 new text chars 79x25
xg_frame_resized old native pixels 1392x936 new native pixels 1392x900
adjust_frame_size old native pixels 1392x936 new native pixels 1392x900 old text pixels 1344x936 new text pixels 1344x900 old text chars 79x25 new text chars 79x24
xg_frame_resized old native pixels 1392x900 new native pixels 1376x900
adjust_frame_size old native pixels 1392x900 new native pixels 1376x900 old text pixels 1344x900 new text pixels 1328x900 old text chars 79x24 new text chars 78x24
xg_frame_resized old native pixels 1376x900 new native pixels 1376x864
adjust_frame_size old native pixels 1376x900 new native pixels 1376x864 old text pixels 1328x900 new text pixels 1328x864 old text chars 78x24 new text chars 78x23
xg_frame_resized old native pixels 1376x864 new native pixels 1376x828
adjust_frame_size old native pixels 1376x864 new native pixels 1376x828 old text pixels 1328x864 new text pixels 1328x828 old text chars 78x23 new text chars 78x22
xg_frame_resized old native pixels 1376x828 new native pixels 1376x792
adjust_frame_size old native pixels 1376x828 new native pixels 1376x792 old text pixels 1328x828 new text pixels 1328x792 old text chars 78x22 new text chars 78x21
xg_frame_resized old native pixels 1376x792 new native pixels 1392x792
adjust_frame_size old native pixels 1376x792 new native pixels 1392x792 old text pixels 1328x792 new text pixels 1344x792 old text chars 78x21 new text chars 79x21
xg_frame_resized old native pixels 1392x792 new native pixels 1376x792
adjust_frame_size old native pixels 1392x792 new native pixels 1376x792 old text pixels 1344x792 new text pixels 1328x792 old text chars 79x21 new text chars 78x21
xg_frame_resized old native pixels 1376x792 new native pixels 1360x792
adjust_frame_size old native pixels 1376x792 new native pixels 1360x792 old text pixels 1328x792 new text pixels 1312x792 old text chars 78x21 new text chars 77x21
xg_frame_resized old native pixels 1360x792 new native pixels 1344x792
adjust_frame_size old native pixels 1360x792 new native pixels 1344x792 old text pixels 1312x792 new text pixels 1296x792 old text chars 77x21 new text chars 76x21
xg_frame_resized old native pixels 1344x792 new native pixels 1344x756
adjust_frame_size old native pixels 1344x792 new native pixels 1344x756 old text pixels 1296x792 new text pixels 1296x756 old text chars 76x21 new text chars 76x20
xg_frame_resized old native pixels 1344x756 new native pixels 1344x720
adjust_frame_size old native pixels 1344x756 new native pixels 1344x720 old text pixels 1296x756 new text pixels 1296x720 old text chars 76x20 new text chars 76x19
xg_frame_resized old native pixels 1344x720 new native pixels 1344x684
adjust_frame_size old native pixels 1344x720 new native pixels 1344x684 old text pixels 1296x720 new text pixels 1296x684 old text chars 76x19 new text chars 76x18

x_new_font old char size 17x37 new char size 17x37 text chars 76x18 old text pixels 1296x684 new text pixels 1292x666
xg_wm_set_size_hint scale 2 char width 17 toolbar 0 vscroll 32 fringes 16 borders 0 text width 646 base width 38 width inc 8
    char height 37 menubar 50 toolbar 82 hscroll 0 borders 0 text height 333 base height 93 height inc 18
xg_frame_set_char_size old native pixels 1344x684 new native pixels 1340x666 outer pixels 670x399 outer rest 0x0
xg_frame_resized old native pixels 1344x684 new native pixels 1340x666
adjust_frame_size old native pixels 1344x684 new native pixels 1340x666 old text pixels 1296x684 new text pixels 1292x666 old text chars 76x18 new text chars 76x18

x_new_font old char size 17x37 new char size 17x37 text chars 76x18 old text pixels 1292x666 new text pixels 1292x666

x_new_font old char size 17x37 new char size 17x37 text chars 76x18 old text pixels 1292x666 new text pixels 1292x666

x_new_font old char size 17x37 new char size 17x37 text chars 76x18 old text pixels 1292x666 new text pixels 1292x666