From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found
Date: Mon, 5 Sep 2016 11:48:15 -0400 [thread overview]
Message-ID: <e837a443-edd7-4883-39e0-aeae8afccd85@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609051429390.32022@calancha-pc>
[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]
On 2016-09-05 01:30, Tino Calancha wrote:
> Good point. I agree is a nuisance having to set those values
> after installing the executable.
> How about following more simple patch?:
> It just check for the required executable at the top of each function
> using it; it signals an error if the executable is not found:
Looks good, but maybe you could extract this to a separate function that takes the variable name and produces the error? There's a bit of duplication in the patch you posted.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-05 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160904134431.30494.94659@vcs.savannah.gnu.org>
[not found] ` <20160904134431.7513F220140@vcs.savannah.gnu.org>
2016-09-04 16:41 ` master ca47390: image-dired: Report when a necessary executable is not found Glenn Morris
2016-09-05 3:42 ` Tino Calancha
2016-09-05 4:42 ` Clément Pit--Claudel
2016-09-05 5:30 ` Tino Calancha
2016-09-05 6:41 ` Andreas Schwab
2016-09-05 7:12 ` Tino Calancha
2016-09-05 15:48 ` Clément Pit--Claudel [this message]
2016-09-05 18:00 ` Tino Calancha
2016-09-12 18:44 ` Glenn Morris
2016-09-12 19:44 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e837a443-edd7-4883-39e0-aeae8afccd85@gmail.com \
--to=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.