* bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
@ 2018-03-13 23:14 Clément Pit-Claudel
2018-03-21 0:26 ` Noam Postavsky
0 siblings, 1 reply; 4+ messages in thread
From: Clément Pit-Claudel @ 2018-03-13 23:14 UTC (permalink / raw)
To: 30812; +Cc: jeffersoncarpenter2
[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]
X-Debbugs-CC: jeffersoncarpenter2@gmail.com
Hi all,
I think the following commit was a bit too enthusiastic, as variables like @temp are now highlighted in font-lock-type-face.
diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -181,4 +181,5 @@
;;
- ;; Fontify local and my keywords as types.
- ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+ ;; Fontify declarators and prefixes as types.
+ ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
+ ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
;;
Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
2018-03-13 23:14 bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de) Clément Pit-Claudel
@ 2018-03-21 0:26 ` Noam Postavsky
2018-03-21 4:21 ` Clément Pit-Claudel
2020-08-22 16:03 ` Lars Ingebrigtsen
0 siblings, 2 replies; 4+ messages in thread
From: Noam Postavsky @ 2018-03-21 0:26 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 30812, jeffersoncarpenter2
unarchive 27613
notfixed 27613 26.1
quit
Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
> I think the following commit was a bit too enthusiastic, as variables
> like @temp are now highlighted in font-lock-type-face.
I've reverted this from emacs-26 [1: f8cad16bb3].
> - ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
> + ;; Fontify declarators and prefixes as types.
> + ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
> + ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
I missed this in the originating thread, but according to what I'm
getting from web searches, most of those keywords are perl 6 specific.
I think perl-mode shouldn't support them.
[1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
Revert "Support all perl variable declarators and prefixes"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
2018-03-21 0:26 ` Noam Postavsky
@ 2018-03-21 4:21 ` Clément Pit-Claudel
2020-08-22 16:03 ` Lars Ingebrigtsen
1 sibling, 0 replies; 4+ messages in thread
From: Clément Pit-Claudel @ 2018-03-21 4:21 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 30812, jeffersoncarpenter2
[-- Attachment #1.1: Type: text/plain, Size: 689 bytes --]
>> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
>
> I missed this in the originating thread, but according to what I'm
> getting from web searches, most of those keywords are perl 6 specific.
> I think perl-mode shouldn't support them.
Thanks. My understanding was that these keywords could safely be highlighted, as long as care was taken to not highlight variable names (distinguishable due to the sigils).
>
> [1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
> Revert "Support all perl variable declarators and prefixes"
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>
> .
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
2018-03-21 0:26 ` Noam Postavsky
2018-03-21 4:21 ` Clément Pit-Claudel
@ 2020-08-22 16:03 ` Lars Ingebrigtsen
1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-22 16:03 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Clément Pit-Claudel, 30812, jeffersoncarpenter2
Noam Postavsky <npostavs@gmail.com> writes:
> Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
>
>> I think the following commit was a bit too enthusiastic, as variables
>> like @temp are now highlighted in font-lock-type-face.
>
> I've reverted this from emacs-26 [1: f8cad16bb3].
If I understand this correctly, that means that this bug report was
fixed, so I'm closing it. If I'm misinterpreting this, please reopen.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-22 16:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 23:14 bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de) Clément Pit-Claudel
2018-03-21 0:26 ` Noam Postavsky
2018-03-21 4:21 ` Clément Pit-Claudel
2020-08-22 16:03 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.