From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#30946: 26.0.90; TRAMP cannot access some files when using hops Date: Tue, 1 Jan 2019 10:48:29 +1300 Message-ID: References: <87o9jbfcsc.fsf@petton.fr> <6e181a50-452c-0e8b-ae5a-0746f64a6dfb@orcon.net.nz> <877efqdjtn.fsf@gmx.de> <87bm51bx8k.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1546292835 16808 195.159.176.226 (31 Dec 2018 21:47:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 31 Dec 2018 21:47:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 Cc: 30946-done@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 31 22:47:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ge5Ou-0004ES-Ra for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Dec 2018 22:47:08 +0100 Original-Received: from localhost ([127.0.0.1]:53761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ge5R1-0001HG-AY for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Dec 2018 16:49:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ge5Qo-0001Gy-UX for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2018 16:49:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ge5Ql-0004oO-4M for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2018 16:49:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ge5Qj-0004mY-Qu for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2018 16:49:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ge5Qj-0001ax-KP for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2018 16:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Dec 2018 21:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 30946-done@debbugs.gnu.org id=D30946.15462929176101 (code D ref 30946); Mon, 31 Dec 2018 21:49:01 +0000 Original-Received: (at 30946-done) by debbugs.gnu.org; 31 Dec 2018 21:48:37 +0000 Original-Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ge5QK-0001aK-HG for submit@debbugs.gnu.org; Mon, 31 Dec 2018 16:48:36 -0500 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]:54831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ge5QH-0001aB-U7 for 30946-done@debbugs.gnu.org; Mon, 31 Dec 2018 16:48:34 -0500 Original-Received: from [150.107.172.17] (port=23534 helo=[192.168.20.103]) by smtp-1.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1ge5QE-0001pr-DX; Tue, 01 Jan 2019 10:48:31 +1300 In-Reply-To: <87bm51bx8k.fsf@gmx.de> Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154055 Archived-At: Hi Michael, On 1/01/19 3:13 AM, Michael Albinus wrote: > I've pushed a fix for this to the master branch; could you pls check? Yes, the tramp master branch works nicely! http://git.savannah.gnu.org/cgit/tramp.git/commit/?id=1dbd930da8 does make me wonder whether it would be good for tramp-user-error to check whether saved-tdpa is bound, and handle the rollback itself, so the code which sets the error doesn't need to? I assume there are other error cases where the rollback doesn't happen and doesn't *need* to happen; but if it's harmless to do so (which I have no idea about), then "roll back any new proxies in the face of an error" might well be a sane behaviour, and might possibly prevent undesirable proxies being added in other situations (speculating). I'm re-closing this bug in any case. Thank you for fixing this. -Phil