From: Phil Sainty <psainty@orcon.net.nz>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 30946-done@debbugs.gnu.org
Subject: bug#30946: 26.0.90; TRAMP cannot access some files when using hops
Date: Tue, 1 Jan 2019 10:48:29 +1300 [thread overview]
Message-ID: <e7ecb5f1-9266-c358-5b8e-eef92e22c579@orcon.net.nz> (raw)
In-Reply-To: <87bm51bx8k.fsf@gmx.de>
Hi Michael,
On 1/01/19 3:13 AM, Michael Albinus wrote:
> I've pushed a fix for this to the master branch; could you pls check?
Yes, the tramp master branch works nicely!
http://git.savannah.gnu.org/cgit/tramp.git/commit/?id=1dbd930da8 does
make me wonder whether it would be good for tramp-user-error to check
whether saved-tdpa is bound, and handle the rollback itself, so the
code which sets the error doesn't need to?
I assume there are other error cases where the rollback doesn't happen
and doesn't *need* to happen; but if it's harmless to do so (which I
have no idea about), then "roll back any new proxies in the face of an
error" might well be a sane behaviour, and might possibly prevent
undesirable proxies being added in other situations (speculating).
I'm re-closing this bug in any case. Thank you for fixing this.
-Phil
next prev parent reply other threads:[~2018-12-31 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 8:42 bug#30946: 26.0.90; TRAMP cannot access some files when using hops Nicolas Petton
2018-03-29 14:11 ` Michael Albinus
2018-04-03 12:02 ` Nicolas Petton
[not found] ` <6e181a50-452c-0e8b-ae5a-0746f64a6dfb@orcon.net.nz>
2018-12-30 22:01 ` Phil Sainty
2018-12-31 11:20 ` Michael Albinus
2018-12-31 12:40 ` Phil Sainty
2018-12-31 14:13 ` Michael Albinus
2018-12-31 21:48 ` Phil Sainty [this message]
2019-01-01 11:54 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ecb5f1-9266-c358-5b8e-eef92e22c579@orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=30946-done@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.