From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19170: 25.0.50; enhancement request: `compare-windows' use across frames Date: Fri, 28 Nov 2014 17:53:38 -0800 (PST) Message-ID: References: <32848088-e8db-46dc-b9c7-f53bc46bb4e1@default> <87egss9r7v.fsf@mail.linkov.net> <2f6cb7a6-e050-4909-9b54-d651523bb5d5@default> <87egss86a8.fsf@mail.linkov.net> <87egsr0xjt.fsf@mail.linkov.net> <87egsqzy74.fsf@mail.linkov.net> <877fyhfno0.fsf@mail.linkov.net> <3dcedc6e-0613-4af5-a061-02395bc9a506@default> <87y4qw5elz.fsf@mail.linkov.net> <54782455.3020206@gmx.at> <8761dzxc05.fsf@mail.linkov.net> <87oarqvn01.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1417226077 19192 80.91.229.3 (29 Nov 2014 01:54:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Nov 2014 01:54:37 +0000 (UTC) Cc: 19170@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 29 02:54:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XuXEz-00070T-9I for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Nov 2014 02:54:29 +0100 Original-Received: from localhost ([::1]:46535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuXEy-00039c-Sy for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 20:54:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuXEm-00039I-Ve for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 20:54:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuXEY-0003eb-Lz for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 20:54:16 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuXEY-0003eX-Iz for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 20:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XuXEY-0006H1-77 for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 20:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Nov 2014 01:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19170-submit@debbugs.gnu.org id=B19170.141722602924092 (code B ref 19170); Sat, 29 Nov 2014 01:54:02 +0000 Original-Received: (at 19170) by debbugs.gnu.org; 29 Nov 2014 01:53:49 +0000 Original-Received: from localhost ([127.0.0.1]:48795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XuXEK-0006GW-BJ for submit@debbugs.gnu.org; Fri, 28 Nov 2014 20:53:48 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:49026) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XuXEH-0006GM-LP for 19170@debbugs.gnu.org; Fri, 28 Nov 2014 20:53:46 -0500 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sAT1rh1w031313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 29 Nov 2014 01:53:44 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sAT1rgRn026999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 29 Nov 2014 01:53:42 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sAT1rfCk011195; Sat, 29 Nov 2014 01:53:41 GMT In-Reply-To: <87oarqvn01.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96719 Archived-At: > > Looks good to me. Please apply it. But "matching points" > > should be "match positions" - "point" can be confusing. >=20 > Wouldn't a shorter phrase be valid too: "No more matches"? Sure, for that case. > > Possible enhancements, but not required to close this > > enhancement request: > > > > 1. I do still think it would be good to provide more info > > in the message. >=20 > All extra info is easy to get using standard commands: >=20 > a) point values are easy to get with `C-x =3D' > b) the previous point with `C-x C-x' > c) the size of the skipped region with `M-=3D' Not for both windows/buffers, not without moving between them. Think about `diff' output, for instance. Sometimes it can be helpful to see the point or line numbers. Admittedly, it's not essential. Whatever info we show should be because we want to show the two together, for comparison. > The only info that is not obvious is the name of another > window compared with the selected window. I don't agree - see previous. But I don't feel strongly about it. > > 2. As I proposed in the past, I think it would be good to > > (as I do) bind comparison commands to the same prefix. > > I bind them to prefix `C-=3D' (just one possibility): > > > > C-=3D b is ediff-buffers > > C-=3D d is diff > > C-=3D e is ediff-files > > C-=3D f is ediff-files > > C-=3D w is compare-windows-repeat > > > > 3. `compare-windows-repeat' is just a repeatable version > > of `compare-windows', so you can repeat it using, for > > example, `C-=3D w w w w w'. Very handy, especially > > given the improvements you've just made. >=20 > Binding `compare-windows' to a single key `C-=3D' makes it easy > to repeat in a long sequence of its invocations :) Sure, but why not put comparison commands on the same, mnemonic prefix key? If you forget a particular comparison command binding, `C-=3D C-h' will tell you. And as soon as you put `compare-windows' on a prefix key you cannot use it repeatedly, the way it is currently defined. Operations that one might want to use repeatedly (e.g. because they perform an incremental operation) should, in general, be repeatable from a prefix key too, IMO. But this is not part of this particular enhancement request.