From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 eec71eb: Speed up replace-buffer-contents Date: Sat, 7 Jul 2018 11:22:33 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20180629135646.6054.66405@vcs0.savannah.gnu.org> <20180629135648.5C95A2053B@vcs0.savannah.gnu.org> <698fc242-71bf-0e6e-5e45-d1be45cbc074@cs.ucla.edu> <837emcjezc.fsf@gnu.org> <517756be-f05e-1fd1-afc9-f8b6d47252f2@cs.ucla.edu> <83va9vohom.fsf@gnu.org> <4705d730-b5a4-efd2-028f-40478b1ac1d5@cs.ucla.edu> <83o9fnnikb.fsf@gnu.org> <8336wyone1.fsf@gnu.org> <831scfjm1d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1530987678 21218 195.159.176.226 (7 Jul 2018 18:21:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 18:21:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: rgm@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 07 20:21:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbrpZ-0005Oh-J2 for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 20:21:13 +0200 Original-Received: from localhost ([::1]:34549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbrrg-00018M-IM for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 14:23:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbrqz-00018F-7d for emacs-devel@gnu.org; Sat, 07 Jul 2018 14:22:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbrqy-0005WX-Bk for emacs-devel@gnu.org; Sat, 07 Jul 2018 14:22:41 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38434) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fbrqu-0005UK-K8; Sat, 07 Jul 2018 14:22:36 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 805E7160653; Sat, 7 Jul 2018 11:22:35 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ElORwljibIW9; Sat, 7 Jul 2018 11:22:34 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AEF3E160655; Sat, 7 Jul 2018 11:22:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M0TUz3YzBGc5; Sat, 7 Jul 2018 11:22:34 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 56426160653; Sat, 7 Jul 2018 11:22:34 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <831scfjm1d.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227076 Archived-At: Eli Zaretskii wrote: > Profiling the optimized build shows that 60% of the time is spent > inside buffer_chars_equal, and another 26% inside compareseq. > rarely_quit and maybe_quit are nowhere in sight in the profile. That's what I would expect: rarely_quit is inlined, so you don't see it in the profile (even though it's there and has some cost), and maybe_quit is called so rarely that you don't see it in the profile. > So I think we have no performance problem we need to fix, right? It sounds like we never had a performance problem in optimized builds that we needed to fix. I.e., the recent patch was needed only for unoptimized builds. Which is unfortunate, as we shouldn't have to hand-optimize unoptimized builds. I'll keep that in mind if I ever find time to look into the performance problem.