From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Date: Mon, 13 Jun 2022 01:17:28 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 To: Eason Huang , 55396@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 13 00:18:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0VuO-0004No-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 00:18:12 +0200 Original-Received: from localhost ([::1]:42774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0VuM-0000O6-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Jun 2022 18:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0VuE-0000Nr-PS for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2022 18:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0VuE-0003Ri-Gp for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2022 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0VuE-0007Pf-9L for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2022 18:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jun 2022 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55396 X-GNU-PR-Package: emacs Original-Received: via spool by 55396-submit@debbugs.gnu.org id=B55396.165507226228466 (code B ref 55396); Sun, 12 Jun 2022 22:18:02 +0000 Original-Received: (at 55396) by debbugs.gnu.org; 12 Jun 2022 22:17:42 +0000 Original-Received: from localhost ([127.0.0.1]:56617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Vtt-0007P4-Tl for submit@debbugs.gnu.org; Sun, 12 Jun 2022 18:17:42 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:43560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Vtp-0007On-Ae for 55396@debbugs.gnu.org; Sun, 12 Jun 2022 18:17:40 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id m24so4993589wrb.10 for <55396@debbugs.gnu.org>; Sun, 12 Jun 2022 15:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tVxzxYWTJDale4e6WRtTjKewwMKNsXDFBGJjOIWgazg=; b=iQYyY/hgwaB4NTA3A0VznN/8lQS74GmH44vGx+aQQj3htLp6nIiW5wJdZ+974/j2ys OVqi7CnJLLErkt6Pr86BEDWWOcM7uy+aSEnjMxHnSfDJPkvk9GBBc1uQefxT6Upl9vhi zXfxNsXzbmZRQBi6rGRIAJPUCjm614/VU/FROpB3pWlfPKnp2r/jawoJpFH6ZBRu7nqU iSxW2oV35tE9y198d+lf9vpBGexQEb59mnV6hi6BEgD4EqTrI7dr5kB0pS/p9IwGqyKn mPkSg49LaTYeIuzCJF4UMUUHO6XHnQwz7EO2fo7e9nNTbhRJgW9HGBQ4ItXy3Wq1NQmW rW4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tVxzxYWTJDale4e6WRtTjKewwMKNsXDFBGJjOIWgazg=; b=wembtdpUzmt6kXSsb77Me6hB693xAKziIjXNY1iVlqY0o92WGw7E4xibJ5EzqMD8mI vf06wfa/msHknNQgEaFCu6gDz4m4rFYJDzepNg+sjKSWROlf6VheAIJLPQYompWW1TUE k1ciSNFjwgBKTZv0dd9gNC2pQPfqVIDxhVc8cQBNzNRu6teVjepbEx+y41wmM0tQlMPV HLzbbIAwTegLsdkBrCk7Czbm6lfAIfnh0NXFb2fsh0rR8rCIFpTyzAtnbFrpOXa51gOi CYx+Oe3zXjVMATZBKSp/AcVU+6f07nm7g1XDjvFSgc0BHtL1X0GV99GRF7wuojJYGnOl sE6w== X-Gm-Message-State: AOAM530SOBThQyqvLVW1RMsvEsn5JOKurNbEqQ0OxzrgF6sAO0PNrNY9 CdfzXd2fOkzJUzLnUaf5L+8= X-Google-Smtp-Source: ABdhPJx0Kkd9fqrSpYAx1Oul1zE3f+uWk0FI4cHGkCWNgacQ6v1d7CzC18Yzpf41FA9HfJ7hL42ysw== X-Received: by 2002:a5d:59a5:0:b0:218:3ffb:e6ea with SMTP id p5-20020a5d59a5000000b002183ffbe6eamr37483320wrr.715.1655072251218; Sun, 12 Jun 2022 15:17:31 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id x5-20020a5d54c5000000b002167efdd549sm6760003wrv.38.2022.06.12.15.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 15:17:30 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234374 Archived-At: Hi again, sorry for the delay. On 13.05.2022 15:56, Eason Huang wrote: > And I try to start emacs with `emacs -q`, set `(setq debug-on-errort)`. > Then reproduce the issue, will get the following debug error: > > Debugger entered--Lisp error: (excessive-variable-binding) > call-process("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") > process-file("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--call((t nil) "ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--out-ok("ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--run-command-string(nil "ls-files" "-z" "-c" "-o" "--exclude-standard") > project--vc-list-files("/Users/eason/.emacs.d/lib/aggressive-indent" Git nil) > #f(compiled-function (module) #)("lib/aggressive-indent") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) Looking at the backtrace again, it seems the problem is not related to the number of submodules. It's a plain infloop. Could you try to help with debugging? Alternatively, you could provide a simple repo with this problem that doesn't require Borg to initialize. Though it probably doesn't (shouldn't) require Borg anyway, given how the problem looks. What does project--vc-list-files do in your case? It calls 'git ls-files' to fetch the list of files in the parent repo, then parses the list of submodules in it, and repeats the same call inside each submodule (using (concat default-directory module) as target). Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over and over again. So it seems like (project--git-submodules) returns a list which has "." as one of its elements. How does that happen? Do you have a submodule entry which points to "."?