bug#14914: 24.3.50; Menu item for `dired-hide-details-mode' should be `Hide/Show Details'

[Drew Adams <drew.adams@oracle.com>]

> [✓] Show details

I almost suggested that too (but with title case: `Show Details').
I probably should have mentioned it.  I did not because of the
considerations below, but I'm glad you have brought it up now.

I have no objection to that, but in that case we should perhaps
do likewise for other toggles in Dired, such as `Toggle Image
Thumbnails in This Buffer' (which also happens to be a bad name,
IMO).

Another consideration is that the use of a check box for a toggle
often corresponds to an actual user option, i.e., a variable that
one can customize.  And in fact, I believe, that was the original
sense of  menu `Options', hence the name.  There are notable
exceptions, such as `Tool-bar' on `Options' > `Show/Hide', which
do not correspond to options (and which perhaps should not be on
menu `Options'?).

Another consideration is perhaps that, so far, menu `Options',
which is a main place where we use such check boxes, seems to
be limited to global toggles, not buffer-local ones (didn't check
them all though).  Likewise menu `Printing', which is another
place where we use the check boxes heavily.  However, Dired menu
`Immediate' does have the buffer-specific `Toggle Image
Thumbnails in This Buffer'.

I don't know what the general policy/guideline is, if there is
one, wrt the use of check boxes.  Should they be limited to
user options?  Should they be limited to behavior that is global
and not buffer-specific?  Dunno.

Should we perhaps have a visual convention that makes clear
whether a particular toggle (a) is global or local and (b)
corresponds to an option or not?  Without that, users need to
use `C-h k' or mouseover :help to get more info about an item,
and unfortunately such info does not always answer the question
because it was written in a context where the answer was clear
enough without being explicit.

In sum, I would be OK with a `Show Details' check box on the
Dired `Immediate' menu, provided those who set the guidelines ;-)
think it fits wrt the above considerations (i.e., that it is
OK that it is for a minor mode, with no associated user option,
and that it is OK that it is buffer-local).

I agree that having a check box makes clear that the item is
a toggle.  That is a decided advantage, making for quicker
locating and identifying.  My only hesitation is the lack of
clarity for users wrt whether the toggle is for a customizable
variable and whether it is buffer-local or global.

Thanks again for bringing up the check-box question in this context.